251977 2023-02-09 01:05:43 -0800 [GTK4] Enable threaded rendering again using 1 painting thread by default 2023-04-25 08:04:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=247628 https://bugs.webkit.org/show_bug.cgi?id=253108 https://bugs.webkit.org/show_bug.cgi?id=253953 https://bugs.webkit.org/show_bug.cgi?id=255923 Gtk P2 Normal --- 210100 1 cgarcia cgarcia bugs-noreply mcatanzaro oldest_to_newest 1932277 0 cgarcia 2023-02-09 01:05:43 -0800 It seems the issues with threaded rendering were actually caused by using multiple painting threads, but we can still use a single thread to move the painting off the main thread. 1932279 1 cgarcia 2023-02-09 01:09:29 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9854 1932310 2 ews-feeder 2023-02-09 04:09:21 -0800 Committed 260059@main (4af5eb3490da): <https://commits.webkit.org/260059@main> Reviewed commits have been landed. Closing PR #9854 and removing active labels. 1932311 3 mcatanzaro 2023-02-09 04:12:50 -0800 Maybe should also change: WTFLogAlways("The number of Nicosia painting threads is not between 1 and 8. Using the default value 4\n"); numThreads = 4; 1932312 4 mcatanzaro 2023-02-09 04:13:20 -0800 Why can't WPE use one thread? 1932315 5 cgarcia 2023-02-09 04:32:07 -0800 WPE doesn't enable threaded rendering by default. 1932316 6 cgarcia 2023-02-09 04:32:46 -0800 The default is 4, for GTK we use 1 which is not the default value. 1932319 7 mcatanzaro 2023-02-09 04:56:28 -0800 Just kind of weird for the "default" to be 4 when GTK uses 1 and WPE uses 0 and nothing uses 4. Whatever. 1937537 8 mcatanzaro 2023-02-28 13:59:52 -0800 I think this was not safe to do after all. See bug #247628 and bug #253108.