251157 2023-01-25 09:44:50 -0800 [REGRESSION] Unauthenticated request to list PR files triggering rate-limits 2023-01-25 14:19:57 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=246323 https://bugs.webkit.org/show_bug.cgi?id=250714 InRadar P2 Normal --- 1 aakash_jain jbedard aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1928170 0 aakash_jain 2023-01-25 09:44:50 -0800 JSC queues are not skipping some non-relevant PRs. e.g.: https://ews-build.webkit.org/#/builders/1/builds/94597 https://ews-build.webkit.org/#/builders/1/builds/94551 https://ews-build.webkit.org/#/builders/1/builds/94604 https://ews-build.webkit.org/#/builders/1/builds/94595 https://ews-build.webkit.org/#/builders/1/builds/94593 https://ews-build.webkit.org/#/builders/1/builds/94589 https://ews-build.webkit.org/#/builders/1/builds/94587 1928177 1 aakash_jain 2023-01-25 09:50:12 -0800 Example of recent build in which the logic worked fine: https://ews-build.webkit.org/#/builders/1/builds/94523 In this "check-change-relevance" step says: "Pull request doesn't have relevant changes" and the 'stdio' log say: "This pull request does not have relevant changes." 1928178 2 aakash_jain 2023-01-25 09:53:45 -0800 In the non-working build https://ews-build.webkit.org/#/builders/1/builds/94597, check-change-relevance step says: "Pull request contains relevant changes", and no 'stdio' log. IN this build from Jan 13, when "check-change-relevance" said "Pull request contains relevant changes", there was also 'stdio' log saying: "This pull request contains relevant changes.": https://ews-build.webkit.org/#/builders/1/builds/93414 Missing 'stdio' log indicate that in CheckChangeRelevance.start() self._get_patch() returned empty patch triggering this code path for early exit (without any 'stdio' log): https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/steps.py#L1211 _get_patch() method was recently changed on Jan 19 in https://commits.webkit.org/259088@main 1928210 3 aakash_jain 2023-01-25 11:13:28 -0800 For non-working build https://ews-build.webkit.org/#/builders/1/builds/94597, https://ews-build.webkit.org/api/v2/sourcestamps/740172/changes shows that the files in sourcestamp was empty []. However, for old working build https://ews-build.webkit.org/#/builders/1/builds/93414, https://ews-build.webkit.org/api/v2/sourcestamps/736612/changes shows that the files in sourcestamp was non-empty. Also, the logs on server have this: twistd.log.1:2023-01-25 09:39:38-0800 [HTTP11ClientProtocol (TLSMemoryBIOProtocol),client] Failed fetching files for PR #9083: response code 400 1928211 4 aakash_jain 2023-01-25 11:17:48 -0800 Seems like a regression from https://commits.webkit.org/259282@main (Bug 250714) 1928224 5 jbedard 2023-01-25 11:58:37 -0800 We aren't fetching files with auth, that's the problem, silly mistake, easy fix. 1928235 6 aakash_jain 2023-01-25 12:33:57 -0800 This is happening on multiple queues including WebkitPy (e.g.: https://ews-build.webkit.org/#/builders/5/builds/108210), Services-EWS (e.g.: https://ews-build.webkit.org/#/builders/20/builds/103549) etc. 1928236 7 webkit-bug-importer 2023-01-25 12:40:26 -0800 <rdar://problem/104659979> 1928237 8 jbedard 2023-01-25 12:43:20 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9141 1928243 9 ews-feeder 2023-01-25 12:54:53 -0800 Committed 259382@main (42ad013f55b2): <https://commits.webkit.org/259382@main> Reviewed commits have been landed. Closing PR #9141 and removing active labels. 1928272 10 jbedard 2023-01-25 14:12:35 -0800 Re-opening for pull request https://github.com/WebKit/WebKit/pull/9149 1928273 11 ews-feeder 2023-01-25 14:19:54 -0800 Committed 259386@main (c54b1f4645fb): <https://commits.webkit.org/259386@main> Reviewed commits have been landed. Closing PR #9149 and removing active labels.