<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>249685</bug_id>
          
          <creation_ts>2022-12-20 16:41:30 -0800</creation_ts>
          <short_desc>[CSS-Typed-OM] StylePropertyMap.set() should throw when trying to set a number for a property which doesn&apos;t allow it</short_desc>
          <delta_ts>2022-12-22 07:53:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>175733</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1920941</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-12-20 16:41:30 -0800</bug_when>
    <thetext>StylePropertyMap.set() should throw when trying to set a number for a property which doesn&apos;t allow it.

We previously relied on our CSS parser for validation. However, CSS parsing is more permissive than CSS Typed OM is some cases. In particular, the CSS parser will append &quot;px&quot; to numbers in some cases for properties that need a &lt;length&gt;. For CSS Typed OM, the type needs to match exactly:
- https://drafts.css-houdini.org/css-typed-om-1/#cssstylevalue-match-a-grammar</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1920942</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-12-20 16:47:08 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/7945</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1921372</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-12-22 07:52:44 -0800</bug_when>
    <thetext>Committed 258242@main (add3c9105b58): &lt;https://commits.webkit.org/258242@main&gt;

Reviewed commits have been landed. Closing PR #7945 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1921373</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-12-22 07:53:15 -0800</bug_when>
    <thetext>&lt;rdar://problem/103638252&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>