<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>249498</bug_id>
          
          <creation_ts>2022-12-16 14:13:12 -0800</creation_ts>
          <short_desc>[web-animations] add an AnimatableProperty type to encapsulate either a standard or custom property</short_desc>
          <delta_ts>2022-12-17 04:53:42 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Animations</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=249530</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>249399</blocked>
    
    <blocked>249533</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Antoine Quint">graouts</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>dino</cc>
    
    <cc>graouts</cc>
    
    <cc>koivisto</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1920058</commentid>
    <comment_count>0</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-12-16 14:13:12 -0800</bug_when>
    <thetext>The animation code is currently heavily biased towards dealing with &quot;standard&quot; CSS properties, represented by the CSSPropertyID type. However, with the work to add interpolation support for custom properties (see bug 249293) and to support CSS Transitions for custom properties (see bug 249399), we really need to deal with both custom properties and standard properties everywhere we currently deal with only standard properties. So let&apos;s add a new type, AnimatableProperty, which is an std::variant&lt;CSSPropertyID, AtomString&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1920060</commentid>
    <comment_count>1</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-12-16 14:20:18 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/7780</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1920215</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-12-17 03:13:17 -0800</bug_when>
    <thetext>Committed 258040@main (ea7b3989b369): &lt;https://commits.webkit.org/258040@main&gt;

Reviewed commits have been landed. Closing PR #7780 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1920216</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-12-17 03:14:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/103477720&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>