249248 2022-12-13 12:56:17 -0800 [GPU Process] [FormControls] Route drawing the ControlPart through GraphicsContext 2022-12-16 07:06:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 249168 1 sabouhallawa sabouhallawa bfulgham fujii simon.fraser webkit-bug-importer zalan oldest_to_newest 1918894 0 sabouhallawa 2022-12-13 12:56:17 -0800 We will make RenderBox create a ControlPart from its DOM element. We will start by the MeterPart as an example for the whole workflow since it is a simple control. RenderBox::paintBoxDecorations() will call GraphicsContext::drawControlPart() which will delegate the call to ControlPart::draw(). ControlPart::draw() will create the PlatformControl using its ControlFactory. On macOS the ControlFactory will be of type ControlFactoryMac and the PlatformControl will be of type MeterMac. ControlPart::draw() will call MeterMac::draw() which will call AppKit to draw the NSLevelIndicatorCell. For GPUP a new DisplayList item named DrawControlPart will be added. This will route the display to RemoteDisplayListRecorder which will call drawControlPart() from its ImageBuffer context. Because ControlFactoryMac will use a single NSLevelIndicatorCell for all MeterMac it creates, there should be a ControlFactoryMac per rendering thread in GPUP. So each RemoteDisplayListRecorder should have one ControlFactoryMac and should set it all in the ControlParts its renders through ControlPart::setControlFactory(). 1918895 1 webkit-bug-importer 2022-12-13 12:56:48 -0800 <rdar://problem/103315944> 1918896 2 simon.fraser 2022-12-13 12:57:33 -0800 > RenderBox::paintBoxDecorations() will call GraphicsContext::drawControlPart() What role will RenderTheme play in this code path? 1918899 3 sabouhallawa 2022-12-13 13:07:40 -0800 Pull request: https://github.com/WebKit/WebKit/pull/7566 1919863 4 ews-feeder 2022-12-16 02:33:23 -0800 Committed 257981@main (27e83068fe9e): <https://commits.webkit.org/257981@main> Reviewed commits have been landed. Closing PR #7566 and removing active labels. 1919920 5 sabouhallawa 2022-12-16 07:06:54 -0800 (In reply to Simon Fraser (smfr) from comment #2) > > RenderBox::paintBoxDecorations() will call GraphicsContext::drawControlPart() > > What role will RenderTheme play in this code path? RenderTheme will create the ControlPart from the RenderBox and its renderer. RenderThemeMac will answer questions specific to macOS when creating the ControlPart.