<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24903</bug_id>
          
          <creation_ts>2009-03-27 15:06:09 -0700</creation_ts>
          <short_desc>Text files which have sub MIME types are treated as not displayable</short_desc>
          <delta_ts>2010-06-10 17:44:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>REOPENED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Christian Dywan">christian</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>ap</cc>
    
    <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>115622</commentid>
    <comment_count>0</comment_count>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-03-27 15:06:09 -0700</bug_when>
    <thetext>WebKit has an idea of text, image and plugin types it can display. Unfortunately it doesn&apos;t recognize sub types such as text/x-c and similar types. WebCore actually double checks in the &quot;use&quot; policy delegate so applications can&apos;t even override this.

I&apos;m looking what the correct fix is right now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115645</commentid>
    <comment_count>1</comment_count>
      <attachid>29033</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-03-27 17:04:00 -0700</bug_when>
    <thetext>Created attachment 29033
Recognize sub types of text/plain

Since we have a fixed list of supported types, and text/plain is among the supported types, I think the correct fix is regarding any subtype of text/plain as valid. This patch does that.

I&apos;m wondering if we can use this for images as well, ie. png images with unusual MIME types, but I don&apos;t have examples to test this right now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115646</commentid>
    <comment_count>2</comment_count>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-03-27 17:10:12 -0700</bug_when>
    <thetext>Okay, I actually found an image, of type image/x-png, but it doesn&apos;t work like that it seems.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115830</commentid>
    <comment_count>3</comment_count>
      <attachid>29033</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-03-30 09:49:14 -0700</bug_when>
    <thetext>Comment on attachment 29033
Recognize sub types of text/plain

The issue here seems to be a shortcoming in MIMETypeRegistry::isSupportedNonImageMIMEType, and should be fixed there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115875</commentid>
    <comment_count>4</comment_count>
      <attachid>29084</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-03-30 13:41:55 -0700</bug_when>
    <thetext>Created attachment 29084
Recognize any text/* type

This is a different approach, now isSupportedNonImageMIMEType actually reports any type starting with &quot;text/&quot; as supported.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115878</commentid>
    <comment_count>5</comment_count>
      <attachid>29084</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-03-30 14:03:28 -0700</bug_when>
    <thetext>Comment on attachment 29084
Recognize any text/* type

Needs a change log.

Change looks good. I don&apos;t understand why these functions are case sensitive, but they are, so the new code matches what&apos;s already here.

Besides &quot;text/&quot;, you should remove all the &quot;text/*&quot; MIME types from initializeSupportedNonImageMimeTypes because none of them do us any good. That includes &quot;text/vnd.wap.wml&quot; as well as the others that are not inside an ifdef.

Can you write a regression test too? There should be a way to test this in our HTTP tests if not the plain text tests.

review- because of lack of a change log and the other issues mentioned above.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115879</commentid>
    <comment_count>6</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-03-30 14:06:02 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Can you write a regression test too? There should be a way to test this in our
&gt; HTTP tests if not the plain text tests.

I meant &quot;in our HTTP tests if not the local file tests&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122394</commentid>
    <comment_count>7</comment_count>
      <attachid>30550</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-05-21 12:46:54 -0700</bug_when>
    <thetext>Created attachment 30550
Recognize any text/* type #2

I updated the patch to remove all text/ types from the list and added a ChangeLog entry.

I didn&apos;t add a test because I&apos;m rather clueless about adding new tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122395</commentid>
    <comment_count>8</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-05-21 12:48:11 -0700</bug_when>
    <thetext>This would be *much* better with a test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122415</commentid>
    <comment_count>9</comment_count>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-05-21 13:59:13 -0700</bug_when>
    <thetext>2009-05-21  Christian Dywan  &lt;christian@twotoasts.de&gt;

        Reviewed by Darin Adler.

        Text files which have sub MIME types are treated as not displayable
        http://bugs.webkit.org/show_bug.cgi?id=24903

        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedNonImageMimeTypes):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
        MIME type beginning with &quot;text/&quot; as supported and remove all &quot;text/&quot;
        types from the list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122416</commentid>
    <comment_count>10</comment_count>
      <attachid>30550</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-05-21 14:00:17 -0700</bug_when>
    <thetext>Comment on attachment 30550
Recognize any text/* type #2

I committed the patch.

Gustavo seems to have a test for this, so I&apos;m leaving this open until the test is done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122425</commentid>
    <comment_count>11</comment_count>
      <attachid>30556</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-05-21 14:27:31 -0700</bug_when>
    <thetext>Created attachment 30556
Test for acceptance of text/* types

 LayoutTests/ChangeLog                              |    9 ++++++
 .../tests/mime/accept-all-text-types-expected.txt  |    4 +++
 .../http/tests/mime/accept-all-text-types.html     |   27 ++++++++++++++++++++
 3 files changed, 40 insertions(+), 0 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122427</commentid>
    <comment_count>12</comment_count>
      <attachid>30556</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-05-21 14:28:23 -0700</bug_when>
    <thetext>Comment on attachment 30556
Test for acceptance of text/* types

Here&apos;s the test case, along with expected results. This is my first layout test, so please advise =).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122432</commentid>
    <comment_count>13</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-05-21 14:55:58 -0700</bug_when>
    <thetext>Landed the test. I forgot to add the cgi script on the first go, though, so added in a second commit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122449</commentid>
    <comment_count>14</comment_count>
    <who name="">mitz</who>
    <bug_when>2009-05-21 16:24:50 -0700</bug_when>
    <thetext>Rolled out this patch in r44000 because it caused bug 25947</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122472</commentid>
    <comment_count>15</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2009-05-21 17:06:15 -0700</bug_when>
    <thetext>This broke all layout tests - run them before landing patches!!!  =D

Darin had a comment:
&quot;Besides &quot;text/&quot;, you should remove all the &quot;text/*&quot; MIME types from
initializeSupportedNonImageMimeTypes because none of them do us any good. That
includes &quot;text/vnd.wap.wml&quot; as well as the others that are not inside an ifdef.&quot;

This was incorrect.  In addition to answering the question &quot;is this a supported non image mimetype?&quot;, MIMETypeRegistry also has the role of delivering a collection of all known non-image MIME types via the ::getSupportedNonImageMIMETypes() method.

That method is exposed to the WebKit layer of the various platforms who do various things with it.  This completely hosed the Mac platform as it no longer registered WebHTMLView as the view class for &quot;text/html&quot;, since &quot;text/html&quot; never showed up in the list of supported MIME types. 

The other half of the change - having isSupportedNonImageMIMEType() return true if the passed in type starts with &quot;text/&quot; might be valid.  We might need further changes to the design here such that we can do fuzzy matching of subtypes.  But the full types we explicitly list in the registry must remaining explicitly listed!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122476</commentid>
    <comment_count>16</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2009-05-21 17:24:42 -0700</bug_when>
    <thetext>To be fair, it only broke all layout tests on Mac and Windows.  It didn&apos;t break GTK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122529</commentid>
    <comment_count>17</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-05-21 20:53:42 -0700</bug_when>
    <thetext>See also: bug 24618.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>122781</commentid>
    <comment_count>18</comment_count>
      <attachid>30550</attachid>
    <who name="Jan Alonzo">jmalonzo</who>
    <bug_when>2009-05-22 20:50:23 -0700</bug_when>
    <thetext>Comment on attachment 30550
Recognize any text/* type #2

Clearing r+ as this patch was landed then rolled-out.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129371</commentid>
    <comment_count>19</comment_count>
      <attachid>32143</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-07-01 14:39:59 -0700</bug_when>
    <thetext>Created attachment 32143
Treat all text/ subtypes as supported

 WebCore/ChangeLog                     |   19 +++++++++++++++++++
 WebCore/platform/MIMETypeRegistry.cpp |    2 ++
 2 files changed, 21 insertions(+), 0 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129383</commentid>
    <comment_count>20</comment_count>
    <who name="Evan Martin">evan</who>
    <bug_when>2009-07-01 15:08:20 -0700</bug_when>
    <thetext>+abarth for mime changes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129384</commentid>
    <comment_count>21</comment_count>
      <attachid>32143</attachid>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2009-07-01 15:13:09 -0700</bug_when>
    <thetext>Comment on attachment 32143
Treat all text/ subtypes as supported

This leaves an inconsistency between getSupportedNonImageMIMETypes and what isSupportedNonImageMIMEType will return.  I suspect this will again cause subtle problems for the Mac, as it uses both of these functions within WebKit/mac.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129391</commentid>
    <comment_count>22</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-01 15:31:20 -0700</bug_when>
    <thetext>Can we please add a test that &quot;text/foobar&quot; is doesn&apos;t render HTML tags?  I&apos;m pretty sure it won&apos;t, but testing is better than guessing.  :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>29033</attachid>
            <date>2009-03-27 17:04:00 -0700</date>
            <delta_ts>2009-03-30 13:41:55 -0700</delta_ts>
            <desc>Recognize sub types of text/plain</desc>
            <filename>canshowmime.diff</filename>
            <type>text/plain</type>
            <size>1492</size>
            <attacher name="Christian Dywan">christian</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRH
dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5j
cHAKaW5kZXggYTU0YWVjYy4uNTg2M2VkOCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTc0MSwxMCArNzQxLDI2IEBAIGJv
b2wgRnJhbWVMb2FkZXJDbGllbnQ6OmNhbkhhbmRsZVJlcXVlc3QoY29uc3QgUmVzb3VyY2VSZXF1
ZXN0JikgY29uc3QKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorc3RhdGljIGJvb2wgTUlNRVR5cGVJ
c0EoY29uc3QgU3RyaW5nJiB0eXBlLCBjb25zdCBTdHJpbmcmIHN1cGVyVHlwZSkKK3sKKyNpZiBH
TElCX0NIRUNLX1ZFUlNJT04gKDIsIDE4LCAwKQorICAgIGdjaGFyKiBjb250ZW50VHlwZSA9IGdf
Y29udGVudF90eXBlX2Zyb21fbWltZV90eXBlKHR5cGUudXRmOCgpLmRhdGEoKSk7CisgICAgZ2No
YXIqIGNvbnRlbnRTdXBlclR5cGUgPSBnX2NvbnRlbnRfdHlwZV9mcm9tX21pbWVfdHlwZShzdXBl
clR5cGUudXRmOCgpLmRhdGEoKSk7CisgICAgYm9vbCBpc1N1YlR5cGUgPSBnX2NvbnRlbnRfdHlw
ZV9pc19hKGNvbnRlbnRUeXBlLCBjb250ZW50U3VwZXJUeXBlKTsKKyAgICBnX2ZyZWUoY29udGVu
dFN1cGVyVHlwZSk7CisgICAgZ19mcmVlKGNvbnRlbnRUeXBlKTsKKyAgICByZXR1cm4gaXNTdWJU
eXBlOworI2Vsc2UKKyAgICByZXR1cm4gZ19jb250ZW50X3R5cGVfaXNfYSh0eXBlLnV0ZjgoKS5k
YXRhKCksIHN1cGVyVHlwZS51dGY4KCkuZGF0YSgpKTsKKyNlbmRpZgorfQorCiBib29sIEZyYW1l
TG9hZGVyQ2xpZW50OjpjYW5TaG93TUlNRVR5cGUoY29uc3QgU3RyaW5nJiB0eXBlKSBjb25zdAog
ewotICAgIHJldHVybiBNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1cHBvcnRlZEltYWdlTUlNRVR5cGUo
dHlwZSkgfHwgTUlNRVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlKHR5
cGUpIHx8Ci0gICAgICAgIFBsdWdpbkRhdGFiYXNlOjppbnN0YWxsZWRQbHVnaW5zKCktPmlzTUlN
RVR5cGVSZWdpc3RlcmVkKHR5cGUpOworICAgIHJldHVybiBNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1
cHBvcnRlZEltYWdlTUlNRVR5cGUodHlwZSkKKyAgICAgICAgfHwgTUlNRVR5cGVSZWdpc3RyeTo6
aXNTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlKHR5cGUpCisgICAgICAgIHx8IFBsdWdpbkRhdGFi
YXNlOjppbnN0YWxsZWRQbHVnaW5zKCktPmlzTUlNRVR5cGVSZWdpc3RlcmVkKHR5cGUpCisgICAg
ICAgIHx8IE1JTUVUeXBlSXNBKHR5cGUsICJ0ZXh0L3BsYWluIik7CiB9CiAKIGJvb2wgRnJhbWVM
b2FkZXJDbGllbnQ6OnJlcHJlc2VudGF0aW9uRXhpc3RzRm9yVVJMU2NoZW1lKGNvbnN0IFN0cmlu
ZyYpIGNvbnN0Cg==
</data>
<flag name="review"
          id="14374"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>29084</attachid>
            <date>2009-03-30 13:41:55 -0700</date>
            <delta_ts>2009-05-21 12:46:54 -0700</delta_ts>
            <desc>Recognize any text/* type</desc>
            <filename>canshowmime.diff</filename>
            <type>text/plain</type>
            <size>805</size>
            <attacher name="Christian Dywan">christian</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAgYi9XZWJD
b3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuY3BwCmluZGV4IDhmOTg3MzUuLjMyYzVmNTkg
MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAKKysrIGIv
V2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcApAQCAtMTg3LDcgKzE4Nyw2IEBA
IHN0YXRpYyB2b2lkIGluaXRpYWxpemVTdXBwb3J0ZWROb25JbWFnZU1pbWVUeXBlcygpCiAgICAg
ICAgICJ0ZXh0L3htbCIsCiAgICAgICAgICJ0ZXh0L3hzbCIsCiAgICAgICAgICJ0ZXh0L3BsYWlu
IiwKLSAgICAgICAgInRleHQvIiwKICAgICAgICAgImFwcGxpY2F0aW9uL3htbCIsCiAgICAgICAg
ICJhcHBsaWNhdGlvbi94aHRtbCt4bWwiLAogICAgICAgICAiYXBwbGljYXRpb24vcnNzK3htbCIs
CkBAIC0yNzksNiArMjc4LDggQEAgYm9vbCBNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1cHBvcnRlZE5v
bkltYWdlTUlNRVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKIHsKICAgICBpZiAobWltZVR5
cGUuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKG1pbWVUeXBlLnN0
YXJ0c1dpdGgoInRleHQvIikpCisgICAgICAgIHJldHVybiB0cnVlOwogICAgIGlmICghc3VwcG9y
dGVkTm9uSW1hZ2VNSU1FVHlwZXMpCiAgICAgICAgIGluaXRpYWxpemVNSU1FVHlwZVJlZ2lzdHJ5
KCk7CiAgICAgcmV0dXJuIHN1cHBvcnRlZE5vbkltYWdlTUlNRVR5cGVzLT5jb250YWlucyhtaW1l
VHlwZSk7Cg==
</data>
<flag name="review"
          id="14401"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>30550</attachid>
            <date>2009-05-21 12:46:54 -0700</date>
            <delta_ts>2009-05-22 20:50:23 -0700</delta_ts>
            <desc>Recognize any text/* type #2</desc>
            <filename>canshowmime.diff</filename>
            <type>text/plain</type>
            <size>1698</size>
            <attacher name="Christian Dywan">christian</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
MTYyMWVlMi4uOTE2ZTA1YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNS0yMSAgQ2hyaXN0aWFuIER5
d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBUZXh0IGZpbGVzIHdoaWNoIGhhdmUgc3ViIE1JTUUgdHlw
ZXMgYXJlIHRyZWF0ZWQgYXMgbm90IGRpc3BsYXlhYmxlCisgICAgICAgIGh0dHA6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0OTAzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9NSU1F
VHlwZVJlZ2lzdHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVTdXBwb3J0ZWRO
b25JbWFnZU1pbWVUeXBlcyk6CisgICAgICAgIChXZWJDb3JlOjpNSU1FVHlwZVJlZ2lzdHJ5Ojpp
c1N1cHBvcnRlZE5vbkltYWdlTUlNRVR5cGUpOiBSZWdhcmQgYW55CisgICAgICAgIE1JTUUgdHlw
ZSBiZWdpbm5pbmcgd2l0aCAidGV4dC8iIGFzIHN1cHBvcnRlZCBhbmQgcmVtb3ZlIGFsbCAidGV4
dC8iCisgICAgICAgIHR5cGVzIGZyb20gdGhlIGxpc3QuCisKIDIwMDktMDUtMjEgIEVyaWMgU2Vp
ZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9z
a3VyeWFrb3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnku
Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcAppbmRleCBhYWZiMWM3
Li41MDU4NDgwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnku
Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAKQEAgLTE4OSwx
NCArMTg5LDggQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVN1cHBvcnRlZE5vbkltYWdlTWltZVR5
cGVzKCkKIHsKICAgICBzdGF0aWMgY29uc3QgY2hhciogdHlwZXNbXSA9IHsKICNpZiBFTkFCTEUo
V01MKQotICAgICAgICAidGV4dC92bmQud2FwLndtbCIsCiAgICAgICAgICJhcHBsaWNhdGlvbi92
bmQud2FwLndtbGMiLAogI2VuZGlmCi0gICAgICAgICJ0ZXh0L2h0bWwiLAotICAgICAgICAidGV4
dC94bWwiLAotICAgICAgICAidGV4dC94c2wiLAotICAgICAgICAidGV4dC9wbGFpbiIsCi0gICAg
ICAgICJ0ZXh0LyIsCiAgICAgICAgICJhcHBsaWNhdGlvbi94bWwiLAogICAgICAgICAiYXBwbGlj
YXRpb24veGh0bWwreG1sIiwKICNpZiBFTkFCTEUoWEhUTUxNUCkKQEAgLTI5MSw2ICsyODUsOCBA
QCBib29sIE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkTm9uSW1hZ2VNSU1FVHlwZShjb25z
dCBTdHJpbmcmIG1pbWVUeXBlKQogewogICAgIGlmIChtaW1lVHlwZS5pc0VtcHR5KCkpCiAgICAg
ICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAobWltZVR5cGUuc3RhcnRzV2l0aCgidGV4dC8iKSkK
KyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgaWYgKCFzdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBl
cykKICAgICAgICAgaW5pdGlhbGl6ZU1JTUVUeXBlUmVnaXN0cnkoKTsKICAgICByZXR1cm4gc3Vw
cG9ydGVkTm9uSW1hZ2VNSU1FVHlwZXMtPmNvbnRhaW5zKG1pbWVUeXBlKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>30556</attachid>
            <date>2009-05-21 14:27:31 -0700</date>
            <delta_ts>2010-06-10 17:44:39 -0700</delta_ts>
            <desc>Test for acceptance of text/* types</desc>
            <filename>Test-for-acceptance-of-text-types.patch</filename>
            <type>text/plain</type>
            <size>2374</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">ZjkyYjk4OTkxYzhkMDlkMzBkNWM2NWJhODc1NjA4MjIzM2MwMTkyZApkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQyYzE4MjIu
LjI5ZDM3OTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU
ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAwOS0wNS0yMSAgR3VzdGF2byBOb3Jv
bmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAorICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IHRoYXQgV2ViS2l0IGFj
Y2VwdHMgYW55IHRleHQvKiB0eXBlLgorCisgICAgICAgICogaHR0cC90ZXN0cy9taW1lL2FjY2Vw
dC1hbGwtdGV4dC10eXBlcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVz
dHMvbWltZS9hY2NlcHQtYWxsLXRleHQtdHlwZXMuaHRtbDogQWRkZWQuCisKKzIwMDktMDUtMjEg
IEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+
CisKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgogCiAgICAgICAgIERpc2FibGUgZmFp
bGluZyBIVFRQIHRlc3RzIG5vdyB0aGF0IHdlIGFyZSBlbmFibGluZyBIVFRQIG9uIHRoZQpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL2FjY2VwdC1hbGwtdGV4dC10eXBl
cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pbWUvYWNjZXB0LWFsbC10
ZXh0LXR5cGVzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw
Li43OTllN2UyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1l
L2FjY2VwdC1hbGwtdGV4dC10eXBlcy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitBTEVS
VDogUEFTUworQUxFUlQ6IFBBU1MKK0FMRVJUOiBQQVNTCisKZGlmZiAtLWdpdCBhL0xheW91dFRl
c3RzL2h0dHAvdGVzdHMvbWltZS9hY2NlcHQtYWxsLXRleHQtdHlwZXMuaHRtbCBiL0xheW91dFRl
c3RzL2h0dHAvdGVzdHMvbWltZS9hY2NlcHQtYWxsLXRleHQtdHlwZXMuaHRtbApuZXcgZmlsZSBt
b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42ZmNmN2E3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5
b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL2FjY2VwdC1hbGwtdGV4dC10eXBlcy5odG1sCkBAIC0w
LDAgKzEsMjcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzwvaGVhZD4KKzxi
b2R5PgorICA8c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsK
KyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIH0KKworICAg
IGZ1bmN0aW9uIHJlcG9ydFN1Y2Nlc3ModGV4dCkgeworICAgICAgICBpZiAodGV4dCA9PSAnUEFT
U1xuJykgeworICAgICAgICAgICAgYWxlcnQoJ1BBU1MnKTsKKyAgICAgICAgfSBlbHNlIHsKKyAg
ICAgICAgICAgIGFsZXJ0KCdGQUlMJyk7CisgICAgICAgIH0KKyAgICB9CisgIDwvc2NyaXB0Pgor
ICA8ZGl2IGlkPSJyZXN1bHQiLz4KKyAgPGZyYW1lc2V0IGNvbHM9IjQwMCwqIiByb3dzPSIqIiBp
ZD0ibWFpbkZyYW1lc2V0Ij4KKyAgICA8ZnJhbWUgbmFtZT0iZnJhbWVfMSIgaWQ9ImZyYW1lXzEi
IHNyYz0iZGF0YTp0ZXh0L2h0bWwsIFRlc3QgZm9yIDxhIGhyZWY9J2h0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDkwMycgdGFyZ2V0PSdfdG9wJz4gYnVnIDI0OTAzPC9h
PjogZXh0IGZpbGVzIHdoaWNoIGhhdmUgc3ViIE1JTUUgdHlwZXMgYXJlIHRyZWF0ZWQgYXMgbm90
IGRpc3BsYXlhYmxlPGJyLz4iIC8+CisgICAgPGZyYW1lIG5hbWU9InBsYWluIiBpZD0icGxhaW4i
IHNyYz0icmVzb3VyY2VzL2FjY2VwdC1hbGwtdGV4dC10eXBlcy5jZ2k/dHlwZT1wbGFpbiIgb25s
b2FkPSJqYXZhc2NyaXB0OnJlcG9ydFN1Y2Nlc3MocGxhaW4uZG9jdW1lbnQuYm9keS5pbm5lclRl
eHQpIiAvPgorICAgIDxmcmFtZSBzcmM9InJlc291cmNlcy9hY2NlcHQtYWxsLXRleHQtdHlwZXMu
Y2dpP3R5cGU9eC1wYXRjaCIgb25sb2FkPSJqYXZhc2NyaXB0OnJlcG9ydFN1Y2Nlc3MocGxhaW4u
ZG9jdW1lbnQuYm9keS5pbm5lclRleHQpIiAvPgorICAgIDxmcmFtZSBzcmM9InJlc291cmNlcy9h
Y2NlcHQtYWxsLXRleHQtdHlwZXMuY2dpP3R5cGU9eC1zb21ldGhpbmctYmxhYmxhIiBvbmxvYWQ9
ImphdmFzY3JpcHQ6cmVwb3J0U3VjY2VzcyhwbGFpbi5kb2N1bWVudC5ib2R5LmlubmVyVGV4dCki
IC8+CisgIDwvZnJhbWVzZXQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32143</attachid>
            <date>2009-07-01 14:39:59 -0700</date>
            <delta_ts>2009-07-01 14:39:59 -0700</delta_ts>
            <desc>Treat all text/ subtypes as supported</desc>
            <filename>Treat-all-text-subtypes-as-supported.patch</filename>
            <type>text/plain</type>
            <size>1622</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">Yzc1N2U3NTJhMjY2YjAyY2Q0Y2Q2YzVmYzdiZDBmZGEzMjkyMTRhMwpkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNGZkNzAzLi5jYjAyYjk5
IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDIyIEBACisyMDA5LTA3LTAxICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0
YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yNDkwMworICAgICAgICBUZXh0IGZpbGVzIHdoaWNoIGhhdmUgc3ViIE1JTUUgdHlwZXMg
YXJlIHRyZWF0ZWQgYXMgbm90IGRpc3BsYXlhYmxlCisKKyAgICAgICAgQmFzZWQgb24gdGhlIG9y
aWdpbmFsIHdvcmsgYnkgQ2hyaXN0aWFuIER5d2FuIDxjaHJpc3RpYW5AdHdvdG9hc3RzLmRlPi4K
KworICAgICAgICBUcmVhdCBldmVyeSB0ZXh0Lyogc3VidHlwZSBhcyBzdXBwb3J0ZWQuCisKKyAg
ICAgICAgSSBjYW4ndCB0aGluayBvZiBhIHdheSB0byB0ZXN0IHRoaXMuIE15IGZpcnN0IHRyeSB0
dXJuZWQgb3V0IHRvIGJlCisgICAgICAgIGZsYWt5LCBhbmQgcGFzc2VkIG9uIE1hYyBldmVuIHdp
dGhvdXQgdGhlIHBhdGNoLiBUaGUgZnVuY3Rpb25hbAorICAgICAgICBiZWhhdmlvciB0ZXN0YWJs
ZSBieSBsYXlvdXQgdGVzdHMgZGVwZW5kcyBoaWdobHkgb24gaG93IHRoZQorICAgICAgICBwbGF0
Zm9ybSBoYW5kbGVzLCBmb3IgaW5zdGFuY2UgY29udGVudCBzbmlmZmluZy4KKworICAgICAgICAq
IHBsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TUlNRVR5
cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlKToKKwogMjAwOS0wNy0wMSAg
Tmlrb2xhcyBaaW1tZXJtYW5uICA8bmlrb2xhcy56aW1tZXJtYW5uQHRvcmNobW9iaWxlLmNvbT4K
IAogICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KZGlmZiAtLWdpdCBhL1dlYkNv
cmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL01JTUVU
eXBlUmVnaXN0cnkuY3BwCmluZGV4IDkyM2RkOGMuLjEwMjM5MjUgMTAwNjQ0Ci0tLSBhL1dlYkNv
cmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9N
SU1FVHlwZVJlZ2lzdHJ5LmNwcApAQCAtMzg5LDYgKzM4OSw4IEBAIGJvb2wgTUlNRVR5cGVSZWdp
c3RyeTo6aXNTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUp
CiB7CiAgICAgaWYgKG1pbWVUeXBlLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwor
ICAgIGlmIChtaW1lVHlwZS5zdGFydHNXaXRoKCJ0ZXh0LyIpKQorICAgICAgICByZXR1cm4gdHJ1
ZTsKICAgICBpZiAoIXN1cHBvcnRlZE5vbkltYWdlTUlNRVR5cGVzKQogICAgICAgICBpbml0aWFs
aXplTUlNRVR5cGVSZWdpc3RyeSgpOwogICAgIHJldHVybiBzdXBwb3J0ZWROb25JbWFnZU1JTUVU
eXBlcy0+Y29udGFpbnMobWltZVR5cGUpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>