24884 2009-03-27 06:56:33 -0700 Include strings.h for strcasecmp() 2009-07-07 20:57:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 27065 0 laszlo.gombos webkit-unassigned carol hausmann oldest_to_newest 115537 0 laszlo.gombos 2009-03-27 06:56:33 -0700 IEEE Std 1003.1-2001 placed strcasecmp() in strings.h. Most (but not all) platforms also declare strcasecmp in string.h, so the lack of the strings.h include usually does not get noticed. The compile time problem I run into is http://trac.webkit.org/browser/trunk/WebCore/loader/TextResourceDecoder.cpp calls strcasecmp() but strings.h is not included. A similar case has been reported an solved in http://trac.webkit.org/changeset/38176/trunk/JavaScriptCore/runtime/DateMath.cpp. There are at least two options to consider - (a) continue including strings.h in each cpp where strcasecmp() is called or (b) include strings.h in StringExtras.h where strcasecmp() is implemented for Win. I feel that (b) might be a more future-proof (since Win ports are well maintained). Patch follows. 115538 1 29009 laszlo.gombos 2009-03-27 07:04:39 -0700 Created attachment 29009 Include strings.h in StringExtras.h if available 115542 2 29009 darin 2009-03-27 07:19:22 -0700 Comment on attachment 29009 Include strings.h in StringExtras.h if available r=me 115555 3 hausmann 2009-03-27 09:23:15 -0700 Landed in r42037 29009 2009-03-27 07:04:39 -0700 2009-03-27 07:19:22 -0700 Include strings.h in StringExtras.h if available patch_24884.txt text/plain 1467 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQyMDMyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMjcgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyNDg4NDogSW5jbHVkZSBzdHJpbmdzLmgg Zm9yIHN0cmNhc2VjbXAoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjQ4ODQKKworICAgICAgICAqIHJ1bnRpbWUvRGF0ZU1hdGguY3BwOiBSZXZlcnNl ZCBwcmV2aW91cyBjaGFuZ2UgaW5jbHVkaW5nIHN0cmluZ3MuaAorICAgICAgICAqIHd0Zi9TdHJp bmdFeHRyYXMuaDogSW5jbHVkZSBzdHJpbmdzLmggaGVyZSBpcyBhdmFpbGFibGUKKwogMjAwOS0w My0yNiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ29weSB0ZXN0 YXBpLmpzIHRvICRXZWJLaXRPdXRwdXREaXIgb24gV2luZG93cwpJbmRleDogSmF2YVNjcmlwdENv cmUvcnVudGltZS9EYXRlTWF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVu dGltZS9EYXRlTWF0aC5jcHAJKHJldmlzaW9uIDQyMDMyKQorKysgSmF2YVNjcmlwdENvcmUvcnVu dGltZS9EYXRlTWF0aC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4LDEwICs2OCw2IEBACiAjaW5j bHVkZSA8c3lzL3RpbWViLmg+CiAjZW5kaWYKIAotI2lmIEhBVkUoU1RSSU5HU19IKQotI2luY2x1 ZGUgPHN0cmluZ3MuaD4KLSNlbmRpZgotCiB1c2luZyBuYW1lc3BhY2UgV1RGOwogCiBuYW1lc3Bh Y2UgSlNDIHsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9TdHJpbmdFeHRyYXMuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvU3RyaW5nRXh0cmFzLmgJKHJldmlzaW9uIDQyMDMy KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0V4dHJhcy5oCSh3b3JraW5nIGNvcHkpCkBA IC0yOSw2ICsyOSwxMCBAQAogI2luY2x1ZGUgPHN0ZGFyZy5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+ CiAKKyNpZiBIQVZFKFNUUklOR1NfSCkgCisjaW5jbHVkZSA8c3RyaW5ncy5oPiAKKyNlbmRpZiAK KwogI2lmIENPTVBJTEVSKE1TVkMpCiAKIGlubGluZSBpbnQgc25wcmludGYoY2hhciogYnVmZmVy LCBzaXplX3QgY291bnQsIGNvbnN0IGNoYXIqIGZvcm1hdCwgLi4uKSAK