<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24841</bug_id>
          
          <creation_ts>2009-03-26 07:48:24 -0700</creation_ts>
          <short_desc>Fix linking against QtWebKit for RVCT and Symbian</short_desc>
          <delta_ts>2009-07-07 20:57:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>S60 3rd edition</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>27065</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>hausmann</cc>
    
    <cc>norbert.leser</cc>
    
    <cc>yael</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>115324</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-03-26 07:48:24 -0700</bug_when>
    <thetext>Fix linking against QtWebKit for RVCT and Nokia/Symbian x86 compiler (Carbide) by fixing the EXPORT macros.

RVCT and Nokia/Symbian x86 compiler expect similar syntax for marking symbols to be exported as MSVC on WIN.

Patch proposal will follow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115327</commentid>
    <comment_count>1</comment_count>
      <attachid>28968</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-03-26 07:54:41 -0700</bug_when>
    <thetext>Created attachment 28968
Fix linking against QtWebKit for RVCT and Symbian

Thanks for Norbert Leser  &lt;norbert.leser@nokia.com&gt; for help.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115951</commentid>
    <comment_count>2</comment_count>
      <attachid>29103</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-03-30 18:11:10 -0700</bug_when>
    <thetext>Created attachment 29103
Revised patch based on feedback received !

Instead of white-listing Windows and other platforms, remove the test entirely and apply it to all platforms supported by Qt.

Thanks for Kristian Amlie, Norbert Leser and Simon Hausmann for help/feedback !</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>117510</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-04-14 13:15:34 -0700</bug_when>
    <thetext>Thanks Laszlo, landed in r42515</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28968</attachid>
            <date>2009-03-26 07:54:41 -0700</date>
            <delta_ts>2009-03-30 18:11:10 -0700</delta_ts>
            <desc>Fix linking against QtWebKit for RVCT and Symbian</desc>
            <filename>patch_24841.txt</filename>
            <type>text/plain</type>
            <size>1095</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNDIwMDMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDMtMjYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u
MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDg0
MQorCisgICAgICAgIEZpeCBsaW5raW5nIGFnYWluc3QgUXRXZWJLaXQgZm9yIFJWQ1QgYW5kIAor
ICAgICAgICBOb2tpYS9TeW1iaWFuIHg4NiBjb21waWxlciAoQ2FyYmlkZSkgYnkgZml4aW5nIHRo
ZSBFWFBPUlQgbWFjcm9zLgorCisgICAgICAgIFRoYW5rcyBmb3IgTm9yYmVydCBMZXNlciAgPG5v
cmJlcnQubGVzZXJAbm9raWEuY29tPiBmb3IgaGVscCBvbiB0aGlzIQorCisgICAgICAgICogQXBp
L3F3ZWJraXRnbG9iYWwuaDoKKwogMjAwOS0wMy0yMCAgRXJpayBMLiBCdW5jZSAgPGVsYnVuY2VA
eGVuZG9tLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6
IFdlYktpdC9xdC9BcGkvcXdlYmtpdGdsb2JhbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9B
cGkvcXdlYmtpdGdsb2JhbC5oCShyZXZpc2lvbiA0MjAwMSkKKysrIFdlYktpdC9xdC9BcGkvcXdl
YmtpdGdsb2JhbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMiw3ICsyMiw3IEBACiAKICNpbmNsdWRl
IDxRdENvcmUvcWdsb2JhbC5oPgogCi0jaWYgZGVmaW5lZChRX09TX1dJTikKKyNpZiBkZWZpbmVk
KFFfT1NfV0lOKSB8fCBkZWZpbmVkKFFfQ0NfUlZDVCkgfHwgZGVmaW5lZChRX0NDX05PS0lBWDg2
KQogIyAgaWYgZGVmaW5lZChRVF9OT0RMTCkKICMgICAgdW5kZWYgUVRfTUFLRURMTAogIyAgICB1
bmRlZiBRVF9ETEwK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>29103</attachid>
            <date>2009-03-30 18:11:10 -0700</date>
            <delta_ts>2009-04-14 13:14:52 -0700</delta_ts>
            <desc>Revised patch based on feedback received !</desc>
            <filename>patch_24841_v2.txt</filename>
            <type>text/plain</type>
            <size>1724</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNDIxMjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMzAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u
MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDg0
MQorCisgICAgICAgIEZpeCBsaW5raW5nIGFnYWluc3QgUXRXZWJLaXQgZm9yIFN5bWJpYW4gYW5k
IG90aGVyIHBsYXRmb3JtcworICAgICAgICB3aGVyZSB0aGUgT1MgQUJJIGRpc3Rpbmd1aXNoZXMg
YmV0d2VlbiBhbiBpbXBvcnQgb3IgYW4gZXhwb3J0IHNpdHVhdGlvbi4KKworICAgICAgICAqIEFw
aS9xd2Via2l0Z2xvYmFsLmg6IEluc3RlYWQgb2Ygd2hpdGUtbGlzdGluZyBXaW4sIHJlbW92ZSB0
aGUgdGVzdC4KKwogMjAwOS0wMy0zMCAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBu
b2tpYS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgVG9yIEFybmUgVmVzdGLDuC4K
SW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYmtpdGdsb2JhbC5oCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp
dC9xdC9BcGkvcXdlYmtpdGdsb2JhbC5oCShyZXZpc2lvbiA0MjA1NCkKKysrIFdlYktpdC9xdC9B
cGkvcXdlYmtpdGdsb2JhbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMiwyMiArMjIsMTQgQEAKIAog
I2luY2x1ZGUgPFF0Q29yZS9xZ2xvYmFsLmg+CiAKLSNpZiBkZWZpbmVkKFFfT1NfV0lOKQotIyAg
aWYgZGVmaW5lZChRVF9OT0RMTCkKLSMgICAgdW5kZWYgUVRfTUFLRURMTAotIyAgICB1bmRlZiBR
VF9ETEwKLSMgIGVsaWYgZGVmaW5lZChRVF9NQUtFRExMKSAgICAgICAgLyogY3JlYXRlIGEgUXQg
RExMIGxpYnJhcnkgKi8KLSMgICAgaWYgZGVmaW5lZChRVF9ETEwpCi0jICAgICAgdW5kZWYgUVRf
RExMCi0jICAgIGVuZGlmCi0jICAgIGlmIGRlZmluZWQoQlVJTERfV0VCS0lUKQotIyAgICAgICAg
ZGVmaW5lIFFXRUJLSVRfRVhQT1JUIFFfREVDTF9FWFBPUlQKLSMgICAgZWxzZQotIyAgICAgICAg
ZGVmaW5lIFFXRUJLSVRfRVhQT1JUIFFfREVDTF9JTVBPUlQKLSMgICAgZW5kaWYKLSMgIGVsaWYg
ZGVmaW5lZChRVF9ETEwpIC8qIHVzZSBhIFF0IERMTCBsaWJyYXJ5ICovCi0jICAgIGRlZmluZSBR
V0VCS0lUX0VYUE9SVCBRX0RFQ0xfSU1QT1JUCisjaWYgZGVmaW5lZChRVF9NQUtFRExMKSAgICAg
ICAgLyogY3JlYXRlIGEgUXQgRExMIGxpYnJhcnkgKi8KKyMgIGlmIGRlZmluZWQoQlVJTERfV0VC
S0lUKQorIyAgICAgIGRlZmluZSBRV0VCS0lUX0VYUE9SVCBRX0RFQ0xfRVhQT1JUCisjICBlbHNl
CisjICAgICAgZGVmaW5lIFFXRUJLSVRfRVhQT1JUIFFfREVDTF9JTVBPUlQKICMgIGVuZGlmCisj
ZWxpZiBkZWZpbmVkKFFUX0RMTCkgLyogdXNlIGEgUXQgRExMIGxpYnJhcnkgKi8KKyMgIGRlZmlu
ZSBRV0VCS0lUX0VYUE9SVCBRX0RFQ0xfSU1QT1JUCiAjZW5kaWYKIAogI2lmICFkZWZpbmVkKFFX
RUJLSVRfRVhQT1JUKQo=
</data>
<flag name="review"
          id="14418"
          type_id="1"
          status="+"
          setter="hausmann"
    />
          </attachment>
      

    </bug>

</bugzilla>