248040 2022-11-17 08:42:02 -0800 Smarter EWS Checks for Websites directory 2022-11-24 08:42:15 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified NEW InRadar P2 Normal --- 248037 1 ahmad.saleem792 webkit-unassigned aakash_jain ap webkit-bug-importer oldest_to_newest 1913187 0 ahmad.saleem792 2022-11-17 08:42:02 -0800 Hi Team, I am raising another bug around "Websites" folder on GitHub Webkit directory, which also go through whole EWS checklist while it does not have directly any "WebCore" or "JSC" code and I don't think it needs to run all LayoutTests etc. (but again I can be wrong and there might be some rationale behind it) but I think we can be smarter and think of other ways on what tests to run etc. - Evaluate on which integration / layout tests or other tests are relevant (If only enabled selectively - the EWS resources can be reused for other stuff) PR as example - https://github.com/WebKit/WebKit/pull/6580 Doing all EWS LayoutTests (e.g., https://ews-build.webkit.org/#/builders/35/builds/31662) Appreciate if something can discussed for following. Thanks! 1913357 1 ap 2022-11-17 19:39:43 -0800 The benefit is fairly small, as website changes are rare, but we should skip building/testing for these indeed. Aakash, could you please advise where the paths for EWS to skip are in our code? I cannot find those any more. 1913358 2 ap 2022-11-17 19:40:19 -0800 Ah, CheckChangeRelevance in `Tools/CISupport/ews-build/steps.py looking at bug 248039 1914501 3 webkit-bug-importer 2022-11-24 08:42:15 -0800 <rdar://problem/102649320>