248018 2022-11-16 20:51:54 -0800 REGRESSION(256180@main): Enabling accelerated drawing caused some ImageOnly Failures 2023-02-02 09:28:57 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=246285 InRadar P2 Normal --- 1 jenner jbedard nmouchtaris simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1913065 0 jenner 2022-11-16 20:51:54 -0800 It looks like enabling accelerated drawing at 256180@main caused the following 15 tests to have constant ImageOnly Failures: compositing/geometry/css-clip-oversize.html compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position.html compositing/scrolling/async-overflow-scrolling/border-radius-on-scroll-container.html css3/blending/background-blend-mode-data-uri-svg-image.html fast/borders/border-painting-inset.html fast/borders/border-painting-outset.html fast/borders/hidpi-border-painting-groove.html fast/borders/hidpi-border-painting-ridge.html fast/borders/wrong-border-color-when-radius-is-present.html fast/box-shadow/inset-shadow-split-inline.html fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html imported/blink/fast/sub-pixel/sub-pixel-transparency-layer.html imported/mozilla/svg/path-02.svg imported/w3c/web-platform-tests/css/css-transforms/transforms-skewY.html imported/w3c/web-platform-tests/svg/extensibility/foreignObject/masked.html HISTORY: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=compositing%2Fgeometry%2Fcss-clip-oversize.html&test=compositing%2Fhidpi-compositing-layer-with-tile-layers-on-subpixel-position.html&test=compositing%2Fscrolling%2Fasync-overflow-scrolling%2Fborder-radius-on-scroll-container.html&test=css3%2Fblending%2Fbackground-blend-mode-data-uri-svg-image.html&test=fast%2Fborders%2Fborder-painting-inset.html&test=fast%2Fborders%2Fborder-painting-outset.html&test=fast%2Fborders%2Fhidpi-border-painting-groove.html&test=fast%2Fborders%2Fhidpi-border-painting-ridge.html&test=fast%2Fborders%2Fwrong-border-color-when-radius-is-present.html&test=fast%2Fbox-shadow%2Finset-shadow-split-inline.html&test=fast%2Flayers%2Fparent-clipping-overflow-is-overwritten-by-child-clipping.html&test=imported%2Fblink%2Ffast%2Fsub-pixel%2Fsub-pixel-transparency-layer.html&test=imported%2Fmozilla%2Fsvg%2Fpath-02.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Ftransforms-skewY.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fextensibility%2FforeignObject%2Fmasked.html URL TO RESULTS PAGE: https://build.webkit.org/results/Apple-Ventura-Debug-AppleSilicon-WK2-Tests/256760@main%20(175)/results.html 1913066 1 webkit-bug-importer 2022-11-16 20:52:52 -0800 <rdar://problem/102449694> 1913067 2 jenner 2022-11-16 20:54:58 -0800 The ImageDiff for all of these tests appear to only be off by .01%. Still, I was able to reproduce them all at Ventura Debug ToT running the test as follows: run-webkit-tests <insert test name here> I also was able to determine that the regression point where these failures were introduced is 256180@main. The failures did not reproduce at 256179@main 1913068 3 jenner 2022-11-16 20:57:53 -0800 Starting on Nikos who introduced https://commits.webkit.org/256180@main that caused these ImageOnlyFailures. 1913254 4 jenner 2022-11-17 12:04:40 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6598 1913512 5 ews-feeder 2022-11-18 11:44:00 -0800 Committed 256844@main (6409da485414): <https://commits.webkit.org/256844@main> Reviewed commits have been landed. Closing PR #6598 and removing active labels. 1915086 6 jenner 2022-11-28 13:18:39 -0800 Re-opening for pull request https://github.com/WebKit/WebKit/pull/6877 1915088 7 jenner 2022-11-28 13:20:14 -0800 (In reply to Robert Jenner from comment #6) > Re-opening for pull request https://github.com/WebKit/WebKit/pull/6877 There was an additional fix needed for: compositing/geometry/css-clip-oversize.html fast/borders/border-painting-inset.html fast/borders/border-painting-outset.html fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html So I have submitted a PR for them above. 1915528 8 ews-feeder 2022-11-29 22:43:27 -0800 Committed 257168@main (543c335f8661): <https://commits.webkit.org/257168@main> Reviewed commits have been landed. Closing PR #6877 and removing active labels. 1915529 9 jenner 2022-11-29 22:52:52 -0800 Re-opening for pull request https://github.com/WebKit/WebKit/pull/6959 1915850 10 ews-feeder 2022-12-01 00:05:35 -0800 Committed 257224@main (4ef04177be59): <https://commits.webkit.org/257224@main> Reviewed commits have been landed. Closing PR #6959 and removing active labels. 1916268 11 jenner 2022-12-02 11:37:25 -0800 svg/gradients/spreadMethodAlpha.svg svg/custom/hidpi-masking-clipping.svg svg/compositing/outermost-svg-with-border-padding.html Look like they all need tolerance adjustments. 1929104 12 ews-feeder 2023-01-27 17:41:51 -0800 Test gardening commit 259518@main (bb5fff6456b0): <https://commits.webkit.org/259518@main> Reviewed commits have been landed. Closing PR #9266 and removing active labels. 1929870 13 ews-feeder 2023-01-31 14:15:22 -0800 Test gardening commit 259646@main (ee8e4757570e): <https://commits.webkit.org/259646@main> Reviewed commits have been landed. Closing PR #9407 and removing active labels. 1930506 14 jbedard 2023-02-02 09:13:18 -0800 Re-opening for pull request https://github.com/apple/WebKit/pull/346 1930513 15 ews-feeder 2023-02-02 09:28:57 -0800 Test gardening commit 259548.37@safari-7615-branch (a96eb9fd3417): <https://commits.webkit.org/259548.37@safari-7615-branch> Reviewed commits have been landed. Closing PR #346 and removing active labels.