247734 2022-11-10 07:54:19 -0800 cssText serializes shorthand with var() even if some longhand is different 2022-11-11 10:29:35 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 247741 1 obrufau obrufau webkit-bug-importer oldest_to_newest 1911534 0 obrufau 2022-11-10 07:54:19 -0800 Run this: document.body.style.cssText = "margin: var(--m); margin-top: 1px"; document.body.style.cssText; Expected: "margin-right: ; margin-bottom: ; margin-left: ; margin-top: 1px;" Actual: "margin: var(--m);" The problem is that StyleProperties::asTextInternal() sees that margin-right is set to a pending-substitution value for margin:var(--m), and then https://searchfox.org/wubkat/rev/7a292520f6b12e8d4d9001d1480474b5c83cb0f8/Source/WebCore/css/StyleProperties.cpp#1795 sets value to "var(--m)". value = substitutionValue.shorthandValue().cssText(); The value should instead be obtained in https://searchfox.org/wubkat/rev/7a292520f6b12e8d4d9001d1480474b5c83cb0f8/Source/WebCore/css/StyleProperties.cpp#1823 value = getPropertyValue(shorthandPropertyID); which will properly detect that "var(--m)" is not a proper serialization. 1911609 1 obrufau 2022-11-10 11:49:08 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6356 1911751 2 ews-feeder 2022-11-10 23:45:29 -0800 Committed 256564@main (b7eeaa128fab): <https://commits.webkit.org/256564@main> Reviewed commits have been landed. Closing PR #6356 and removing active labels. 1911752 3 webkit-bug-importer 2022-11-10 23:46:19 -0800 <rdar://problem/102229765>