247274 2022-10-31 11:32:53 -0700 We need git-webkit apply-pr and apply-from-bug 2023-04-20 08:52:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 239082 1 rniwa webkit-unassigned ap jbedard webkit-bug-importer oldest_to_newest 1909363 0 rniwa 2022-10-31 11:32:53 -0700 webkit-patch has apply-attachment and apply-from-bug to apply patches posted on Bugzilla. We need an equivalent command for applying PR and/or PR associated with the bug. 1909367 1 rniwa 2022-10-31 11:51:16 -0700 Note that one of important use cases is to apply PR written by someone else. 1909368 2 ap 2022-10-31 11:55:17 -0700 Arguably more important than it was in webkit-patch, because downloading a diff file from GitHub is an undiscoverable action. 1909369 3 rniwa 2022-10-31 11:57:15 -0700 (In reply to Alexey Proskuryakov from comment #2) > Arguably more important than it was in webkit-patch, because downloading a > diff file from GitHub is an undiscoverable action. Yeah, we used to able to download the diff on Bugzilla and apply that locally. Can't do that anymore either. 1909398 4 ap 2022-10-31 13:27:46 -0700 I should have explained how this undiscoverable action works. Adding .diff or .patch to a PR or commit link (like https://github.com/WebKit/WebKit/pull/5969.diff) produces downloadable diffs, either "git diff" or "git patch" style. 1910821 5 webkit-bug-importer 2022-11-07 10:33:18 -0800 <rdar://problem/102048463> 1950086 6 jbedard 2023-04-20 08:52:46 -0700 `git-webkit checkout pr-#` exists, and is designed to solve this problem. If we wanted to expand this to bugs, we're basically resolving the pointer to the PR, then checking out the PR.