247239 2022-10-29 21:51:09 -0700 [Live Range Selection] Expanding selection by granularity should expand anchor & focus 2022-11-23 01:52:19 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218020 InRadar P2 Normal --- 216325 1 rniwa rniwa darin ews-watchlist megan_gardner mifenton webkit-bug-importer wenson_hsieh oldest_to_newest 1909197 0 rniwa 2022-10-29 21:51:09 -0700 When expanding selection by non-character granularity, it should also affect anchor & focus. 1909198 1 463307 rniwa 2022-10-29 21:57:18 -0700 Created attachment 463307 WIP 1909199 2 rniwa 2022-10-29 22:06:23 -0700 The last test case in editing/selection/shift-click.html fails with this change. Need to look into that next week. 1909200 3 webkit-bug-importer 2022-10-29 22:06:45 -0700 <rdar://problem/101722271> 1909242 4 463307 rniwa 2022-10-30 12:35:50 -0700 Comment on attachment 463307 WIP Oh, this is interesting. The test failure goes away if I restore the old code in VisibleSelection::validate instead of new code in VisibleSelection::expandUsingGranularity. 1909243 5 rniwa 2022-10-30 14:22:24 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5945 1909456 6 ews-feeder 2022-10-31 16:40:12 -0700 Committed 256174@main (ca201a717c24): <https://commits.webkit.org/256174@main> Reviewed commits have been landed. Closing PR #5945 and removing active labels. 463307 2022-10-29 21:57:18 -0700 2022-10-29 23:35:55 -0700 WIP wip247239.patch text/plain 3140 rniwa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVNlbGVjdGlvbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVTZWxlY3Rpb24uY3BwCmluZGV4IDUxYzk5 Njk5Zjg0ZC4uYjcyMDM1M2ZhYmVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L1Zpc2libGVTZWxlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJs ZVNlbGVjdGlvbi5jcHAKQEAgLTIxOSw2ICsyMTksMTQgQEAgYm9vbCBWaXNpYmxlU2VsZWN0aW9u OjpleHBhbmRVc2luZ0dyYW51bGFyaXR5KFRleHRHcmFudWxhcml0eSBncmFudWxhcml0eSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgdmFsaWRhdGUoZ3JhbnVsYXJpdHkpOworICAgIGlm IChtX2FuY2hvcklzRmlyc3QpIHsKKyAgICAgICAgbV9hbmNob3IgPSBtX3N0YXJ0OworICAgICAg ICBtX2ZvY3VzID0gbV9lbmQ7CisgICAgfSBlbHNlIHsKKyAgICAgICAgbV9mb2N1cyA9IG1fc3Rh cnQ7CisgICAgICAgIG1fYW5jaG9yID0gbV9lbmQ7CisgICAgfQorCiAgICAgcmV0dXJuIHRydWU7 CiB9CiAKQEAgLTQxOCw5ICs0MjYsNiBAQCB2b2lkIFZpc2libGVTZWxlY3Rpb246OnZhbGlkYXRl KFRleHRHcmFudWxhcml0eSBncmFudWxhcml0eSkKICAgICBhZGp1c3RTZWxlY3Rpb25Ub0F2b2lk Q3Jvc3NpbmdFZGl0aW5nQm91bmRhcmllcygpOwogICAgIHVwZGF0ZVNlbGVjdGlvblR5cGUoKTsK IAotICAgIGJvb2wgc2hvdWxkVXBkYXRlQW5jaG9yID0gZmFsc2U7IC8vIFNldCB0byBmYWxzZSBi ZWNhdXNlIG9mIDxyZGFyOi8vcHJvYmxlbS82OTU0MjQ1OT4uIENhbiBiZSByZXR1cm5lZCB0byBv cmlnaW5hbCBsb2dpYyB3aGVuIHRoaXMgcHJvYmxlbSBpcyBmdWxseSBmaXhlZC4KLSAgICBib29s IHNob3VsZFVwZGF0ZUZvY3VzID0gZmFsc2U7IC8vIERpdHRvLgotCiAgICAgaWYgKGlzUmFuZ2Uo KSkgewogICAgICAgICAvLyAiQ29uc3RyYWluIiB0aGUgc2VsZWN0aW9uIHRvIGJlIHRoZSBzbWFs bGVzdCBlcXVpdmFsZW50IHJhbmdlIG9mIG5vZGVzLgogICAgICAgICAvLyBUaGlzIGlzIGEgc29t ZXdoYXQgYXJiaXRyYXJ5IGNob2ljZSwgYnV0IGV4cGVyaWVuY2Ugc2hvd3MgdGhhdCBpdCBpcwpA QCAtNDM5LDE1ICs0NDQsNiBAQCB2b2lkIFZpc2libGVTZWxlY3Rpb246OnZhbGlkYXRlKFRleHRH cmFudWxhcml0eSBncmFudWxhcml0eSkKICAgICAgICAgLy8gU2VlIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzQ2My4KICAgICAgICAgYWRqdXN0U2VsZWN0aW9uVG9B dm9pZENyb3NzaW5nRWRpdGluZ0JvdW5kYXJpZXMoKTsKICAgICB9Ci0KLSAgICBpZiAoc2hvdWxk VXBkYXRlQW5jaG9yKSB7Ci0gICAgICAgIG1fYW5jaG9yID0gbV9hbmNob3JJc0ZpcnN0ID8gbV9z dGFydCA6IG1fZW5kOwotICAgICAgICBtX2Jhc2UgPSBtX2FuY2hvcjsKLSAgICB9Ci0gICAgaWYg KHNob3VsZFVwZGF0ZUZvY3VzKSB7Ci0gICAgICAgIG1fZm9jdXMgPSBtX2FuY2hvcklzRmlyc3Qg PyBtX2VuZCA6IG1fc3RhcnQ7Ci0gICAgICAgIG1fZXh0ZW50ID0gbV9mb2N1czsKLSAgICB9CiB9 CiAKIC8vIEJlY2F1c2Ugd2UgdXNlIFZpc2libGVTZWxlY3Rpb24gdG8gc3RvcmUgdmFsdWVzIGlu IGVkaXRpbmcgY29tbWFuZHMgZm9yIHVzZSB3aGVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAKaW5kZXggMTY0MTA1MTk0MDBkLi44ZmZmNmU2YjFlZDUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0V2ZW50SGFuZGxlci5jcHAKQEAgLTEwMTcsOSArMTAxNywxOSBAQCB2b2lkIEV2ZW50SGFuZGxl cjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhpdFRl c3RSZXN1bAogICAgICAgICAgICAgbmV3U2VsZWN0aW9uLnNldEV4dGVudCh0YXJnZXRQb3NpdGlv bik7CiAgICAgfQogCi0gICAgaWYgKG1fZnJhbWUuc2VsZWN0aW9uKCkuZ3JhbnVsYXJpdHkoKSAh PSBUZXh0R3JhbnVsYXJpdHk6OkNoYXJhY3RlckdyYW51bGFyaXR5KQorICAgIGlmIChtX2ZyYW1l LnNlbGVjdGlvbigpLmdyYW51bGFyaXR5KCkgIT0gVGV4dEdyYW51bGFyaXR5OjpDaGFyYWN0ZXJH cmFudWxhcml0eSkgewogICAgICAgICBuZXdTZWxlY3Rpb24uZXhwYW5kVXNpbmdHcmFudWxhcml0 eShtX2ZyYW1lLnNlbGVjdGlvbigpLmdyYW51bGFyaXR5KCkpOwogCisgICAgICAgIGF1dG8gZHJh Z1N0YXJ0UG9zaXRpb24gPSBtX21vdXNlUHJlc3NOb2RlLT5yZW5kZXJlcigpLT5wb3NpdGlvbkZv clBvaW50KG1fZHJhZ1N0YXJ0UG9zaXRpb24sIG51bGxwdHIpOworICAgICAgICBWaXNpYmxlU2Vs ZWN0aW9uIGRyYWdTdGFydFNlbGVjdGlvbiA9IGRyYWdTdGFydFBvc2l0aW9uOworICAgICAgICBk cmFnU3RhcnRTZWxlY3Rpb24uZXhwYW5kVXNpbmdHcmFudWxhcml0eShtX2ZyYW1lLnNlbGVjdGlv bigpLmdyYW51bGFyaXR5KCkpOworCisgICAgICAgIGlmICghbmV3U2VsZWN0aW9uLmlzQmFzZUZp cnN0KCkgJiYgIW9sZFNlbGVjdGlvbi5pc0Jhc2VGaXJzdCgpICYmIG9sZFNlbGVjdGlvbi5lbmQo KSA8IG5ld1NlbGVjdGlvbi5lbmQoKSkKKyAgICAgICAgICAgIG5ld1NlbGVjdGlvbi5zZXRCYXNl KGRyYWdTdGFydFNlbGVjdGlvbi5lbmQoKSk7CisgICAgICAgIGVsc2UgaWYgKG5ld1NlbGVjdGlv bi5pc0Jhc2VGaXJzdCgpICYmICFvbGRTZWxlY3Rpb24uaXNCYXNlRmlyc3QoKSAmJiBvbGRTZWxl Y3Rpb24uc3RhcnQoKSA8IG5ld1NlbGVjdGlvbi5zdGFydCgpKQorICAgICAgICAgICAgbmV3U2Vs ZWN0aW9uLnNldEJhc2UoZHJhZ1N0YXJ0U2VsZWN0aW9uLnN0YXJ0KCkpOworICAgIH0KKwogICAg IG1fZnJhbWUuc2VsZWN0aW9uKCkuc2V0U2VsZWN0aW9uQnlNb3VzZUlmRGlmZmVyZW50KG5ld1Nl bGVjdGlvbiwgbV9mcmFtZS5zZWxlY3Rpb24oKS5ncmFudWxhcml0eSgpLAogICAgICAgICBGcmFt ZVNlbGVjdGlvbjo6RW5kUG9pbnRzQWRqdXN0bWVudE1vZGU6OkFkanVzdEF0QmlkaUJvdW5kYXJ5 KTsKIAo=