247005 2022-10-25 08:05:22 -0700 ASSERTION FAILED: !image->size().isEmpty() when setting zoom 2023-02-27 14:13:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=206897 https://bugs.webkit.org/show_bug.cgi?id=206579 https://bugs.webkit.org/show_bug.cgi?id=244580 InRadar P2 Normal --- 1 fred.wang webkit-unassigned bfulgham dino ews-watchlist fmalita gyuyoung.kim pdr rbuis sabouhallawa schenney sergio simon.fraser webkit-bug-importer zalan zimmermann oldest_to_newest 1908081 0 463215 fred.wang 2022-10-25 08:05:22 -0700 Created attachment 463215 Minimized testcase See attached testcase, originally from bug comment 8. This is the same assertion as bug 206897 and bug 206579, but the repro case seems slightly different, so opening just in case. Reproduced at https://commits.webkit.org/255418@main with macos/gtk debug builds. 1909557 1 webkit-bug-importer 2022-11-01 08:06:18 -0700 <rdar://problem/101806737> 1914965 2 463759 rbuis 2022-11-28 07:07:07 -0800 Created attachment 463759 Patch 1919926 3 463759 zimmermann 2022-12-16 07:32:51 -0800 Comment on attachment 463759 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463759&action=review > Source/WebCore/svg/graphics/SVGImageCache.cpp:60 > + if (containerSizeWithoutZoom.width() >= 1.f && containerSizeWithoutZoom.height() >= 1.f) Hmm, But a containerSizeWihtoutZoom of 0.1 is fine, no? (with a zoom factor of e.g. 10). I'm slightly confused -- I would have expected to judge if we should cache or not, based on the zoom factor? If it changes, we're going to redraw the SVGImage anyhow, right? 463215 2022-10-25 08:05:22 -0700 2022-10-25 08:05:22 -0700 Minimized testcase bug244580-assertion-not-image-size-is-empty.html text/html 315 fred.wang PCFET0NUWVBFIGh0bWw+CjxkaXYgaWQ9ImNvbnRhaW5lcjEiPgogIDxkaXYgaWQ9ImNvbnRhaW5l cjIiPgogICAgPGltZyBzcmM9ImRhdGE6aW1hZ2Uvc3ZnK3htbCw8c3ZnIHhtbG5zPSZxdW90O2h0 dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnJnF1b3Q7IHdpZHRoPSZxdW90OzEmcXVvdDsgaGVpZ2h0 PSZxdW90OzEmcXVvdDs+PC9zdmc+Ij4KICA8L2Rpdj4KPC9kaXY+CjxzY3JpcHQ+CiAgY29udGFp bmVyMi5zdHlsZS5hbGwgPSAnaW5oZXJpdCc7CiAgY29udGFpbmVyMS5zdHlsZS56b29tID0gNTA4 MjA0MTI1MjQ4NDA0ODUwMDAwOwo8L3NjcmlwdD4K 463759 2022-11-28 07:07:07 -0800 2022-11-28 07:07:07 -0800 Patch bug-247005-20221128150706.patch text/plain 3115 rbuis RnJvbSBiMmQ3NTA4YmUyYzk1MDVlY2M0NDM4OGNmOTNjNzFkMzA4MWUxOTY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgQnVpcyA8cmJ1aXNAaWdhbGlhLmNvbT4KRGF0ZTogTW9u LCAyOCBOb3YgMjAyMiAxNTowNDoxNCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIEFTU0VSVElPTiBG QUlMRUQ6ICFpbWFnZS0+c2l6ZSgpLmlzRW1wdHkoKSB3aGVuIHNldHRpbmcgem9vbQogaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NzAwNQoKUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgpEbyBub3QgcHV0IFNWRyBpbWFnZXMgd2l0aCB3aWR0aCBvciBoZWlnaHQg c21hbGxlciB0aGFuIDEgcGl4ZWwgaW4gdGhlIGNhY2hlLgoKKiBMYXlvdXRUZXN0cy9zdmcvYXMt aW1hZ2Uvc3ZnLWltYWdlLWNhY2hlLWVtcHR5LXNpemUtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKiBMYXlvdXRUZXN0cy9zdmcvYXMtaW1hZ2Uvc3ZnLWltYWdlLWNhY2hlLWVtcHR5LXNpemUt Y3Jhc2guaHRtbDogQWRkZWQuCiogU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdl Q2FjaGUuY3BwOgooV2ViQ29yZTo6U1ZHSW1hZ2VDYWNoZTo6c2V0Q29udGFpbmVyQ29udGV4dEZv ckNsaWVudCk6Ci0tLQogU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlQ2FjaGUu Y3BwICAgICB8ICAzICsrLQogLi4uL3N2Zy1pbWFnZS1jYWNoZS1lbXB0eS1zaXplLWNyYXNoLWV4 cGVjdGVkLnR4dCB8ICAxICsKIC4uLi9zdmctaW1hZ2UtY2FjaGUtZW1wdHktc2l6ZS1jcmFzaC5o dG1sICAgICAgICAgfCAxNSArKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMTggaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3Rz L3N2Zy9hcy1pbWFnZS9zdmctaW1hZ2UtY2FjaGUtZW1wdHktc2l6ZS1jcmFzaC1leHBlY3RlZC50 eHQKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9zdmcvYXMtaW1hZ2Uvc3ZnLWltYWdl LWNhY2hlLWVtcHR5LXNpemUtY3Jhc2guaHRtbAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3N2Zy9ncmFwaGljcy9TVkdJbWFnZUNhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFw aGljcy9TVkdJbWFnZUNhY2hlLmNwcAppbmRleCBhMGUzNmQxMGFiYWMuLmJiNjc2NmY3M2JmYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlQ2FjaGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZUNhY2hlLmNwcApAQCAt NTcsNyArNTcsOCBAQCB2b2lkIFNWR0ltYWdlQ2FjaGU6OnNldENvbnRhaW5lckNvbnRleHRGb3JD bGllbnQoY29uc3QgQ2FjaGVkSW1hZ2VDbGllbnQmIGNsaWVudAogICAgIEZsb2F0U2l6ZSBjb250 YWluZXJTaXplV2l0aG91dFpvb20oY29udGFpbmVyU2l6ZSk7CiAgICAgY29udGFpbmVyU2l6ZVdp dGhvdXRab29tLnNjYWxlKDEgLyBjb250YWluZXJab29tKTsKIAotICAgIG1faW1hZ2VGb3JDb250 YWluZXJNYXAuc2V0KCZjbGllbnQsIFNWR0ltYWdlRm9yQ29udGFpbmVyOjpjcmVhdGUobV9zdmdJ bWFnZSwgY29udGFpbmVyU2l6ZVdpdGhvdXRab29tLCBjb250YWluZXJab29tLCBpbWFnZVVSTCkp OworICAgIGlmIChjb250YWluZXJTaXplV2l0aG91dFpvb20ud2lkdGgoKSA+PSAxLmYgJiYgY29u dGFpbmVyU2l6ZVdpdGhvdXRab29tLmhlaWdodCgpID49IDEuZikKKyAgICAgICAgbV9pbWFnZUZv ckNvbnRhaW5lck1hcC5zZXQoJmNsaWVudCwgU1ZHSW1hZ2VGb3JDb250YWluZXI6OmNyZWF0ZSht X3N2Z0ltYWdlLCBjb250YWluZXJTaXplV2l0aG91dFpvb20sIGNvbnRhaW5lclpvb20sIGltYWdl VVJMKSk7CiB9CiAKIEltYWdlKiBTVkdJbWFnZUNhY2hlOjpmaW5kSW1hZ2VGb3JSZW5kZXJlcihj b25zdCBSZW5kZXJPYmplY3QqIHJlbmRlcmVyKSBjb25zdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvc3ZnL2FzLWltYWdlL3N2Zy1pbWFnZS1jYWNoZS1lbXB0eS1zaXplLWNyYXNoLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3N2Zy9hcy1pbWFnZS9zdmctaW1hZ2UtY2FjaGUtZW1wdHktc2l6 ZS1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwLi5jMjU0MWY0ZjNkZDcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvYXMt aW1hZ2Uvc3ZnLWltYWdlLWNhY2hlLWVtcHR5LXNpemUtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEgQEAKK1BBU1MgaWYgbm8gY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcv YXMtaW1hZ2Uvc3ZnLWltYWdlLWNhY2hlLWVtcHR5LXNpemUtY3Jhc2guaHRtbCBiL0xheW91dFRl c3RzL3N2Zy9hcy1pbWFnZS9zdmctaW1hZ2UtY2FjaGUtZW1wdHktc2l6ZS1jcmFzaC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uNGU5Y2RkOTRhMDM5Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2FzLWltYWdlL3N2Zy1pbWFnZS1jYWNoZS1l bXB0eS1zaXplLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8 ZGl2IGlkPSJjb250YWluZXIxIj4KKyAgPGRpdiBpZD0iY29udGFpbmVyMiI+CisgICAgPGltZyBz cmM9ImRhdGE6aW1hZ2Uvc3ZnK3htbCw8c3ZnIHhtbG5zPSZxdW90O2h0dHA6Ly93d3cudzMub3Jn LzIwMDAvc3ZnJnF1b3Q7IHdpZHRoPSZxdW90OzEmcXVvdDsgaGVpZ2h0PSZxdW90OzEmcXVvdDs+ PC9zdmc+Ij4KKyAgPC9kaXY+Cis8L2Rpdj4KKzxzY3JpcHQ+CisgIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikgeworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgIHRlc3RSdW5uZXIu ZHVtcEFzVGV4dCgpOworICB9CisgIGNvbnRhaW5lcjIuc3R5bGUuYWxsID0gJ2luaGVyaXQnOwor ICBjb250YWluZXIxLnN0eWxlLnpvb20gPSA1MDgyMDQxMjUyNDg0MDQ4NTAwMDA7CisgIHNldFRp bWVvdXQoKCkgPT4geyBkb2N1bWVudC53cml0ZSgnUEFTUyBpZiBubyBjcmFzaC4nKTsgdGVzdFJ1 bm5lci5ub3RpZnlEb25lKCk7IH0sIDApOworPC9zY3JpcHQ+Cg==