246914 2022-10-23 03:36:36 -0700 [web-animations] commitStyles() fails to commit a relative line-height value 2022-10-24 06:02:19 -0700 1 1 1 Unclassified WebKit Animations Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 222096 1 graouts graouts dino graouts koivisto mmaxfield webkit-bug-importer oldest_to_newest 1907627 0 graouts 2022-10-23 03:36:36 -0700 We fail this subtest in web-animations/interfaces/Animation/commitStyles.html: test(t => { const div = createDiv(t); div.style.fontSize = '10px'; const animation = div.animate( { lineHeight: '1.5' }, { duration: 1, fill: 'forwards' } ); animation.finish(); animation.commitStyles(); animation.cancel(); assert_numeric_style_equals(getComputedStyle(div).lineHeight, 15); assert_equals(div.style.lineHeight, "1.5", "line-height is committed as a relative value"); div.style.fontSize = '20px'; assert_numeric_style_equals(getComputedStyle(div).lineHeight, 30, "Changes to the font-size should affect the committed line-height"); }, 'Commits relative line-height'); This is because of BuilderConverter::convertLineHeight() where a line-height specified as a percentage is stored as a LengthType::Fixed, while a line-height specified as number is stored as LengthType::Percent. We'll somehow need to account for `specifiedLineHeight()`. 1907637 1 graouts 2022-10-23 04:13:09 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5685 1907748 2 graouts 2022-10-24 02:18:13 -0700 We'll need mix() support, I filed https://bugs.webkit.org/show_bug.cgi?id=246937. Retitling this bug to correctly identify the issue. 1907749 3 graouts 2022-10-24 02:22:05 -0700 Wrong bug about mix(), we have a fix for this. 1907776 4 ews-feeder 2022-10-24 06:01:27 -0700 Committed 255912@main (1610fc726837): <https://commits.webkit.org/255912@main> Reviewed commits have been landed. Closing PR #5685 and removing active labels. 1907777 5 webkit-bug-importer 2022-10-24 06:02:19 -0700 <rdar://problem/101497231>