<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24647</bug_id>
          
          <creation_ts>2009-03-17 10:14:07 -0700</creation_ts>
          <short_desc>Add a new header file  available to WebCore, WebKit and tools for configuration options</short_desc>
          <delta_ts>2009-03-17 10:14:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>114044</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2009-03-17 10:14:07 -0700</bug_when>
    <thetext>From bug 24396:

&gt; &gt; +#if !defined(BUILDING_ON_TIGER) &amp;&amp; !defined(BUILDING_ON_LEOPARD)
&gt; &gt; +#define WTF_USE_ACCELERATED_COMPOSITING 0
&gt; &gt; +#endif
&gt; 
&gt; I&apos;m worried about this. Why do we have to set this up both in config.h and in
&gt; the prefix? This should be in exactly one place. It&apos;s OK to have that one place
&gt; be included both by the prefix and config.h, but it&apos;s not OK to repeat things
&gt; like this. I know this configuration stuff is a mess, but I would like to keep
&gt; it from getting even worse. Maybe there&apos;s nothing you can easily improve here.
&gt; We could talk about this in person at some point if you like.

Agreed. I asked Mark Rowe about this and he didn&apos;t have any suggestions. We need a header that is included by all code in WebCore, WebKit and tools (DRT), and gets preprocessed after the platform defines.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>