<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>245416</bug_id>
          
          <creation_ts>2022-09-20 01:27:52 -0700</creation_ts>
          <short_desc>[LBSE] Pixel snapping logic is incorrect for SVG, when elements are composited</short_desc>
          <delta_ts>2022-09-26 08:52:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>90738</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Nikolas Zimmermann">zimmermann</reporter>
          <assigned_to name="Nikolas Zimmermann">zimmermann</assigned_to>
          <cc>rbuis</cc>
    
    <cc>sabouhallawa</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1899751</commentid>
    <comment_count>0</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2022-09-20 01:27:52 -0700</bug_when>
    <thetext>In bug webkit.org/b/244966 (&quot;[LBSE] Outermost &lt;svg&gt; elements are not device-pixel aligned&quot;) the rendering was adapted in such a way that the outermost &lt;svg&gt; element is the only element in the SVG subtree that is pixel snapped, delivering consistent results between e.g. HTML &lt;div&gt; elements and SVG &lt;svg&gt; elements, embedded in a CSS formatting context. The &lt;div&gt; will get pixel snapped upon painting -- the same was enforced for the outermost &lt;svg&gt;, however without propagating/accumulating sub-pixel errors for the descendant layers, since no pixel snapping is applied within the SVG subtree.

When elements are composited another logic is used (RenderLayerBacking), and the device-pixel alignment is applied for all SVG layers -- effectively breaking content. By fixing that, the pixel snapping logic is consistent for all painting modes we have, no matter if the outer &lt;svg&gt; is composited, or any of its descendants.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1899757</commentid>
    <comment_count>1</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2022-09-20 02:01:53 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/4520</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901194</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-26 08:51:16 -0700</bug_when>
    <thetext>Committed 254863@main (d2c0299eb83a): &lt;https://commits.webkit.org/254863@main&gt;

Reviewed commits have been landed. Closing PR #4520 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901195</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-09-26 08:52:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/100412807&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>