245299 2022-09-16 14:02:48 -0700 Set empty string for reflection of IDREF attributes 2022-10-07 06:56:32 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 245301 1 rniwa webkit-unassigned andresg_22 rego webkit-bug-importer oldest_to_newest 1899073 0 462404 rniwa 2022-09-16 14:02:48 -0700 Created attachment 462404 Test In the attached test case, we should see: [object HTMLDivElement] bar null null Instead, we see: [object HTMLDivElement] bar null null That is, when the node assigned to element.ariaActiveDescendantElement has been moved to inside a shadow tree, getAttribute('aria-activedescendant') should return null. 1899074 1 webkit-bug-importer 2022-09-16 14:03:05 -0700 <rdar://problem/100042078> 1899076 2 rniwa 2022-09-16 14:04:09 -0700 Expected: In the attached test case, we should see: [object HTMLDivElement] bar null null Actual: [object HTMLDivElement] bar null bar 1900048 3 rego 2022-09-21 00:20:44 -0700 There's a test case in the WPT test that checks this: https://github.com/web-platform-tests/wpt/blob/master/html/dom/aria-element-reflection.html#L231 The test moves an element to the Shadow DOM then checks that ariaActiveDescendantElement is null. Checking the spec (https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#reflecting-content-attributes-in-idl-attributes) this is null because of this text: " 1. If element's explicitly set attr-element is not null: * If element's explicitly set attr-element is a descendant of any of element's shadow-including ancestors, then return element's explicitly set attr-element. * Otherwise, return null. " The first condition is not met, so it returns null. But the test case explicitly checks that the attribute is still kept with the original value. Should the fact that an element has been moved into a shadow tree has an effect on the attributes of another element? Is the test case right or wrong? 1900320 4 rniwa 2022-09-21 23:14:32 -0700 Hm... looks like the spec has setter steps like this. Which means that content attribute will have stale ID set. 1.If the given value is null, then: 1. Set this's explicitly set attr-element to null. 2. Remove the content attribute from this. 3. Return. 2. Let id be the empty string. 3. If the given value: * has the same root as this, and * has an id attribute, and *is the first element in this's node tree whose ID is the value of that id attribute, then set id to the given value's ID. 4. Set the content attribute's value for this to id. 5. Set this's explicitly set attr-element to a weak reference to the given value. 1900323 5 rniwa 2022-09-21 23:26:06 -0700 Filed https://github.com/whatwg/html/issues/8306 1903087 6 rego 2022-10-04 03:53:36 -0700 (In reply to Ryosuke Niwa from comment #5) > Filed https://github.com/whatwg/html/issues/8306 Update bug title after the discussion on that issue. Going back to the first example, the idea is that we won't reflect the content attribute and we'll just set the empty string there. 1904035 7 ews-feeder 2022-10-07 06:56:28 -0700 Committed 255267@main (05f04306d2dc): <https://commits.webkit.org/255267@main> Reviewed commits have been landed. Closing PR #4977 and removing active labels. 462404 2022-09-16 14:02:48 -0700 2022-09-16 14:02:48 -0700 Test aria-move.html text/html 476 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPGRpdiBpZD0iZm9vIj48L2Rpdj4KPGRpdiBp ZD0iYmFyIj48L2Rpdj4KPGRpdiBpZD0iaG9zdCI+PC9kaXY+CjxzY3JpcHQ+Cgpmb28uYXJpYUFj dGl2ZURlc2NlbmRhbnRFbGVtZW50ID0gYmFyOwpkb2N1bWVudC53cml0ZShmb28uYXJpYUFjdGl2 ZURlc2NlbmRhbnRFbGVtZW50ICsgJzxicj4nKTsKZG9jdW1lbnQud3JpdGUoZm9vLmdldEF0dHJp YnV0ZSgnYXJpYS1hY3RpdmVkZXNjZW5kYW50JykgKyAnPGJyPicpOwpob3N0LmF0dGFjaFNoYWRv dyh7bW9kZTogJ2Nsb3NlZCd9KS5hcHBlbmRDaGlsZChiYXIpOwpkb2N1bWVudC53cml0ZShmb28u YXJpYUFjdGl2ZURlc2NlbmRhbnRFbGVtZW50ICsgJzxicj4nKTsKZG9jdW1lbnQud3JpdGUoZm9v LmdldEF0dHJpYnV0ZSgnYXJpYS1hY3RpdmVkZXNjZW5kYW50JykgKyAnPGJyPicpOwoKPC9zY3Jp cHQ+CjwvYm9keT4KPC9odG1sPgo=