<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>245174</bug_id>
          
          <creation_ts>2022-09-14 04:47:40 -0700</creation_ts>
          <short_desc>Align &quot;UA&quot; stylesheet for &quot;hr&quot; with HTML Spec</short_desc>
          <delta_ts>2022-09-25 06:49:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>172801</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=245156</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1898435</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-09-14 04:47:40 -0700</bug_when>
    <thetext>Originating from bug 245156

I tried to do all changes in one go and got quite a lot of failures and difficult to manage them, so I am going to separate them one by one and land them.

It would be easier to manage for me and this is about this one below:

2) hr element is missing &quot;overflow: hidden&quot;.

https://html.spec.whatwg.org/#the-hr-element-2

In case, if I am not able to do it and had to close my PR, I will share details on genuine test failures or why this is no go at the moment for Webkit so someone else can take a look in future.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898819</commentid>
    <comment_count>1</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-09-15 15:02:57 -0700</bug_when>
    <thetext>Learning:

&apos;hr&apos; element change is troublesome because it leads to &quot;render&quot; layer being added and had to re baseline 200+ tests.

Although rebaselining is not the difficult part:

-&gt; on &apos;win&apos; bot, it leads to change in outline color being changed from &apos;blue&apos; to &apos;black&apos; and I don&apos;t know how to fix it.
-&gt; on some WPT test cases in &apos;SELECTION&apos;, we start to fail them and they time out.

Although it leads to some passes as well.

___

PR to look into for future:

https://github.com/WebKit/WebKit/pull/4342</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900085</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-09-21 04:48:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/100218380&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901005</commentid>
    <comment_count>3</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-09-25 06:49:14 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 172801 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>