244660 2022-08-31 23:05:19 -0700 [git-webkit] Accidental overwrite of pull request with similar branch names in Github 2023-09-15 11:01:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 244894 239082 1 lmoura jbedard jbedard rniwa webkit-bug-importer oldest_to_newest 1895422 0 lmoura 2022-08-31 23:05:19 -0700 When searching for pull requests by branch name, the qualifier `head:NAME` matches branches beginning with NAME instead of exact matches. This may cause git-webkit to assume a PR exists for a new branch with similar name to a previous one. Example: Last week I pushed https://github.com/WebKit/WebKit/pull/3732, with branch `non-unified-august-26th`. Submitted and merged normally. Today I tried to submit a new one with branch name `non-unified-august`. The submition ended up finding PR-3732, and overwriting the description of it. Maybe a fix would be checking for exact head/branch name match when checking whether we have an opened PR? (program/pull_request.py:PullRequest.find_existing_pull_request) Link to Github docs: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-branch-name 1896794 1 webkit-bug-importer 2022-09-07 07:05:22 -0700 <rdar://problem/99648208> 1896869 2 jbedard 2022-09-07 13:14:12 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4082 1896874 3 jbedard 2022-09-07 13:31:17 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4108 1898480 4 ews-feeder 2022-09-14 09:30:59 -0700 Committed 254478@main (9eedf00c4427): <https://commits.webkit.org/254478@main> Reviewed commits have been landed. Closing PR #4108 and removing active labels. 1899882 5 ews-feeder 2022-09-20 10:44:48 -0700 Committed 252432.448@safari-7614-branch (aec8adaf317c): <https://commits.webkit.org/252432.448@safari-7614-branch> Reviewed commits have been landed. Closing PR #73 and removing active labels. 1977725 6 jbedard 2023-09-15 11:01:10 -0700 *** Bug 242836 has been marked as a duplicate of this bug. ***