244374 2022-08-25 20:48:58 -0700 Unify copies of SDKVariant.xcconfig 2022-08-28 08:20:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 244440 244450 1 ddkilzer ddkilzer ap ryanhaddad thorton webkit-bug-importer oldest_to_newest 1893898 0 ddkilzer 2022-08-25 20:48:58 -0700 Unify copies of SDKVariant.xcconfig. Create a `Source/Configurations` folder and move one copy of `SDKVariant.xcconfig` into it, then remove the duplicate copies, then finally fix project references to use relative paths. The `Source/Configurations` folder is added to the WebKit.xcworkspace as well (since we can move other common files into this folder later). We place this in `Source` instead of in the top-level folder since it will make source submissions easier at Apple. 1893899 1 webkit-bug-importer 2022-08-25 20:49:17 -0700 <rdar://problem/99169843> 1893900 2 ddkilzer 2022-08-25 20:57:30 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3688 1894175 3 ews-feeder 2022-08-26 22:26:21 -0700 Committed 253857@main (024ecd89c769): <https://commits.webkit.org/253857@main> Reviewed commits have been landed. Closing PR #3688 and removing active labels. 1894249 4 ddkilzer 2022-08-27 14:18:31 -0700 (In reply to David Kilzer (:ddkilzer) from comment #0) > Unify copies of SDKVariant.xcconfig. > > Create a `Source/Configurations` folder and move one copy of > `SDKVariant.xcconfig` into it, then remove the duplicate copies, then > finally fix project references to use relative paths. > > The `Source/Configurations` folder is added to the WebKit.xcworkspace as > well (since we can move other common files into this folder later). > > We place this in `Source` instead of in the top-level folder since it will > make source submissions easier at Apple. FYI, the `Configurations` folder was placed at the same level as the `Source` folder since there was a simple change to `Makefile` to make source submissions work.