243562 2022-08-04 15:24:15 -0700 Make '-webkit-background-size' a legacy shorthand 2022-11-13 02:54:10 -0800 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 240341 1 ntim akeerthi akeerthi cdumez ntim webkit-bug-importer wenson_hsieh oldest_to_newest 1888983 0 ntim 2022-08-04 15:24:15 -0700 This test checks that setting various properties to the same value as the user agent stylesheet does not change the appearance. We fail this check, potentially because our borderAndBackgroundEquals check does not cover enough properties. 1888984 1 webkit-bug-importer 2022-08-04 15:24:25 -0700 <rdar://problem/98151497> 1889595 2 akeerthi 2022-08-07 22:23:46 -0700 One of the issues is: https://github.com/web-platform-tests/wpt/issues/35333. The other issue is that the list of "fallback-props" in https://github.com/web-platform-tests/wpt/blob/19d452e70a/css/css-ui/compute-kind-widget-no-fallback-props-001.html, does not include `-webkit-background-size`, in addition to `background-size`, causing the `borderAndBackgroundEquals` check to fail, dropping native appearance. The test and the spec likely need to be updated. 1889926 3 ntim 2022-08-08 21:37:41 -0700 (In reply to Aditya Keerthi from comment #2) > The other issue is that the list of "fallback-props" in > https://github.com/web-platform-tests/wpt/blob/19d452e70a/css/css-ui/compute- > kind-widget-no-fallback-props-001.html, does not include > `-webkit-background-size`, in addition to `background-size`, causing the > `borderAndBackgroundEquals` check to fail, dropping native appearance. The proper way to fix this would be making `-webkit-background-size` a legacy shorthand of `background-size` rather than implementing it as a related property. An example of this is bug 104805. 1890094 4 ntim 2022-08-09 14:02:24 -0700 WPT PR: https://github.com/web-platform-tests/wpt/pull/35408 1891038 5 akeerthi 2022-08-12 17:24:23 -0700 I have a patch in progress to make `-webkit-background-size` a legacy shorthand. This actually makes appearance behave correctly, however, the test still fails. We will also need to fix the intrinsic margins issue (https://bugs.webkit.org/show_bug.cgi?id=107380) in order to get this test passing. I confirmed that with my background-size patch, and with Chris' patch in https://bugs.webkit.org/show_bug.cgi?id=107380, this test finally passes. 1891741 6 akeerthi 2022-08-16 13:26:25 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3372 1901579 7 ews-feeder 2022-09-27 11:16:29 -0700 Committed 254925@main (856140e9a06f): <https://commits.webkit.org/254925@main> Reviewed commits have been landed. Closing PR #3372 and removing active labels.