243526 2022-08-03 19:15:51 -0700 [Painting] Remove redundant public TextDecorationPainter functions 2022-08-14 14:06:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 243766 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1888775 0 zalan 2022-08-03 19:15:51 -0700 ssia 1888776 1 461391 zalan 2022-08-03 19:17:51 -0700 Created attachment 461391 Patch 1888841 2 461391 koivisto 2022-08-04 06:03:04 -0700 Comment on attachment 461391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461391&action=review > Source/WebCore/rendering/TextBoxPainter.cpp:435 > // Create painter a valuable comment 1888844 3 zalan 2022-08-04 06:14:51 -0700 (In reply to Antti Koivisto from comment #2) > Comment on attachment 461391 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461391&action=review > > > Source/WebCore/rendering/TextBoxPainter.cpp:435 > > // Create painter > > a valuable comment Indeed. Will remove in the next patch. 1888846 4 ews-feeder 2022-08-04 06:23:12 -0700 Committed 253109@main (5dae5b149b60): <https://commits.webkit.org/253109@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461391. 1888847 5 webkit-bug-importer 2022-08-04 06:24:16 -0700 <rdar://problem/98121284> 461391 2022-08-03 19:17:51 -0700 2022-08-04 06:23:13 -0700 Patch bug-243526-20220803191750.patch text/plain 6396 zalan RnJvbSA5ZDFlOWU4NmYxNDJlNzVjYmMzZDJmOTY2OGUyMzFjMTk5ODllZjVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBX ZWQsIDMgQXVnIDIwMjIgMTk6MTY6MjggLTA3MDAKU3ViamVjdDogW1BBVENIXSBbUGFpbnRpbmdd IFJlbW92ZSByZWR1bmRhbnQgcHVibGljIFRleHREZWNvcmF0aW9uUGFpbnRlcgogZnVuY3Rpb25z IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDM1MjYKClJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dEJveFBh aW50ZXIuY3BwOgooV2ViQ29yZTo6VGV4dEJveFBhaW50ZXI8VGV4dEJveFBhdGg+OjpjcmVhdGVE ZWNvcmF0aW9uUGFpbnRlcik6CiogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHREZWNvcmF0 aW9uUGFpbnRlci5jcHA6CihXZWJDb3JlOjpUZXh0RGVjb3JhdGlvblBhaW50ZXI6OlRleHREZWNv cmF0aW9uUGFpbnRlcik6CiogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHREZWNvcmF0aW9u UGFpbnRlci5oOgooV2ViQ29yZTo6VGV4dERlY29yYXRpb25QYWludGVyOjpzZXRUZXh0Qm94KTog RGVsZXRlZC4KKFdlYkNvcmU6OlRleHREZWNvcmF0aW9uUGFpbnRlcjo6c2V0SXNIb3Jpem9udGFs KTogRGVsZXRlZC4KKFdlYkNvcmU6OlRleHREZWNvcmF0aW9uUGFpbnRlcjo6c2V0V2lkdGgpOiBE ZWxldGVkLgooV2ViQ29yZTo6VGV4dERlY29yYXRpb25QYWludGVyOjpzZXRUZXh0U2hhZG93KTog RGVsZXRlZC4KKFdlYkNvcmU6OlRleHREZWNvcmF0aW9uUGFpbnRlcjo6c2V0U2hhZG93Q29sb3JG aWx0ZXIpOiBEZWxldGVkLgotLS0KIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Qm94UGFp bnRlci5jcHAgICAgICAgfCAxNSArKystLS0tLS0tLS0tLS0KIC4uLi9XZWJDb3JlL3JlbmRlcmlu Zy9UZXh0RGVjb3JhdGlvblBhaW50ZXIuY3BwICAgfCAgNyArKysrKystCiBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvVGV4dERlY29yYXRpb25QYWludGVyLmggIHwgMTEgKysrLS0tLS0tLS0KIDMg ZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRCb3hQYWludGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Qm94UGFpbnRlci5jcHAKaW5kZXggNjhjNjljYWFlMTBl Li5hNjc2MDZhNThiNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0 Qm94UGFpbnRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRCb3hQYWlu dGVyLmNwcApAQCAtNDMzLDIwICs0MzMsMTEgQEAgVGV4dERlY29yYXRpb25QYWludGVyIFRleHRC b3hQYWludGVyPFRleHRCb3hQYXRoPjo6Y3JlYXRlRGVjb3JhdGlvblBhaW50ZXIoY29uc3QKICAg ICB9CiAKICAgICAvLyBDcmVhdGUgcGFpbnRlcgotICAgIGNvbnN0IEZvbnRDYXNjYWRlJiBmb250 ID0gZm9udENhc2NhZGUoKTsKICAgICBhdXRvIHRleHREZWNvcmF0aW9ucyA9IG1fc3R5bGUudGV4 dERlY29yYXRpb25zSW5FZmZlY3QoKTsKICAgICB0ZXh0RGVjb3JhdGlvbnMuYWRkKFRleHREZWNv cmF0aW9uUGFpbnRlcjo6dGV4dERlY29yYXRpb25zSW5FZmZlY3RGb3JTdHlsZShtYXJrZWRUZXh0 LnN0eWxlLnRleHREZWNvcmF0aW9uU3R5bGVzKSk7Ci0gICAgVGV4dERlY29yYXRpb25QYWludGVy IGRlY29yYXRpb25QYWludGVyIHsgY29udGV4dCwgdGV4dERlY29yYXRpb25zLCBtX3JlbmRlcmVy LCBtX2lzRmlyc3RMaW5lLCBmb250LCBtYXJrZWRUZXh0LnN0eWxlLnRleHREZWNvcmF0aW9uU3R5 bGVzIH07Ci0gICAgZGVjb3JhdGlvblBhaW50ZXIuc2V0VGV4dEJveChtYWtlSXRlcmF0b3IoKSk7 Ci0gICAgZGVjb3JhdGlvblBhaW50ZXIuc2V0V2lkdGgoc25hcHBlZFNlbGVjdGlvblJlY3Qud2lk dGgoKSk7Ci0gICAgZGVjb3JhdGlvblBhaW50ZXIuc2V0SXNIb3Jpem9udGFsKHRleHRCb3goKS5p c0hvcml6b250YWwoKSk7Ci0gICAgaWYgKG1hcmtlZFRleHQuc3R5bGUudGV4dFNoYWRvdykgewot ICAgICAgICBkZWNvcmF0aW9uUGFpbnRlci5zZXRUZXh0U2hhZG93KCZtYXJrZWRUZXh0LnN0eWxl LnRleHRTaGFkb3cudmFsdWUoKSk7Ci0gICAgICAgIGlmIChtX3N0eWxlLmhhc0FwcGxlQ29sb3JG aWx0ZXIoKSkKLSAgICAgICAgICAgIGRlY29yYXRpb25QYWludGVyLnNldFNoYWRvd0NvbG9yRmls dGVyKCZtX3N0eWxlLmFwcGxlQ29sb3JGaWx0ZXIoKSk7Ci0gICAgfQotCi0gICAgcmV0dXJuIGRl Y29yYXRpb25QYWludGVyOworICAgIGF1dG8qIHNoYWRvdyA9IG1hcmtlZFRleHQuc3R5bGUudGV4 dFNoYWRvdyA/ICZtYXJrZWRUZXh0LnN0eWxlLnRleHRTaGFkb3cudmFsdWUoKSA6IG51bGxwdHI7 CisgICAgYXV0byogY29sb3JGaWx0ZXIgPSBtYXJrZWRUZXh0LnN0eWxlLnRleHRTaGFkb3cgJiYg bV9zdHlsZS5oYXNBcHBsZUNvbG9yRmlsdGVyKCkgPyAmbV9zdHlsZS5hcHBsZUNvbG9yRmlsdGVy KCkgOiBudWxscHRyOworICAgIHJldHVybiB7IGNvbnRleHQsIHRleHREZWNvcmF0aW9ucywgbV9y ZW5kZXJlciwgbV9pc0ZpcnN0TGluZSwgZm9udENhc2NhZGUoKSwgbWFrZUl0ZXJhdG9yKCksIHNu YXBwZWRTZWxlY3Rpb25SZWN0LndpZHRoKCksIHNoYWRvdywgY29sb3JGaWx0ZXIsIG1hcmtlZFRl eHQuc3R5bGUudGV4dERlY29yYXRpb25TdHlsZXMgfTsKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUg VGV4dEJveFBhdGg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dERl Y29yYXRpb25QYWludGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0RGVjb3Jh dGlvblBhaW50ZXIuY3BwCmluZGV4IDZkMTFlOWM1NDFkMi4uYTVkZWVkYjRhZjc2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dERlY29yYXRpb25QYWludGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dERlY29yYXRpb25QYWludGVyLmNwcApA QCAtMTkxLDExICsxOTEsMTYgQEAgYm9vbCBUZXh0RGVjb3JhdGlvblBhaW50ZXI6OlN0eWxlczo6 b3BlcmF0b3I9PShjb25zdCBTdHlsZXMmIG90aGVyKSBjb25zdAogICAgICAgICAmJiB1bmRlcmxp bmVTdHlsZSA9PSBvdGhlci51bmRlcmxpbmVTdHlsZSAmJiBvdmVybGluZVN0eWxlID09IG90aGVy Lm92ZXJsaW5lU3R5bGUgJiYgbGluZXRocm91Z2hTdHlsZSA9PSBvdGhlci5saW5ldGhyb3VnaFN0 eWxlOwogfQogCi1UZXh0RGVjb3JhdGlvblBhaW50ZXI6OlRleHREZWNvcmF0aW9uUGFpbnRlcihH cmFwaGljc0NvbnRleHQmIGNvbnRleHQsIE9wdGlvblNldDxUZXh0RGVjb3JhdGlvbkxpbmU+IGRl Y29yYXRpb25zLCBjb25zdCBSZW5kZXJUZXh0JiByZW5kZXJlciwgYm9vbCBpc0ZpcnN0TGluZSwg Y29uc3QgRm9udENhc2NhZGUmIGZvbnQsIHN0ZDo6b3B0aW9uYWw8U3R5bGVzPiBzdHlsZXMpCitU ZXh0RGVjb3JhdGlvblBhaW50ZXI6OlRleHREZWNvcmF0aW9uUGFpbnRlcihHcmFwaGljc0NvbnRl eHQmIGNvbnRleHQsIE9wdGlvblNldDxUZXh0RGVjb3JhdGlvbkxpbmU+IGRlY29yYXRpb25zLCBj b25zdCBSZW5kZXJUZXh0JiByZW5kZXJlciwgYm9vbCBpc0ZpcnN0TGluZSwgY29uc3QgRm9udENh c2NhZGUmIGZvbnQsIElubGluZUl0ZXJhdG9yOjpUZXh0Qm94SXRlcmF0b3IgdGV4dEJveCwgZmxv YXQgd2lkdGgsIGNvbnN0IFNoYWRvd0RhdGEqIHNoYWRvdywgY29uc3QgRmlsdGVyT3BlcmF0aW9u cyogY29sb3JGaWx0ZXIsIHN0ZDo6b3B0aW9uYWw8U3R5bGVzPiBzdHlsZXMpCiAgICAgOiBtX2Nv bnRleHQgeyBjb250ZXh0IH0KICAgICAsIG1fZGVjb3JhdGlvbnMgeyBkZWNvcmF0aW9ucyB9CiAg ICAgLCBtX3dhdnlPZmZzZXQgeyB3YXZ5T2Zmc2V0RnJvbURlY29yYXRpb24oKSB9CisgICAgLCBt X3dpZHRoKHdpZHRoKQogICAgICwgbV9pc1ByaW50aW5nIHsgcmVuZGVyZXIuZG9jdW1lbnQoKS5w cmludGluZygpIH0KKyAgICAsIG1faXNIb3Jpem9udGFsKHRleHRCb3gtPmlzSG9yaXpvbnRhbCgp KQorICAgICwgbV9zaGFkb3coc2hhZG93KQorICAgICwgbV9zaGFkb3dDb2xvckZpbHRlcihjb2xv ckZpbHRlcikKKyAgICAsIG1fdGV4dEJveCh0ZXh0Qm94KQogICAgICwgbV9mb250IHsgZm9udCB9 CiAgICAgLCBtX3N0eWxlcyB7IHN0eWxlcyA/ICpXVEZNb3ZlKHN0eWxlcykgOiBzdHlsZXNGb3JS ZW5kZXJlcihyZW5kZXJlciwgZGVjb3JhdGlvbnMsIGlzRmlyc3RMaW5lLCBQc2V1ZG9JZDo6Tm9u ZSkgfQogICAgICwgbV9saW5lU3R5bGUgeyBpc0ZpcnN0TGluZSA/IHJlbmRlcmVyLmZpcnN0TGlu ZVN0eWxlKCkgOiByZW5kZXJlci5zdHlsZSgpIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9UZXh0RGVjb3JhdGlvblBhaW50ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9UZXh0RGVjb3JhdGlvblBhaW50ZXIuaAppbmRleCA2MzhhYzk2MzVkMGYuLjU0MzI4ZmRk Y2ZmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHREZWNvcmF0aW9u UGFpbnRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0RGVjb3JhdGlvblBh aW50ZXIuaApAQCAtNDQsMTcgKzQ0LDEwIEBAIGNsYXNzIFRleHRSdW47CiBjbGFzcyBUZXh0RGVj b3JhdGlvblBhaW50ZXIgewogcHVibGljOgogICAgIHN0cnVjdCBTdHlsZXM7Ci0gICAgVGV4dERl Y29yYXRpb25QYWludGVyKEdyYXBoaWNzQ29udGV4dCYsIE9wdGlvblNldDxUZXh0RGVjb3JhdGlv bkxpbmU+IGRlY29yYXRpb25zLCBjb25zdCBSZW5kZXJUZXh0JiwgYm9vbCBpc0ZpcnN0TGluZSwg Y29uc3QgRm9udENhc2NhZGUmLCBzdGQ6Om9wdGlvbmFsPFN0eWxlcz4gPSBzdGQ6Om51bGxvcHQp OwotICAgIAotICAgIHZvaWQgc2V0VGV4dEJveChJbmxpbmVJdGVyYXRvcjo6VGV4dEJveEl0ZXJh dG9yIHRleHRCb3gpIHsgbV90ZXh0Qm94ID0gdGV4dEJveDsgfQotICAgIHZvaWQgc2V0SXNIb3Jp em9udGFsKGJvb2wgaXNIb3Jpem9udGFsKSB7IG1faXNIb3Jpem9udGFsID0gaXNIb3Jpem9udGFs OyB9Ci0gICAgdm9pZCBzZXRXaWR0aChmbG9hdCB3aWR0aCkgeyBtX3dpZHRoID0gd2lkdGg7IH0K LSAgICB2b2lkIHNldFRleHRTaGFkb3coY29uc3QgU2hhZG93RGF0YSogdGV4dFNoYWRvdykgeyBt X3NoYWRvdyA9IHRleHRTaGFkb3c7IH0KLSAgICB2b2lkIHNldFNoYWRvd0NvbG9yRmlsdGVyKGNv bnN0IEZpbHRlck9wZXJhdGlvbnMqIGNvbG9yRmlsdGVyKSB7IG1fc2hhZG93Q29sb3JGaWx0ZXIg PSBjb2xvckZpbHRlcjsgfQorICAgIFRleHREZWNvcmF0aW9uUGFpbnRlcihHcmFwaGljc0NvbnRl eHQmLCBPcHRpb25TZXQ8VGV4dERlY29yYXRpb25MaW5lPiBkZWNvcmF0aW9ucywgY29uc3QgUmVu ZGVyVGV4dCYsIGJvb2wgaXNGaXJzdExpbmUsIGNvbnN0IEZvbnRDYXNjYWRlJiwgSW5saW5lSXRl cmF0b3I6OlRleHRCb3hJdGVyYXRvciwgZmxvYXQgd2lkdGgsIGNvbnN0IFNoYWRvd0RhdGEqLCBj b25zdCBGaWx0ZXJPcGVyYXRpb25zKiwgc3RkOjpvcHRpb25hbDxTdHlsZXM+ID0gc3RkOjpudWxs b3B0KTsKIAogICAgIHZvaWQgcGFpbnRCYWNrZ3JvdW5kRGVjb3JhdGlvbnMoY29uc3QgVGV4dFJ1 biYsIGNvbnN0IEZsb2F0UG9pbnQmIHRleHRPcmlnaW4sIGNvbnN0IEZsb2F0UG9pbnQmIGJveE9y aWdpbik7CiAgICAgdm9pZCBwYWludEZvcmVncm91bmREZWNvcmF0aW9ucyhjb25zdCBGbG9hdFBv aW50JiBib3hPcmlnaW4pOwotICAgIHZvaWQgcGFpbnRMaW5lVGhyb3VnaChjb25zdCBDb2xvciYs IGZsb2F0IHRoaWNrbmVzcywgY29uc3QgRmxvYXRQb2ludCYgbG9jYWxPcmlnaW4pOwogCiAgICAg c3RydWN0IFN0eWxlcyB7CiAgICAgICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBTdHlsZXMmKSBj b25zdDsKQEAgLTcyLDYgKzY1LDggQEAgcHVibGljOgogICAgIHN0YXRpYyBTdHlsZXMgc3R5bGVz Rm9yUmVuZGVyZXIoY29uc3QgUmVuZGVyT2JqZWN0JiwgT3B0aW9uU2V0PFRleHREZWNvcmF0aW9u TGluZT4gcmVxdWVzdGVkRGVjb3JhdGlvbnMsIGJvb2wgZmlyc3RMaW5lU3R5bGUgPSBmYWxzZSwg UHNldWRvSWQgPSBQc2V1ZG9JZDo6Tm9uZSk7CiAKIHByaXZhdGU6CisgICAgdm9pZCBwYWludExp bmVUaHJvdWdoKGNvbnN0IENvbG9yJiwgZmxvYXQgdGhpY2tuZXNzLCBjb25zdCBGbG9hdFBvaW50 JiBsb2NhbE9yaWdpbik7CisKICAgICBHcmFwaGljc0NvbnRleHQmIG1fY29udGV4dDsKICAgICBP cHRpb25TZXQ8VGV4dERlY29yYXRpb25MaW5lPiBtX2RlY29yYXRpb25zOwogICAgIGZsb2F0IG1f d2F2eU9mZnNldDsK