24346 2009-03-04 02:02:58 -0800 Remove Gears workaround in HTMLObjectElement.cpp 2010-11-29 08:47:22 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 27775 45049 1 playmobil playmobil commit-queue dglazkov eric jorlow simon.fraser oldest_to_newest 112168 0 playmobil 2009-03-04 02:02:58 -0800 This bug is to track removal of the temporary workaround for Gears compatibility in WebKit (see https://bugs.webkit.org/show_bug.cgi?id=24215). Closing this bug should involve removing the workaround in favor of a long term solution. The underlying problem is that current users of gears use a standard gears_init.js that relies on a plugin loading if it's display attribute is set to hidden. 272707 1 eric 2010-09-01 02:23:07 -0700 What's the status here? This code is still in the codebase. 272811 2 simon.fraser 2010-09-01 08:19:44 -0700 The plan is to make plugins not go away when an element has display:none. Not sure if we have a bugzilla bug on that. 272914 3 simon.fraser 2010-09-01 11:35:47 -0700 See bug 27775. 314326 4 75005 playmobil 2010-11-29 02:55:34 -0800 Created attachment 75005 Patch 314397 5 75005 eric 2010-11-29 07:25:35 -0800 Comment on attachment 75005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75005&action=review I think we can safely remove the entire rendererIsNeeded() call. I don't see any parent implementations preventing creation of renderers when a document doesn't have a frame, but I believe that to be the case. Frameless documents won't have a FrameView, thus won't be rendered is my understanding. I think this whole override can be removed unless we have a test which proves otherwise. > WebCore/html/HTMLObjectElement.cpp:289 > if (!frame) > return false; Are we sure this is still needed? 314399 6 eric 2010-11-29 07:31:20 -0800 I'd rather see you commit this by hand and remove the whole function (or post a new patch to do so). I don't believe the !frame check has any utility. 314401 7 playmobil 2010-11-29 07:35:13 -0800 I'm not familiar with the surrounding code, I'm just removing the workaround I put in. I'd prefer for more ambitious cleanups to be done by other people who have better knowledge of the area. Does that sound OK? 314410 8 75005 commit-queue 2010-11-29 07:52:04 -0800 Comment on attachment 75005 Patch Clearing flags on attachment: 75005 Committed r72799: <http://trac.webkit.org/changeset/72799> 314411 9 commit-queue 2010-11-29 07:52:11 -0800 All reviewed patches have been landed. Closing bug. 314444 10 simon.fraser 2010-11-29 08:47:22 -0800 I'm confused. Bug 27775 is not fixed. Was Gears changed to avoid this issue? 75005 2010-11-29 02:55:34 -0800 2010-11-29 07:52:04 -0800 Patch bug-24346-20101129125533.patch text/plain 1564 playmobil ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDg3Mjc3YmI2YjMxYmU1YWU5MGU3N2U2YTI5MjY5NzJhNjllZDM0MS4uZmZmZWMzMDBjZTk1ZWU4 Y2ViOWNmZGU4NDJiNDgyMjc2MGM2ODA1NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0yOSAgSmVy ZW15IE1vc2tvdmljaCAgPGplcmVteUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI0MzQ2CisKKyAgICAgICAgUmVtb3ZlIHRlbXBvcmFyeSB3b3JrYXJvdW5k IHRvIGxvYWQgR2VhcnMgcGx1Z2luLgorCisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MT2JqZWN0RWxlbWVudDo6cmVuZGVyZXJJc05l ZWRlZCk6CisKIDIwMTAtMTEtMjkgIEhlbGRlciBDb3JyZWlhICA8aGVsZGVyQHNlbmNoYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTE9iamVjdEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1s L0hUTUxPYmplY3RFbGVtZW50LmNwcAppbmRleCBjMDdkMDUwM2Y2OTk3MGU4ZjY0OTY1ZGViNmE1 NjFkY2IwOWM2OWRlLi42OTk3NGE4MGM0Y2Q2ZGU2ZWMzNTFhMGY5ZGRjM2E2NzMzZjAwYWZlIDEw MDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTE9iamVjdEVsZW1lbnQuY3BwCisrKyBiL1dlYkNv cmUvaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5jcHAKQEAgLTI4NywxMiArMjg3LDggQEAgYm9vbCBI VE1MT2JqZWN0RWxlbWVudDo6cmVuZGVyZXJJc05lZWRlZChSZW5kZXJTdHlsZSogc3R5bGUpCiAg ICAgRnJhbWUqIGZyYW1lID0gZG9jdW1lbnQoKS0+ZnJhbWUoKTsKICAgICBpZiAoIWZyYW1lKQog ICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgCi0gICAgLy8gVGVtcG9yYXJ5IFdvcmthcm91bmQg Zm9yIEdlYXJzIHBsdWdpbiAtIHNlZSBidWcgMjQyMTUgZm9yIGRldGFpbHMgYW5kIGJ1ZyAyNDM0 NiB0byB0cmFjayByZW1vdmFsLgotICAgIC8vIEdlYXJzIGV4cGVjdHMgdGhlIHBsdWdpbiB0byBi ZSBpbnN0YW50aWF0ZWQgZXZlbiBpZiBkaXNwbGF5Om5vbmUgaXMgc2V0Ci0gICAgLy8gZm9yIHRo ZSBvYmplY3QgZWxlbWVudC4KLSAgICBib29sIGlzR2VhcnNQbHVnaW4gPSBlcXVhbElnbm9yaW5n Q2FzZShnZXRBdHRyaWJ1dGUodHlwZUF0dHIpLCAiYXBwbGljYXRpb24veC1nb29nbGVnZWFycyIp OwotICAgIHJldHVybiBpc0dlYXJzUGx1Z2luIHx8IEhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnJl bmRlcmVySXNOZWVkZWQoc3R5bGUpOworCisgICAgcmV0dXJuIEhUTUxQbHVnSW5JbWFnZUVsZW1l bnQ6OnJlbmRlcmVySXNOZWVkZWQoc3R5bGUpOwogfQogCiB2b2lkIEhUTUxPYmplY3RFbGVtZW50 OjppbnNlcnRlZEludG9Eb2N1bWVudCgpCg==