<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>243329</bug_id>
          
          <creation_ts>2022-07-28 18:32:34 -0700</creation_ts>
          <short_desc>test-webkitpy is failing to install lupa-1.13.0 on Windows Python</short_desc>
          <delta_ts>2022-09-28 18:47:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=233734</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=245810</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jbedard</cc>
    
    <cc>stephan.szabo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1887504</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2022-07-28 18:32:34 -0700</bug_when>
    <thetext>webkitpy: Failed to install lupa-1.13.0! on WinCairo buildbot

&gt; ValueError: path &apos;/home/runner/work/lupa/lupa/third-party/lua/lapi.c&apos; cannot be absolute
&gt; Failed to install lupa-1.13.0!

Buildbot: builder WinCairo-64-bit-WKL-Release-Tests build 7512
https://build.webkit.org/#/builders/60/builds/7512</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1887508</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2022-07-28 19:02:58 -0700</bug_when>
    <thetext>On Windows, &quot;pip install lupa&quot; just downloads a pre-compiled binary.

PS D:\work\tmp&gt; pip install lupa
Collecting lupa
  Downloading lupa-1.13-cp39-cp39-win_amd64.whl (287 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 287.6/287.6 kB 8.9 MB/s eta 0:00:00
Installing collected packages: lupa
Successfully installed lupa-1.13</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1887514</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2022-07-28 19:13:18 -0700</bug_when>
    <thetext>lupa-1.13/lupa.egg-info/SOURCES.txt of lupa-1.13.tar.gz contains the someone&apos;s absolute path.

&gt; ...
&gt; /home/runner/work/lupa/lupa/third-party/lua/lapi.c
&gt; /home/runner/work/lupa/lupa/third-party/lua/lauxlib.c
&gt; /home/runner/work/lupa/lupa/third-party/lua/lbaselib.c
&gt; ...

Unpacking lupa-1.13.tar.gz and invoking &quot;python .\setup.py install&quot; reported the same error.

&gt; ValueError: path &apos;/home/runner/work/lupa/lupa/third-party/lua/lapi.c&apos; cannot be absolute

However, removing the &apos;lupa.egg-info&apos; directory and invoking &quot;python .\setup.py install&quot; succeeded.
&apos;lupa.egg-info&apos; directory was regenerated and lupa.egg-info/SOURCES.txt contained my absolute path.

&gt; ...
&gt; D:/work/tmp/lupa-1.13/third-party/lua/lapi.c
&gt; D:/work/tmp/lupa-1.13/third-party/lua/lauxlib.c
&gt; D:/work/tmp/lupa-1.13/third-party/lua/lbaselib.c
&gt; ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1887519</commentid>
    <comment_count>3</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2022-07-28 19:37:15 -0700</bug_when>
    <thetext>244901@main (bug#233734) added the implementation and unit tests of commits.webkit.org.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1887532</commentid>
    <comment_count>4</comment_count>
      <attachid>461288</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2022-07-28 21:04:17 -0700</bug_when>
    <thetext>Created attachment 461288
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1888145</commentid>
    <comment_count>5</comment_count>
      <attachid>461288</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2022-08-01 13:06:16 -0700</bug_when>
    <thetext>Comment on attachment 461288
Patch

Thank you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1888180</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-08-01 13:42:40 -0700</bug_when>
    <thetext>Committed 253008@main (5df171bce18e): &lt;https://commits.webkit.org/253008@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461288.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1888184</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-08-01 13:45:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/97933765&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>461288</attachid>
            <date>2022-07-28 21:04:17 -0700</date>
            <delta_ts>2022-08-01 13:42:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-243329-20220729130416.patch</filename>
            <type>text/plain</type>
            <size>1618</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">RnJvbSBlMjA2OGJmZGNiMTEyOGU1YWJlOGIxYzUwYmMzNmJkZDYxOTA0NDIyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j
b20+CkRhdGU6IEZyaSwgMjkgSnVsIDIwMjIgMTI6NTg6NTcgKzA5MDAKU3ViamVjdDogW1BBVENI
XSB0ZXN0LXdlYmtpdHB5IGlzIGZhaWxpbmcgdG8gaW5zdGFsbCBsdXBhLTEuMTMuMCBvbiBXaW5k
b3dzCiBQeXRob24gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MzMy
OQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpsdXBhIGlzIHVzZWQgb25seSBieSByZXBv
cmVsYXlweSB3aGljaCBpcyB1c2VkIGZvciBjb21taXRzLndlYmtpdC5vcmcuCnJlcG9yZWxheXB5
IGRvZXNuJ3QgaGF2ZSB0byB0ZXN0IHdpdGggV2luZG93cyBQeXRob24uIEp1c3Qgc2tpcCB0aGUK
dGVzdHMgZm9yIFdpbmRvd3MgUHl0aG9uLgoKKiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3Qv
bWFpbi5weToKKG1haW4pOgooVGVzdGVyLl9ydW5fdGVzdHMpOgotLS0KIFRvb2xzL1NjcmlwdHMv
d2Via2l0cHkvdGVzdC9tYWluLnB5IHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv
bnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L3Rlc3QvbWFpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5CmluZGV4
IGQ4ODMyNzc3NWI4OC4uMDJkY2M4NmQyZTIyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L3Rlc3QvbWFpbi5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFp
bi5weQpAQCAtNzcsNiArNzcsNyBAQCBkZWYgbWFpbigpOgogICAgIHRlc3Rlci5za2lwKCgnd2Vi
a2l0cHkuY29tbW9uLmNoZWNrb3V0LnNjbS5zY21fdW5pdHRlc3QnLCksICdhcmUgcmVhbGx5LCBy
ZWFsbHksIHNsb3cnLCAzMTgxOCkKICAgICBpZiBzeXMucGxhdGZvcm0uc3RhcnRzd2l0aCgnd2lu
Jyk6CiAgICAgICAgIHRlc3Rlci5za2lwKCgnd2Via2l0cHkuY29tbW9uLmNoZWNrb3V0JywgJ3dl
YmtpdHB5LnRvb2wnKSwgJ2ZhaWwgaG9ycmlibHkgb24gd2luMzInLCA1NDUyNikKKyAgICAgICAg
dGVzdGVyLnNraXAoKCdyZXBvcmVsYXlweScsKSwgJ2ZhaWwgdG8gaW5zdGFsbCBsdXBhIGFuZCBk
b25cJ3QgaGF2ZSB0byB0ZXN0IG9uIHdpbjMyJywgMjQzMzE2KQogCiAgICAgIyBUZXN0cyB0aGF0
IGFyZSBwbGF0Zm9ybSBzcGVjaWZpYwogICAgIG1hY19vbmx5X3Rlc3RzID0gKApAQCAtMTkzLDcg
KzE5NCw3IEBAIGNsYXNzIFRlc3RlcihvYmplY3QpOgogICAgICAgICBmcm9tIHdlYmtpdGNvcmVw
eSBpbXBvcnQgQXV0b0luc3RhbGwKIAogICAgICAgICAjIEZvcmNlIHJlZ2lzdHJhdGlvbiBvZiBh
bGwgYXV0b2luc3RhbGxlZCBwYWNrYWdlcy4KLSAgICAgICAgaWYgc3lzLnZlcnNpb25faW5mbyA+
ICgzLCAwKToKKyAgICAgICAgaWYgYW55KFtuLnN0YXJ0c3dpdGgoJ3JlcG9yZWxheXB5JykgZm9y
IG4gaW4gbmFtZXNdKToKICAgICAgICAgICAgIGltcG9ydCByZXBvcmVsYXlweQogICAgICAgICBp
bXBvcnQgd2Via2l0Zmxhc2tweQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>