<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>242685</bug_id>
          
          <creation_ts>2022-07-13 03:22:54 -0700</creation_ts>
          <short_desc>AX: Header elements inside main elements should not be banner landmarks</short_desc>
          <delta_ts>2024-01-18 16:27:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>Safari 15</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Derk-Jan Hartman">hartman.wiki</reporter>
          <assigned_to name="Joone Hur">joone</assigned_to>
          <cc>andresg_22</cc>
    
    <cc>jcraig</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1882962</commentid>
    <comment_count>0</comment_count>
    <who name="Derk-Jan Hartman">hartman.wiki</who>
    <bug_when>2022-07-13 03:22:54 -0700</bug_when>
    <thetext>Per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header
and https://www.w3.org/WAI/ARIA/apg/example-index/landmarks/HTML5.html

&lt;header&gt; should carry the banner landmark role, when in context of the body element. The header element is not a banner landmark when it is a descendant of the following HTML sectioning elements: article, aside, main, nav, section.

This is not currently how VoiceOver + Safari implements this. Any header element seems to generate a landmark banner role, irrespective of being positioned inside of article, aside, main, nav, section elements.

Interestingly this is correctly implemented for sections. As you can detect with the rotor and landmark navigation in the the included example, the header element inside of a main is presented as a landmark, yet the header inside of a section is NOT a banner landmark in the landmark navigation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1882963</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-07-13 03:23:05 -0700</bug_when>
    <thetext>&lt;rdar://problem/96942150&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1882965</commentid>
    <comment_count>2</comment_count>
      <attachid>460851</attachid>
    <who name="Derk-Jan Hartman">hartman.wiki</who>
    <bug_when>2022-07-13 03:23:57 -0700</bug_when>
    <thetext>Created attachment 460851
index.html with 3 header elements within different parents</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2003544</commentid>
    <comment_count>3</comment_count>
    <who name="Joone Hur">joone</who>
    <bug_when>2024-01-08 00:42:20 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/22499</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2003976</commentid>
    <comment_count>4</comment_count>
    <who name="Joone Hur">joone</who>
    <bug_when>2024-01-09 17:57:21 -0800</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=195010</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2005916</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-01-18 11:48:44 -0800</bug_when>
    <thetext>Committed 273188@main (da3bbf117740): &lt;https://commits.webkit.org/273188@main&gt;

Reviewed commits have been landed. Closing PR #22499 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2006006</commentid>
    <comment_count>6</comment_count>
    <who name="James Craig">jcraig</who>
    <bug_when>2024-01-18 16:27:16 -0800</bug_when>
    <thetext>See WPT review changes requested https://github.com/web-platform-tests/wpt/pull/44080#discussion_r1458126371</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>460851</attachid>
            <date>2022-07-13 03:23:57 -0700</date>
            <delta_ts>2022-07-13 03:23:57 -0700</delta_ts>
            <desc>index.html with 3 header elements within different parents</desc>
            <filename>header_banner.html</filename>
            <type>text/html</type>
            <size>471</size>
            <attacher name="Derk-Jan Hartman">hartman.wiki</attacher>
            
              <data encoding="base64">PGh0bWw+Cjxib2R5Pgo8aGVhZGVyPgpIZWFkZXIgZWxlbWVudCBvdXRzaWRlIG9mIGFydGljbGUs
IGFzaWRlLCBtYWluLCBuYXYsIHNlY3Rpb24sIHNob3VsZCBnZW5lcmF0ZSBhIGJhbm5lciBsYW5k
bWFyay4KPC9oZWFkZXI+CjxtYWluPgoKPGhlYWRlcj4KPGgxPiBUaXRsZSBvZiBvdXIgZnVsbCBk
b2N1bWVudCBzaG91bGQgbm90IGJlIGEgYmFubmVyIGxhbmRtYXJrIHNpbmNlIGl0IGlzIHdpdGhp
biBtYWluPC9oMT4KPC9oZWFkZXI+CkNvbnRlbnQgb2Ygb3VyIHBhZ2Ugd2l0aGluIGEgbWFpbgoK
PHNlY3Rpb24+CjxoZWFkZXI+CjxoMj4gVGl0bGUgb2Ygb3VyIGZ1bGwgZG9jdW1lbnQgc2hvdWxk
IG5vdCBiZSBhIGJhbm5lciBsYW5kbWFyayBzaW5jZSBpdCBpcyB3aXRoaW4gYSBzZWN0aW9uPC9o
Mj4KPC9oZWFkZXI+ClRoZSBzZWN0aW9uIG9mIG91ciBwYWdlCjwvc2VjdGlvbj4KCjwvbWFpbj4K
PC9ib2R5Pgo8L2h0bWw+
</data>

          </attachment>
      

    </bug>

</bugzilla>