242318 2022-07-04 12:30:51 -0700 git-webkit upload should amend the commit instead of making a new commit 2023-01-18 11:24:01 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=240607 InRadar P2 Normal --- 239082 1 rniwa webkit-unassigned ap jbedard webkit-bug-importer oldest_to_newest 1880569 0 rniwa 2022-07-04 12:30:51 -0700 git-webkit upload should amend the commit instead of trying to create a new commit in each invocation. Looks like this option exists but not enabled by default? --amend. 1880868 1 ap 2022-07-05 19:20:30 -0700 There isn't consensus on the right behavior yet - some people prefer additional changes to be separate commits to make reviewing easier. And then squash before landing. 1880879 2 rniwa 2022-07-05 20:29:34 -0700 (In reply to Alexey Proskuryakov from comment #1) > There isn't consensus on the right behavior yet - some people prefer > additional changes to be separate commits to make reviewing easier. And then > squash before landing. Maybe this should be configurable during setup? 1882094 3 webkit-bug-importer 2022-07-11 12:31:16 -0700 <rdar://problem/96837043> 1884613 4 rniwa 2022-07-16 21:34:08 -0700 So... apparently merge-queue can't land a PR unless all commits are squashed so the current behavior of git-webkit upload is incompatible with merge queue.