242185 2022-06-30 06:37:41 -0700 [web-animations] additive/accumulative color blending fails to yield intermediary out-of-bounds values 2022-09-26 01:10:18 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 235766 235768 235769 235770 189299 1 graouts sam dino graouts sam webkit-bug-importer oldest_to_newest 1879344 0 graouts 2022-06-30 06:37:41 -0700 We have 28 FAIL results across these WPTs all due to the same issue: - web-animations/animation-model/animation-types/accumulation-per-property-001.html - web-animations/animation-model/animation-types/accumulation-per-property-002.html - web-animations/animation-model/animation-types/addition-per-property-001.html - web-animations/animation-model/animation-types/addition-per-property-002.html These run this subtest from web-animations/animation-model/animation-types/property-types.js for `add` and `accumulate` composite operations for a variety of color CSS properties: test(t => { const idlName = propertyToIDL(property); const target = createTestElement(t, setup); target.style[idlName] = 'rgb(128, 128, 128)'; const animation = target.animate( { [idlName]: ['rgb(255, 0, 0)', 'rgb(0, 0, 255)'], }, { duration: 1000, composite } ); testAnimationSamples(animation, idlName, [{ time: 0, expected: 'rgb(255, 128, 128)' }, // The value at 50% is interpolated // from 'rgb(128+255, 128, 128)' // to 'rgb(128, 128, 128+255)'. { time: 500, expected: 'rgb(255, 128, 255)' }]); }, `${property} supports animating as color of rgb() with overflowed ` + ' from and to values'); The issue is that we always clamp values as we blend colors so we can't have the intermediary representations of rgb(128+255, 128, 128) and rgb(128, 128, 128+255) above for additive and accumulate. Note that when we blend using `add` or `accumulate`, it will only ever be through some intermediary calls to `CSSPropertyAnimation::blendProperties()` made under `KeyframeEffect::setAnimatedPropertiesInStyle()` which will not produce web-facing values. Only at the end of that method do we call `CSSPropertyAnimation::blendProperties()` with a `replace` composite operation which would be expected to clamp. 1879366 1 460581 graouts 2022-06-30 08:13:29 -0700 Created attachment 460581 Test 1881305 2 webkit-bug-importer 2022-07-07 06:38:12 -0700 <rdar://problem/96593559> 1900970 3 sam 2022-09-24 19:43:58 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4674 1901114 4 ews-feeder 2022-09-26 01:10:16 -0700 Committed 254850@main (35a0ba08385c): <https://commits.webkit.org/254850@main> Reviewed commits have been landed. Closing PR #4674 and removing active labels. 460581 2022-06-30 08:13:29 -0700 2022-06-30 08:13:29 -0700 Test additive-color-animation-out-of-bounds.html text/html 878 graouts PGJvZHk+CjxzY3JpcHQ+Cgpjb25zdCBkaXYgPSBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpKTsKCi8vIFNldCB0aGUgYmFzZSB2YWx1ZS4KZGl2 LnN0eWxlLmJhY2tncm91bmRDb2xvciA9ICJyZ2IoMTI4LCAxMjgsIDEyOCkiOwoKLy8gQ3JlYXRl IGFuIGFkZGl0aXZlIGFuaW1hdGlvbiBhbmQgcGF1c2UgaXQuCmNvbnN0IGR1cmF0aW9uID0gMTAw MDsKY29uc3Qga2V5ZnJhbWVzID0geyBiYWNrZ3JvdW5kQ29sb3I6IFsicmdiKDI1NSwgMCwgMCki LCAicmdiKDAsIDAsIDI1NSkiXSB9Owpjb25zdCBvcHRpb25zID0geyBkdXJhdGlvbiwgY29tcG9z aXRlOiAiYWRkIiB9Owpjb25zdCBhbmltYXRpb24gPSBkaXYuYW5pbWF0ZShrZXlmcmFtZXMsIG9w dGlvbnMpOwphbmltYXRpb24ucGF1c2UoKTsKCmNvbnN0IGFzc2VydFZhbHVlID0gKHByb2dyZXNz LCBleHBlY3RlZCkgPT4gewogICAgYW5pbWF0aW9uLmN1cnJlbnRUaW1lID0gZHVyYXRpb24gKiBw cm9ncmVzczsKICAgIGNvbnNvbGUuYXNzZXJ0KGdldENvbXB1dGVkU3R5bGUoZGl2KS5iYWNrZ3Jv dW5kQ29sb3IsIGV4cGVjdGVkLCBgVGhlIHZhbHVlIGF0ICR7cHJvZ3Jlc3MgKiAxMDB9JSBzaG91 bGQgYmUgIiR7ZXhwZWN0ZWR9ImApOwp9OwoKLy8gVGhlIHZhbHVlIGF0IDAlLgphc3NlcnRWYWx1 ZSgwLCAicmdiKDI1NSwgMTI4LCAxMjgpIik7CgovLyBUaGUgdmFsdWUgYXQgNTAlIGlzIGludGVy cG9sYXRlZAovLyBmcm9tICJyZ2IoMTI4KzI1NSwgMTI4LCAxMjgpIgovLyB0byAgICJyZ2IoMTI4 LCAgICAgMTI4LCAxMjgrMjU1KSIuCmFzc2VydFZhbHVlKDAuNSwgInJnYigyNTUsIDEyOCwgMjU1 KSIpOwoKPC9zY3JpcHQ+CjwvYm9keT4=