242002 2022-06-25 08:25:40 -0700 preventSilentAccess throws NotSupportedError 2023-05-22 12:37:24 -0700 1 1 1 Unclassified WebKit New Bugs Safari 15 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181082 InRadar P2 Normal --- 1 lwarlow webkit-unassigned bfulgham pascoe rmondello webkit-bug-importer wilander oldest_to_newest 1878363 0 lwarlow 2022-06-25 08:25:40 -0700 Safari has "implemented" the `preventSilentAccess` function from the Credential Management API (https://w3c.github.io/webappsec-credential-management/#dom-credentialscontainer-preventsilentaccess). However, it unconditionally throws a NotSupportedError whenever it's called. This happens on both macOS and iOS from my testing. The specification doesn't mention this as an expected behaviour and I was surprised to see that the function is implemented but also not implemented, meaning my feature detection looking for the existence of the function fails. The below code can be pasted into Web Inspector on a secure domain to demonstrate the issue. Both Chromium and Firefox work correctly but Safari fails. if (navigator.credentials.preventSilentAccess) { console.log('preventSilentAccess is implemented'); navigator.credentials.preventSilentAccess() .then(() => { console.log('preventSilentAccess succeeded'); }) .catch((err) => { console.log('preventSilentAccess failed'); console.error(err); }); } else { console.log('preventSilentAccess is NOT implemented'); } 1878619 1 webkit-bug-importer 2022-06-27 16:32:07 -0700 <rdar://problem/96020741> 1878622 2 ap 2022-06-27 16:35:51 -0700 This is definitely how it is implemented indeed. It's been a long time since this code was added, and I couldn't find any explanation of why it was done this way. void CredentialsContainer::preventSilentAccess(DOMPromiseDeferred<void>&& promise) const { promise.reject(Exception { NotSupportedError, "Not implemented."_s }); } 1940085 3 lwarlow 2023-03-09 09:02:15 -0800 Pull request: https://github.com/WebKit/WebKit/pull/11303 1957061 4 ews-feeder 2023-05-22 12:37:22 -0700 Committed 264345@main (40294715d0c0): <https://commits.webkit.org/264345@main> Reviewed commits have been landed. Closing PR #11303 and removing active labels.