<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>241763</bug_id>
          
          <creation_ts>2022-06-19 14:44:43 -0700</creation_ts>
          <short_desc>git-webkit pr sometimes produces unexpected results when merging titles of multiple commits</short_desc>
          <delta_ts>2022-06-26 14:45:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=241762</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>239082</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Nikolas Zimmermann">zimmermann</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1876674</commentid>
    <comment_count>0</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2022-06-19 14:44:43 -0700</bug_when>
    <thetext>I named a bug report &quot;[LBSE] Add &apos;viewBox&apos; support&quot; (webkit.org/b/241762) and used git-webkit pr to create a PR, which was only named &quot;[LBSE] Add &apos;&quot; (https://github.com/WebKit/WebKit/pull/1622).

There&apos;s a bug related to hyphens, I&apos;ll move on and fix the PR name but this might be relevant for others, so I&apos;ll open a ticket.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1876835</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-06-20 12:04:23 -0700</bug_when>
    <thetext>I think that you meant apostrophe, not hyphen - is that right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1876960</commentid>
    <comment_count>2</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-06-21 08:21:08 -0700</bug_when>
    <thetext>This isn&apos;t about hyphens or apostrophes, it&apos;s about multiple commits in a PR. git-webkit is trying to craft a title that applies to all the commits in the PR (unsuccessfully, in this case). Basically, all those commits share &quot;[LBSE] Add&quot;, so that&apos;s what we&apos;re titling the PR.

We can definitely improve how we name multi-commit PRs, although it&apos;s not obvious exactly what the title of a multi-commit PR should be, especially when commits have as diverse headers as the commits in this PR.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1878426</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-06-26 14:45:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/95941403&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>