<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>241760</bug_id>
          
          <creation_ts>2022-06-19 13:37:19 -0700</creation_ts>
          <short_desc>prepare-commit-msg includes unstaged changes</short_desc>
          <delta_ts>2022-09-07 20:37:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>239082</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Woodrow">mattwoodrow</reporter>
          <assigned_to name="Matt Woodrow">mattwoodrow</assigned_to>
          <cc>ap</cc>
    
    <cc>graouts</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1876667</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2022-06-19 13:37:19 -0700</bug_when>
    <thetext>Creating a commit with some changes unstaged still results in those changes being included in the generated commit message.

I think we need to pass `--git-index` to `prepare-ChangeLog` in order to only create a commit message template from the staged files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1878424</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-06-26 13:38:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/95940276&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1878644</commentid>
    <comment_count>2</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2022-06-27 18:17:41 -0700</bug_when>
    <thetext>Somewhat relatedly, when using `git commit --amend` to edit a commit, the provided list of changed files (as # lines) only contains the newly modified files.

For my usage, it&apos;d probably be easier if it just gave the full set of changes, so that I can replace the set in the existing commit message as a whole, rather than merging in line-by-line. I guess providing both would be the best of both worlds?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1886954</commentid>
    <comment_count>3</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2022-07-26 18:00:42 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/2764</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1896961</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-07 20:37:26 -0700</bug_when>
    <thetext>Committed 254260@main (b4f3e7d2afaf): &lt;https://commits.webkit.org/254260@main&gt;

Reviewed commits have been landed. Closing PR #2764 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>