241635 2022-06-15 09:04:36 -0700 [GitHub] Style checker should be able to comment on the diff 2024-11-25 07:39:19 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified NEW InRadar P2 Normal --- 239082 1 keith_miller jbedard aakash_jain ap bfan2 webkit-bug-importer oldest_to_newest 1876024 0 keith_miller 2022-06-15 09:04:36 -0700 Right now there is the merge (not sure exactly what the name is) check for style. But reviewers still need to click on the details page to see if any are relevant. It could be useful to provide a button next to the details link that will have the style checker comment on the lines it thinks have issues. We may not want this all the time because it could become quite noisy, which happened back in the day on bugzilla. Thus, a button or some other user initiated trigger would be my recommendation. 1877299 1 webkit-bug-importer 2022-06-22 09:05:13 -0700 <rdar://problem/95695974> 2077550 2 gsnedders 2024-11-25 07:39:19 -0800 Potentially we'd could create a check run and then we could actually leave annotations (which appear similar to review comments) for style check failures. However, that requires us to be using a GitHub App to interact with GitHub, which I don't believe we do currently? See: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#:~:text=annotations,-array%20of%20objects If we're concerned about noisiness, we could either require a button to be clicked in the GitHub check UI, or add some sort of bot command in a comment on the PR. That said, https://ews-build.webkit.org/#/builders/38 does look like it passes on the overwhelming majority of EWS runs.