241535 2022-06-11 21:32:12 -0700 [Filters] LightSource should keep its points in <length-percentage> units 2022-06-12 21:27:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 231253 232842 1 sabouhallawa sabouhallawa bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1875416 0 460186 sabouhallawa 2022-06-11 21:32:12 -0700 Created attachment 460186 fePointLight test case Open the attached test cases. Expected: A green circle and green ellipse should be drawn. The problem is PointLightSource and SpotLightSource are created with points in user space coordinates. See SVGFEPointLightElement::lightSource() and SVGFESpotLightElement::lightSource(). But this requires knowing the filter targetBoundingBox and the primitiveUnits. When dynamically updating these points through SVGFEDiffuseLightingElement::setFilterEffectAttribute() or SVGFESpecularLightingElement::setFilterEffectAttribute() the filter is not available and these points are set in logical coordinates. This means these points will have values between -1 and 1 in user space coordinates. This is why the green circle and ellipse are not shown in the test cases. The fix is to make LightSource store their points in logical coordinates and to resolve them to user space coordinates in initPaintingData(). 1875417 1 460187 sabouhallawa 2022-06-11 21:33:49 -0700 Created attachment 460187 feSpotLight test case 1875418 2 sabouhallawa 2022-06-11 21:38:33 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1462 1875470 3 sabouhallawa 2022-06-12 20:08:13 -0700 See https://drafts.csswg.org/css-values-4/#typedef-length-percentage for the definition of <length-percentage>. 1875472 4 webkit-bug-importer 2022-06-12 20:24:23 -0700 <rdar://problem/94973414> 1875474 5 ews-feeder 2022-06-12 21:27:41 -0700 Committed r295481 (251486@main): <https://commits.webkit.org/251486@main> Reviewed commits have been landed. Closing PR #1462 and removing active labels. 460186 2022-06-11 21:32:12 -0700 2022-06-11 21:34:02 -0700 fePointLight test case feSpecularLighting-fePointLight-dynamic-update.svg image/svg+xml 1205 sabouhallawa PHN2ZyB3aWR0aD0iNTAwcHgiIGhlaWdodD0iNTgwcHgiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9y Zy8yMDAwL3N2ZyI+CjxkZWZzPgogICAgPGZpbHRlciBpZD0iZmlsdGVyIiBmaWx0ZXJVbml0cz0i b2JqZWN0Qm91bmRpbmdCb3giIHByaW1pdGl2ZVVuaXRzPSJvYmplY3RCb3VuZGluZ0JveCI+CiAg ICAgICAgPGZlRmxvb2QvPgogICAgICAgIDxmZVNwZWN1bGFyTGlnaHRpbmcgc3VyZmFjZVNjYWxl PSIxMCIgc3BlY3VsYXJFeHBvbmVudD0iMTAiIHNwZWN1bGFyQ29uc3RhbnQ9IjIiIGxpZ2h0aW5n LWNvbG9yPSJyZ2IoMCwgMjU1LCAwKSI+CiAgICAgICAgICAgIDxmZVBvaW50TGlnaHQgaWQ9Imxp Z2h0LXNvdXJjZSIvPgogICAgICAgIDwvZmVTcGVjdWxhckxpZ2h0aW5nPgogICAgICAgIDxmZUNv bXBvbmVudFRyYW5zZmVyPgogICAgICAgICAgICA8ZmVGdW5jRyB0eXBlPSJkaXNjcmV0ZSIgdGFi bGVWYWx1ZXM9IjAgMSIvPgogICAgICAgICAgICA8ZmVGdW5jQSB0eXBlPSJkaXNjcmV0ZSIgdGFi bGVWYWx1ZXM9IjAgMSIvPgogICAgICAgIDwvZmVDb21wb25lbnRUcmFuc2Zlcj4KICAgIDwvZmls dGVyPgo8L2RlZnM+CjxyZWN0IHg9IjExMCIgeT0iMTUwIiB3aWR0aD0iNDAwIiBoZWlnaHQ9IjMy MCIgZmlsbD0ibm9uZSIgZmlsdGVyPSJ1cmwoI2ZpbHRlcikiLz4KPCEtLSBNYXNrIG9mZiBzbGln aHQgZGlmZmVyZW5jZXMgaW4gcG9pbnQgbGlnaHQgcmFkaXVzIC0tPgo8Y2lyY2xlIGN4PSIyNTAi IGN5PSIzMTAiIHI9IjExMiIgZmlsbD0ibm9uZSIgc3Ryb2tlPSJncmF5IiBzdHJva2Utd2lkdGg9 IjIwIi8+CjxzY3JpcHQ+CiAgICAvLyBNYWtlIHN1cmUgdGhlIGZpbHRlciBpcyBkcmF3biBhdCBs ZWFzdCBvbmNlIGJlZm9yZSBjaGFuZ2luZyB0aGUgbGlnaHQgc291cmNlLgogICAgcmVxdWVzdEFu aW1hdGlvbkZyYW1lKCgpID0+IHsKICAgICAgICByZXF1ZXN0QW5pbWF0aW9uRnJhbWUoKCkgPT4g ewogICAgICAgICAgICBjb25zdCBsaWdodFNvdXJjZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdsaWdodC1zb3VyY2UnKTsKICAgICAgICAgICAgbGlnaHRTb3VyY2UueC5iYXNlVmFsID0gMC4z NTsKICAgICAgICAgICAgbGlnaHRTb3VyY2UueS5iYXNlVmFsID0gMC41OwogICAgICAgICAgICBs aWdodFNvdXJjZS56LmJhc2VWYWwgPSAwLjI7CiAgICAgICAgfSk7CiAgICB9KTsKPC9zY3JpcHQ+ Cjwvc3ZnPgo= 460187 2022-06-11 21:33:49 -0700 2022-06-11 21:33:49 -0700 feSpotLight test case feDiffuseLighting-feSpotLight-dynamic-update.svg image/svg+xml 1372 sabouhallawa PHN2ZyB3aWR0aD0iNTAwcHgiIGhlaWdodD0iNjEwcHgiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9y Zy8yMDAwL3N2ZyI+CjxkZWZzPgogICAgPGZpbHRlciBpZD0iZmlsdGVyIiBmaWx0ZXJVbml0cz0i b2JqZWN0Qm91bmRpbmdCb3giIHByaW1pdGl2ZVVuaXRzPSJvYmplY3RCb3VuZGluZ0JveCI+CiAg ICAgICAgPGZlRmxvb2QvPgogICAgICAgIDxmZURpZmZ1c2VMaWdodGluZyBsaWdodGluZy1jb2xv cj0icmdiKDAsIDI1NSwgMCkiIHg9Ii0wLjEiIHk9Ii0wLjE2Ij4KICAgICAgICAgICAgPGZlU3Bv dExpZ2h0IGlkPSJsaWdodC1zb3VyY2UiIGxpbWl0aW5nQ29uZUFuZ2xlPSIxMiIgLz4KICAgICAg ICA8L2ZlRGlmZnVzZUxpZ2h0aW5nPgogICAgICAgIDxmZUNvbXBvbmVudFRyYW5zZmVyPgogICAg ICAgICAgICA8ZmVGdW5jRyB0eXBlPSJkaXNjcmV0ZSIgdGFibGVWYWx1ZXM9IjAgMSIvPgogICAg ICAgIDwvZmVDb21wb25lbnRUcmFuc2Zlcj4KICAgIDwvZmlsdGVyPgo8L2RlZnM+CjxyZWN0IHg9 IjExMCIgeT0iMTUwIiB3aWR0aD0iNDAwIiBoZWlnaHQ9IjMyMCIgZmlsbD0ibm9uZSIgZmlsdGVy PSJ1cmwoI2ZpbHRlcikiLz4KPCEtLSBNYXNrIG9mZiBzbGlnaHQgZGlmZmVyZW5jZXMgaW4gcG9p bnQgbGlnaHQgcmFkaXVzIC0tPgo8ZWxsaXBzZSBjeD0iMjk4IiBjeT0iMzI4IiByeD0iMTUyIiBy eT0iMTE3IiBmaWxsPSJub25lIiBzdHJva2U9ImdyYXkiIHN0cm9rZS13aWR0aD0iMjAiIHN0eWxl PSJ0cmFuc2Zvcm06IHJvdGF0ZSg0OGRlZyk7IHRyYW5zZm9ybS1vcmlnaW46IDUwJSA1MCU7IHRy YW5zZm9ybS1ib3g6IGZpbGwtYm94OyIvPgo8c2NyaXB0PgogICAgLy8gTWFrZSBzdXJlIHRoZSBm aWx0ZXIgaXMgZHJhd24gYXQgbGVhc3Qgb25jZSBiZWZvcmUgY2hhbmdpbmcgdGhlIGxpZ2h0IHNv dXJjZS4KICAgIHJlcXVlc3RBbmltYXRpb25GcmFtZSgoKSA9PiB7CiAgICAgICAgcmVxdWVzdEFu aW1hdGlvbkZyYW1lKCgpID0+IHsKICAgICAgICAgICAgY29uc3QgbGlnaHRTb3VyY2UgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnbGlnaHQtc291cmNlJyk7CiAgICAgICAgICAgIGxpZ2h0U291 cmNlLnguYmFzZVZhbCA9IC0wLjQ7CiAgICAgICAgICAgIGxpZ2h0U291cmNlLnkuYmFzZVZhbCA9 IC0wLjY7CiAgICAgICAgICAgIGxpZ2h0U291cmNlLnouYmFzZVZhbCA9IDEuNzsKICAgICAgICAg ICAgbGlnaHRTb3VyY2UucG9pbnRzQXRYLmJhc2VWYWwgPSAwLjI7CiAgICAgICAgICAgIGxpZ2h0 U291cmNlLnBvaW50c0F0WS5iYXNlVmFsID0gMC4yOwogICAgICAgICAgICBsaWdodFNvdXJjZS5w b2ludHNBdFouYmFzZVZhbCA9IDAuNTsKICAgICAgICB9KTsKICAgIH0pOwo8L3NjcmlwdD4KPC9z dmc+Cg==