<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>241489</bug_id>
          
          <creation_ts>2022-06-09 14:00:32 -0700</creation_ts>
          <short_desc>Track SVG renderer updates using a NodeFlag instead of on Style::Update</short_desc>
          <delta_ts>2022-06-14 15:00:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=230296</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=240112</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Cameron McCormack (:heycam)">heycam</reporter>
          <assigned_to name="Cameron McCormack (:heycam)">heycam</assigned_to>
          <cc>sabouhallawa</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1875104</commentid>
    <comment_count>0</comment_count>
    <who name="Cameron McCormack (:heycam)">heycam</who>
    <bug_when>2022-06-09 14:00:32 -0700</bug_when>
    <thetext>SVG renderer updates are currently tracked as a kind of Style::Update change.  When a page is updating attributes on many SVG elements, but is not making changes that require a restyle on those elements, we can spend a lot of time hashing to store and look up the Style::Update associated with an element.

We could track the &quot;SVG renderer update is needed&quot; state using a Node flag instead, but continue using the Style::Update mechanism for root tracking, to reduce the overhead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875105</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-06-09 14:00:54 -0700</bug_when>
    <thetext>&lt;rdar://problem/94756741&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875106</commentid>
    <comment_count>2</comment_count>
    <who name="Cameron McCormack (:heycam)">heycam</who>
    <bug_when>2022-06-09 14:20:24 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1430</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875698</commentid>
    <comment_count>3</comment_count>
    <who name="Cameron McCormack (:heycam)">heycam</who>
    <bug_when>2022-06-13 22:01:30 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1492</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875699</commentid>
    <comment_count>4</comment_count>
    <who name="Cameron McCormack (:heycam)">heycam</who>
    <bug_when>2022-06-13 22:04:38 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1493</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875877</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-06-14 15:00:42 -0700</bug_when>
    <thetext>Committed r295539 (251544@main): &lt;https://commits.webkit.org/251544@main&gt;

Reviewed commits have been landed. Closing PR #1430 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>