241115 2022-05-30 18:52:06 -0700 Commit message not showing up in patch review for some patches 2022-06-06 19:14:42 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 239082 1 ap webkit-unassigned fujii jbedard webkit-bug-importer oldest_to_newest 1872857 0 ap 2022-05-30 18:52:06 -0700 Commit message is not visible in https://bugs.webkit.org/attachment.cgi?id=459876&action=review, although it's present and looks normal in the raw patch, https://bug-241114-attachments.webkit.org/attachment.cgi?id=459876 1872885 1 459877 fujii 2022-05-30 21:26:21 -0700 Created attachment 459877 WIP patch 1872886 2 fujii 2022-05-30 21:28:50 -0700 I'm not able to find out a good way to decode MIME header with Ruby standard library. Subject: =?UTF-8?q?webkit-patch:=20`git=20am`=20strips=20prefixes=20(e.g.?= =?UTF-8?q?=20[CMake][WPE])=20in=20a=20subject=0Ahttps://bugs.webkit.org/s?= =?UTF-8?q?how=5Fbug.cgi=3Fid=3D241114?= 1872888 3 fujii 2022-05-30 21:35:42 -0700 `git mailinfo` command can decode the subject. But I don't know git command is available on the Bugzilla server. 1872899 4 ap 2022-05-30 23:11:34 -0700 Running external commands with untrusted content on the server would be icky. I don't know how all this works though, maybe we already do? 1874414 5 webkit-bug-importer 2022-06-06 18:53:12 -0700 <rdar://problem/94480379> 1874419 6 fujii 2022-06-06 19:14:42 -0700 Bug 241114 was fixed by using --keep-non-patch option rather than --keep option. We don't need to fix this problem. Closed. 459877 2022-05-30 21:26:21 -0700 2022-05-30 21:26:21 -0700 WIP patch wip.patch text/plain 1397 fujii ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQ YXRjaC5yYiBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRj aC5yYgppbmRleCBjMjQ5NTNmNDU5M2EuLmJlZTdiYzY1Zjg4YiAxMDA2NDQKLS0tIGEvV2Vic2l0 ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCisrKyBiL1dlYnNp dGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgpAQCAtNjgsNyAr NjgsNyBAQCBwcml2YXRlCiAgICAgXQogCiAgICAgTUVTU0FHRV9IRUFERVJfRk9STUFUUyA9IFsK LSAgICAgICAgL15TdWJqZWN0OiBcW1BBVENIID8oXGQrXC9cZCspP1xdICguKykvCisgICAgICAg IC9eU3ViamVjdDogKFxbUEFUQ0ggPyhcZCtcL1xkKyk/XF0gKT8oLispLwogICAgIF0KIAogICAg IEJVR19VUkxfUkUgPSAvIChOZWVkIHRoZSBidWcgVVJMIFwoT09QUyFcKS4pfChcUys6XC9cL1xT KykvCkBAIC04MTQsMTEgKzgxNCwxMSBAQCBFT0YKICAgICAgICAgICAgICAgICAgICAgY29tbWl0 TWVzc2FnZUxlbmd0aCA9IDEKICAgICAgICAgICAgICAgICAgICAgbGluZXNGb3JEaWZmcyA8PCBb XQogICAgICAgICAgICAgICAgICAgICBsaW5lc0ZvckRpZmZzLmxhc3QgPDwgJysrKyBDT01NSVRf TUVTU0FHRScKLSAgICAgICAgICAgICAgICAgICAgaWYgbGluZVtNRVNTQUdFX0hFQURFUl9GT1JN QVRTWzBdLCAxXQotICAgICAgICAgICAgICAgICAgICAgICAgbGluZXNGb3JEaWZmcy5sYXN0Wy0x XSArPSAnICgnICsgbGluZVtNRVNTQUdFX0hFQURFUl9GT1JNQVRTWzBdLCAxXSArICcpJworICAg ICAgICAgICAgICAgICAgICBpZiBsaW5lW01FU1NBR0VfSEVBREVSX0ZPUk1BVFNbMF0sIDJdCisg ICAgICAgICAgICAgICAgICAgICAgICBsaW5lc0ZvckRpZmZzLmxhc3RbLTFdICs9ICcgKCcgKyBs aW5lW01FU1NBR0VfSEVBREVSX0ZPUk1BVFNbMF0sIDJdICsgJyknCiAgICAgICAgICAgICAgICAg ICAgIGVuZAogICAgICAgICAgICAgICAgICAgICBsaW5lc0ZvckRpZmZzLmxhc3QgPDwgJ0BAIC0w LDAgKzEsMSBAQCcKLSAgICAgICAgICAgICAgICAgICAgc3ViamVjdCA9IGxpbmVbTUVTU0FHRV9I RUFERVJfRk9STUFUU1swXSwgMl0KKyAgICAgICAgICAgICAgICAgICAgc3ViamVjdCA9IGxpbmVb TUVTU0FHRV9IRUFERVJfRk9STUFUU1swXSwgM10KICAgICAgICAgICAgICAgICBlbHNpZiAoIXN1 YmplY3QuZW1wdHk/ICYmIGxpbmUuc3RyaXAuZW1wdHk/KQogICAgICAgICAgICAgICAgICAgICBz dWJqZWN0LnNwbGl0KEJVR19VUkxfUkUpLmVhY2ggeyB8bXRjaHwKICAgICAgICAgICAgICAgICAg ICAgICAgIGlmICFtdGNoLnN0cmlwLmVtcHR5Pwo=