<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>240874</bug_id>
          
          <creation_ts>2022-05-24 08:25:51 -0700</creation_ts>
          <short_desc>Incorrect text set on PR description with multiple commits</short_desc>
          <delta_ts>2023-09-15 11:43:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>239082</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jean-Yves Avenard [:jya]">jean-yves.avenard</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>ntim</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1871500</commentid>
    <comment_count>0</comment_count>
    <who name="Jean-Yves Avenard [:jya]">jean-yves.avenard</who>
    <bug_when>2022-05-24 08:25:51 -0700</bug_when>
    <thetext>I pushed a PR with 3 commits for review:

They are titled

https://github.com/WebKit/WebKit/pull/968
P1. Rework SharedBufferCopy so that we can keep a reference to the underlying SharedMemory
P2. Remove SharedBufferCopy::safeBuffer() and rename SharedBufferCopy::buffer with SharedBufferCopy::unsafeBuffer.
P3. Rename SharedBufferCopy to SharedBufferReference

When pushed, the title of the PR becomes:
&quot;P.&quot;

To add: Ideally it would be great if there was a &quot;-m DESCRIPTION, --description=DESCRIPTION&quot; like there was with webkit-patch
as the description can&apos;t always be the same as the patch on top of the stack.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1871501</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-05-24 08:26:23 -0700</bug_when>
    <thetext>&lt;rdar://problem/93833985&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1871555</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-05-24 13:22:02 -0700</bug_when>
    <thetext>*** Bug 240873 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977727</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2023-09-15 11:42:28 -0700</bug_when>
    <thetext>This isn&apos;t really about the `P1/P2/P3`, it&apos;s just a problem about how we determine commit title when there are multiple commits. We&apos;re attempting to find the &quot;common string&quot; that all commits share in common.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977729</commentid>
    <comment_count>4</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2023-09-15 11:42:46 -0700</bug_when>
    <thetext>*** Bug 244116 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>