240701 2022-05-19 20:49:01 -0700 "No new tests (OOPS!)." is ending up in the middle of commit messages 2022-07-01 14:43:32 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED DUPLICATE 239665 https://bugs.webkit.org/show_bug.cgi?id=240585 https://bugs.webkit.org/show_bug.cgi?id=239665 InRadar P2 Normal --- 239082 1 simon.fraser webkit-unassigned cdumez simon.fraser webkit-bug-importer oldest_to_newest 1870622 0 simon.fraser 2022-05-19 20:49:01 -0700 The pre-filled commit message for https://github.com/WebKit/WebKit/pull/814 ended up like: 5dd145e ASSERT(status == U_ZERO_ERROR) under SearchBuffer::search() when typing in the url bar in the iOS simulator https://bugs.webkit.org/show_bug.cgi?id=240699 <rdar://92182174> Reviewed by NOBODY (OOPS!). Replace `status == U_ZERO_ERROR` tests with `U_SUCCESS(status)`. * Source/WebCore/PAL/pal/text/TextCodecICU.cpp: (PAL::ErrorCallbackSetter::ErrorCallbackSetter): (PAL::ErrorCallbackSetter::~ErrorCallbackSetter): * Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm: (WebKit::SpoofChecker::checker): No new tests (OOPS!). * Source/WebCore/editing/TextIterator.cpp: (WebCore::createSearcher): (WebCore::SearchBuffer::SearchBuffer): (WebCore::SearchBuffer::~SearchBuffer): (WebCore::SearchBuffer::search): Note "No new tests (OOPS!)." in the middle which I totally missed. 1872258 1 webkit-bug-importer 2022-05-26 20:49:13 -0700 <rdar://problem/94013879> 1880154 2 ryanhaddad 2022-07-01 14:42:35 -0700 *** Bug 239665 has been marked as a duplicate of this bug. *** 1880156 3 ryanhaddad 2022-07-01 14:43:32 -0700 Duped the wrong way, sorry! *** This bug has been marked as a duplicate of bug 239665 ***