<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>240637</bug_id>
          
          <creation_ts>2022-05-19 02:53:19 -0700</creation_ts>
          <short_desc>[Linux] GBMBufferSwapchain should only conditionally create linear-formatted buffer objects</short_desc>
          <delta_ts>2022-05-25 10:24:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>237649</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Zan Dobersek (Reviews)">zdobersek</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1870316</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2022-05-19 02:53:19 -0700</bug_when>
    <thetext>Right now, every gbm_bo object created in GBMBufferSwapchain is created in linear format. This shouldn&apos;t be the case, giving the graphics driver chance to choose the best possible attributes for the buffer object (e.g. most optimal tiling approach).

Currently, linearity is required only in media playback, when falling back onto software decoder, results of which are then copied into the spawned gbm_bo object. In most other cases avoiding linearity might be beneficial, so it should be done.

This will most likely be solved by passing the GBMBufferSwapchain constructor or getBuffer() call some specific flags requesting a linear buffer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1871718</commentid>
    <comment_count>1</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2022-05-25 07:23:34 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1008</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1871759</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-05-25 10:23:50 -0700</bug_when>
    <thetext>Committed r294803 (250959@main): &lt;https://commits.webkit.org/250959@main&gt;

Reviewed commits have been landed. Closing PR #1008 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1871760</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-05-25 10:24:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/93911506&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>