<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>240529</bug_id>
          
          <creation_ts>2022-05-17 11:06:00 -0700</creation_ts>
          <short_desc>git webkit setup ignores configured editor</short_desc>
          <delta_ts>2022-05-19 10:08:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>239082</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1869742</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-05-17 11:06:00 -0700</bug_when>
    <thetext>I chose default when running git webkit setup, and I have this in my environment:

export SVN_EDITOR=commit-log-editor
export SVN_LOG_EDITOR=&quot;/usr/local/bin/bbedit --view-top --wait --resume&quot;

And yet I&apos;m getting vi invoked for writing the commit message. I would expect my environment to be respected for &quot;default&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1870115</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-05-18 13:07:46 -0700</bug_when>
    <thetext>&lt;rdar://problem/93521972&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1870211</commentid>
    <comment_count>2</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-05-18 16:58:26 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/757</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1870221</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-05-18 17:05:52 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/758</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1870371</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-05-19 07:56:14 -0700</bug_when>
    <thetext>Committed r294480 (250739@main): &lt;https://commits.webkit.org/250739@main&gt;

Reviewed commits have been landed. Closing PR #757 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1870430</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-05-19 10:08:14 -0700</bug_when>
    <thetext>Committed r294489 (250748@main): &lt;https://commits.webkit.org/250748@main&gt;

Reviewed commits have been landed. Closing PR #758 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>