239805 2022-04-27 00:20:05 -0700 [GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref' 2022-04-28 20:18:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=239482 https://bugs.webkit.org/show_bug.cgi?id=239881 InRadar P2 Normal --- 1 dpino dpino benjamin bugs-noreply cdumez cmarcelo ews-watchlist webkit-bug-importer zdobersek oldest_to_newest 1864741 0 dpino 2022-04-27 00:20:05 -0700 [GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref' 1864742 1 458424 dpino 2022-04-27 00:22:17 -0700 Created attachment 458424 Patch 1864743 2 dpino 2022-04-27 00:25:58 -0700 Because of this bug Ubuntu 20.04 build bot is failing: https://build.webkit.org/#/builders/30/builds/442/steps/9/logs/stdio 1864774 3 ews-feeder 2022-04-27 05:01:09 -0700 Committed r293505 (250036@main): <https://commits.webkit.org/250036@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458424. 1864775 4 webkit-bug-importer 2022-04-27 05:02:13 -0700 <rdar://problem/92391267> 1865326 5 458424 ap 2022-04-28 20:11:28 -0700 Comment on attachment 458424 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458424&action=review > Source/WTF/wtf/StdLibExtras.h:608 > +// TODO: Needed for GCC<=9.3. Remove it after Ubuntu 20.04 end of support (May 2023). Please use FIXME, not TODO: https://webkit.org/code-style-guidelines/ 1865329 6 dpino 2022-04-28 20:18:36 -0700 This patch broke Debian 10 build bot since __cplusplus value is 201709L for GCC8.3. https://build.webkit.org/#/builders/46/builds/13047/steps/8/logs/stdio Follow-up in https://bugs.webkit.org/show_bug.cgi?id=239881 458424 2022-04-27 00:22:17 -0700 2022-04-27 05:01:11 -0700 Patch bug-239805-20220427152216.patch text/plain 2030 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRhMjFhYjkzZTYyMDczYWRhNmQyNjEz YjZhMmE3NmY4NDRmYzEzMzguLmUzZTQ1ZmYyODIxOTRkMDBkOWQwN2FhYTdmMTAyZWYxOGYxMDE0 OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjItMDQtMjcgIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR0NDXSBHQ0M5LjMgZGVmaW5lcyAncmVtb3Zl X2N2cmVmX3QnIGJ1dCBub3QgJ19fY3BwX2xpYl9yZW1vdmVfY3ZyZWYnCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk4MDUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHQ0M5LjMgZGVmaW5lcyAncmVtb3Zl X2N2cmVmX3QnIGJ1dCBub3QgJ19fY3BwX2xpYl9yZW1vdmVfY3ZyZWYnLiBUaGUKKyAgICAgICAg bGF0dGVyIHdhcyBpbnRyb2R1Y2VkIGluIEdDQzkuNDoKKyAgICAgICAgCisgICAgICAgICAgaHR0 cHM6Ly9naXRodWIuY29tL2djYy1taXJyb3IvZ2NjL2Jsb2IvcmVsZWFzZXMvZ2NjLTkuNC4wL2xp YnN0ZGMlMkIlMkItdjMvaW5jbHVkZS9zdGQvdHlwZV90cmFpdHMjTDMwMjQKKyAgICAgICAgCisg ICAgICAgIFRoZSBmbGFnICdfX2NwcF9saWJfcmVtb3ZlX2N2cmVmJyBpcyB1c2VkIHRvIGNoZWNr IHdoZXRoZXIgJ3JlbW92ZV9jdnJlZl90JworICAgICAgICBpcyBkZWZpbmVkLCBidXQgaXQncyBu b3QgcG9zaWJsZSB0byByZWx5IG9uIGl0IGZvciBHQ0M5LjMgYXMgZXhwbGFpbmVkIG9uIHRoZQor ICAgICAgICBwYXJhZ3JhcGggYWJvdmUuCisgICAgICAgIAorICAgICAgICBJbnN0ZWFkIHdlIGNo ZWNrIHdoZXRoZXIgX19jcGx1c3BsdXMgaXMgPD0gMjAxNzAzTCBzaW5jZSB0aGUgR0NDIGNvbW1p dAorICAgICAgICB0aGF0IGRlZmluZWQgJ3JlbW92ZV9jdnJlZl90JyBkb2VzIGl0IGlmIF9fY3Bs dXNwbHVzID4gMjAxNzAzTC4gU2VlOgorICAgICAgICAKKyAgICAgICAgICBodHRwczovL2dpdGh1 Yi5jb20vZ2NjLW1pcnJvci9nY2MvY29tbWl0LzY3OTE0ODllZTUyMTRiMDE4MWFhMjJhZGMyNTBj YmJkZTE4OTdhNWMKKworICAgICAgICAqIHd0Zi9TdGRMaWJFeHRyYXMuaDoKKwogMjAyMi0wNC0y NiAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBS ZW1vdmUgQXJpYVJlZmxlY3Rpb25FbmFibGVkIHJ1bnRpbWUgZmxhZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMu aAppbmRleCA5MjEzZmY2NjNiNTg4ODIzMmI1ODYwOTdlMDUwZWIyYjk3OWE5NmY0Li42MTgwMWEw YmFkNThjYzU5YWVmMTc0NWQ4MzEyZTIyYTk5NzNlODdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9TdGRMaWJFeHRyYXMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaApA QCAtNjA1LDcgKzYwNSw4IEBAIHRlbXBsYXRlPHR5cGVuYW1lIE9wdGlvbmFsVHlwZT4gYXV0byB2 YWx1ZU9yRGVmYXVsdChPcHRpb25hbFR5cGUmJiBvcHRpb25hbFZhbHVlCiAKICNkZWZpbmUgV1RG TW92ZSh2YWx1ZSkgc3RkOjptb3ZlPFdURjo6Q2hlY2tNb3ZlUGFyYW1ldGVyPih2YWx1ZSkKIAot I2lmIGRlZmluZWQoX19HTElCQ1hYX18pICYmICFkZWZpbmVkKF9fY3BwX2xpYl9yZW1vdmVfY3Zy ZWYpCisvLyBUT0RPOiBOZWVkZWQgZm9yIEdDQzw9OS4zLiBSZW1vdmUgaXQgYWZ0ZXIgVWJ1bnR1 IDIwLjA0IGVuZCBvZiBzdXBwb3J0IChNYXkgMjAyMykuCisjaWYgZGVmaW5lZChfX0dMSUJDWFhf XykgJiYgX19jcGx1c3BsdXMgPD0gMjAxNzAzTAogbmFtZXNwYWNlIHN0ZCB7CiB0ZW1wbGF0ZSA8 dHlwZW5hbWUgVD4KIHN0cnVjdCByZW1vdmVfY3ZyZWYgewo=