23963 2009-02-14 22:02:41 -0800 [LegacySVG] Margin collapsing should not occur at the foreignObject boundary 2025-12-23 18:44:13 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=245908 InRadar P2 Normal --- 1 simon.fraser ahmad.saleem792 ahmad.saleem792 eric hyatt olexander.danilchenko rbuis robert webkit-bug-importer zimmermann oldest_to_newest 109789 0 simon.fraser 2009-02-14 22:02:41 -0800 WebKit's behavior differs from Firefox and Opera when it comes to margin collapsing in an SVG foreignObject. In FF/Opera, margins don't extend outside of the foreignObject. In WebKit, they do. 109790 1 27681 simon.fraser 2009-02-14 22:04:57 -0800 Created attachment 27681 Testcase; compare with Firefox 109861 2 simon.fraser 2009-02-16 10:57:10 -0800 Notes from irc: [10:54am] dhyatt:if (!parent()->isBoxModelObject()) [10:54am] dhyatt: would be good enough i would think [10:55am] dhyatt: m_canCollapseWithChildren = !block->isRenderView() && !block->isRoot() && !block->isPositioned() && [10:55am] dhyatt: !block->isFloating() && !block->isTableCell() && !block->hasOverflowClip() && !block->isInlineBlockOrInlineTable(); [10:55am] dhyatt: line 91 of RenderBlock.cpp 109864 3 simon.fraser 2009-02-16 10:59:34 -0800 dhyatt: we actually don't even let <html> collapse margins with its children [10:57am] dhyatt: could probably just ditch the isRenderView check and replace with !parent() || !parent()->isBoxModelObject() dhyatt: but before doing that would need to see if the <html> in a foreign object collapses with the <body> dhyatt: <html style="margin:100px;"><body style="margin:100px">Hello world dhyatt: in safari that will leave 200px of space above hello world 109865 4 simon.fraser 2009-02-16 11:02:28 -0800 dhyatt: if <html> is special we may end up just having to ask about <html> [11:00am] dhyatt: so yeah the first thing i suggested would fix the isrenderview check [11:00am] dhyatt: but would also need to do something about the isroot check 1888100 5 simon.fraser 2022-08-01 10:21:13 -0700 *** Bug 205550 has been marked as a duplicate of this bug. *** 1888122 6 ap 2022-08-01 11:53:51 -0700 <rdar://problem/97208795> 1906120 7 ahmad.saleem792 2022-10-17 07:18:12 -0700 It will be done with LBSE - https://bugs.webkit.org/show_bug.cgi?id=245908 1906126 8 ahmad.saleem792 2022-10-17 07:58:26 -0700 *** This bug has been marked as a duplicate of bug 245908 *** 1938456 9 ahmad.saleem792 2023-03-03 04:02:52 -0800 I manage to fix this locally, will do new PR. Had to use - isSVGForeignObjectOrLegacySVGForeignObject(); 1938826 10 ahmad.saleem792 2023-03-04 06:23:06 -0800 PR - https://github.com/WebKit/WebKit/pull/10991 2055123 11 ahmad.saleem792 2024-08-24 07:42:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/32668 2168019 12 ews-feeder 2025-12-23 17:00:20 -0800 Committed 304916@main (45d2ff003832): <https://commits.webkit.org/304916@main> Reviewed commits have been landed. Closing PR #32668 and removing active labels. 2168042 13 ahmad.saleem792 2025-12-23 18:44:13 -0800 *** Bug 261109 has been marked as a duplicate of this bug. *** 27681 2009-02-14 22:04:57 -0800 2009-02-14 22:04:57 -0800 Testcase; compare with Firefox html-margin-collapse.svg text/html 516 simon.fraser PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJ5ZXMiPz4KPHN2ZyB4bWxucyA9ICJodHRw Oi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CiAgPGcgc3R5bGU9ImZpbGw6IGdyZWVuOyBzdHJva2U6 IGJsYWNrOyBzdHJva2Utd2lkdGg6IDI7Ij4KICAgIDxyZWN0IHg9IjEwIiB5PSIxMCIgd2lkdGg9 IjMwMCIgaGVpZ2h0PSI0MDAiLz4KICAgIDxmb3JlaWduT2JqZWN0ICB4PSIxMCIgeT0iMTAiIHdp ZHRoPSI0MDAiIGhlaWdodD0iNjAwIj4KICAgICAgPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMu b3JnLzE5OTkveGh0bWwiPgogICAgICAgIDxib2R5IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiBn cmF5OyBoZWlnaHQ6IDIwMHB4OyI+CiAgICAgICAgICA8ZGl2IHN0eWxlPSJtYXJnaW46IDIwcHg7 IGJhY2tncm91bmQtY29sb3I6IG9yYW5nZSI+SSBoYXZlIGJpZyBtYXJnaW5zPC9kaXY+CiAgICAg ICAgPC9ib2R5PgogICAgICA8L2h0bWw+CiAgICA8L2ZvcmVpZ25PYmplY3Q+CiAgPC9nPgo8L3N2 Zz4K