239538 2022-04-20 05:49:31 -0700 [GTK] Deprecate WebKitSettings:enable-java 2022-05-27 10:58:59 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=239651 https://bugs.webkit.org/show_bug.cgi?id=235151 P2 Normal --- 210100 1 mcatanzaro lmoura bugs-noreply mcatanzaro pnormand oldest_to_newest 1862901 0 mcatanzaro 2022-04-20 05:49:31 -0700 Somehow we forgot to deprecate enable-java. It should be removed from GTK 4 API, and deprecated with GTK 3. 1864315 1 mcatanzaro 2022-04-25 17:37:23 -0700 Also: enable-xss-auditor 1871667 2 lmoura 2022-05-24 23:01:12 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1004 1871720 3 lmoura 2022-05-25 07:43:59 -0700 Updating summary after 250038@main handled enable-xss-auditor. 1871726 4 mcatanzaro 2022-05-25 08:21:16 -0700 (In reply to Lauro Moura from comment #3) > Updating summary after 250038@main handled enable-xss-auditor. I'm going to un-update the summary since enable-xss-auditor is deprecated, but has not been removed yet. It shouldn't exist at all in the GTK 4 API version. 1871727 5 mcatanzaro 2022-05-25 08:22:29 -0700 Well, actually, never mind. We don't actually need separate bugs to track removal of deprecated stuff. We have https://bugs.webkit.org/show_bug.cgi?id=235151 for that. 1872239 6 ews-feeder 2022-05-26 18:41:42 -0700 Committed r294920 (251036@main): <https://commits.webkit.org/251036@main> Reviewed commits have been landed. Closing PR #1004 and removing active labels. 1872294 7 pnormand 2022-05-27 03:30:52 -0700 Introduced warnings: ^ /app/webkit/WebKitBuild/Release/WebKit2Gtk/Headers/webkit2/WebKitSettings.h:159:55: note: 'webkit_settings_get_enable_java' has been explicitly marked deprecated here __attribute__((visibility("default"))) __attribute__((__deprecated__)) gboolean ^ /app/webkit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:84:5: warning: 'webkit_settings_set_enable_java' is deprecated [-Wdeprecated-declarations] webkit_settings_set_enable_java(settings, (0)); ^ /app/webkit/WebKitBuild/Release/WebKit2Gtk/Headers/webkit2/WebKitSettings.h:162:55: note: 'webkit_settings_set_enable_java' has been explicitly marked deprecated here __attribute__((visibility("default"))) __attribute__((__deprecated__)) void ^ /app/webkit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:85:76: warning: 'webkit_settings_get_enable_java' is deprecated [-Wdeprecated-declarations] do { if (__builtin_expect (__extension__ ({ int _g_boolean_var_; if (!(webkit_settings_get_enable_java(settings))) _g_boolean_var_ = 1; else _g_boolean_var_ = 0; _g_boolean_var_; }), 1)) ; else g_assertion_message (((gchar*) 0), "/app/webkit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp", 85, ((const char*) (__PRETTY_FUNCTION__)), "'" "webkit_settings_get_enable_java(settings)" "' should be FALSE"); } while (0); ^ /app/webkit/WebKitBuild/Release/WebKit2Gtk/Headers/webkit2/WebKitSettings.h:159:55: note: 'webkit_settings_get_enable_java' has been explicitly marked deprecated here __attribute__((visibility("default"))) __attribute__((__deprecated__)) gboolean ^ 3 warnings generated. 1872304 8 mcatanzaro 2022-05-27 05:58:14 -0700 Reopening to fix warnings. 1872344 9 lmoura 2022-05-27 08:36:58 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1098 1872364 10 ews-feeder 2022-05-27 10:58:56 -0700 Committed r294942 (251052@main): <https://commits.webkit.org/251052@main> Reviewed commits have been landed. Closing PR #1098 and removing active labels.