239482 2022-04-18 23:14:56 -0700 REGRESSION(r292863): std::remove_cvref_t not defined in GCC9< 2022-04-27 00:24:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=238740 https://bugs.webkit.org/show_bug.cgi?id=239805 InRadar P2 Normal --- 1 dpino dpino benjamin cdumez cmarcelo ews-watchlist nina webkit-bug-importer zan zdobersek oldest_to_newest 1862430 0 dpino 2022-04-18 23:14:56 -0700 REGRESSION(r292863): std::remove_cvref_t not defined in GCC9< 1862431 1 457858 dpino 2022-04-18 23:18:30 -0700 Created attachment 457858 Patch 1862545 2 nina 2022-04-19 07:42:13 -0700 should probably make it conditional for `__GLIBCXX__` to avoid affecting libc++ environments (like mac) 1862585 3 457907 dpino 2022-04-19 09:14:43 -0700 Created attachment 457907 Patch 1862834 4 457907 zan 2022-04-19 23:25:18 -0700 Comment on attachment 457907 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457907&action=review > Source/WTF/wtf/StdLibExtras.h:612 > +template <typename T> > +struct remove_cvref { > + using type = typename std::remove_cv<typename std::remove_reference<T>::type>::type; > +}; This has to be in the std namespace too. 1863178 5 458032 dpino 2022-04-20 19:39:32 -0700 Created attachment 458032 Patch 1863225 6 ews-feeder 2022-04-21 01:34:48 -0700 zan@falconsigh.net does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 458032 from commit queue. 1863227 7 ews-feeder 2022-04-21 01:38:31 -0700 zan@falconsigh.net does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 458032 from commit queue. 1863239 8 ews-feeder 2022-04-21 02:30:07 -0700 Committed r293148 (249844@main): <https://commits.webkit.org/249844@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458032. 1863479 9 ryanhaddad 2022-04-21 17:07:59 -0700 rdar://92082938 457858 2022-04-18 23:18:30 -0700 2022-04-19 09:14:34 -0700 Patch bug-239482-20220419141829.patch text/plain 1564 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ1YjZkODU5OTk3NmQ4M2EwMjk2ZDkw YmYzNzc5MTAxZmE3NGVjMGIuLjExMDgyN2MyMjkwYTZiODNmNzk0NWNmZDBiYWQwNmJiNjBkYzhi YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDQtMTggIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyOTI4NjMpOiBzdGQ6OnJl bW92ZV9jdnJlZl90IG5vdCBkZWZpbmVkIGluIEdDQzk8CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk0ODIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdGQ6OnJlbW92ZV9jdnJlZl90IGlzIG9ubHkgYXZh aWxhYmxlIHNpbmNlIEdDQzkgb253YXJkczoKKyAgICAgICAgICBodHRwczovL2VuLmNwcHJlZmVy ZW5jZS5jb20vdy9jcHAvY29tcGlsZXJfc3VwcG9ydC8yMAorCisgICAgICAgICogd3RmL1N0ZExp YkV4dHJhcy5oOiBhZGQgcmVtb3ZlX2N2cmVmX3QgdG8gc3RkIG5hbWVzcGFjZSBpZiBub3QgZGVm aW5lZC4KKwogMjAyMi0wNC0xOCAgRWxsaW90dCBXaWxsaWFtcyAgPGVtd0BhcHBsZS5jb20+CiAK ICAgICAgICAgW1hDQnVpbGRdIFVzZSBYQ0J1aWxkIGZvciBhbGwgY29tbWFuZC1saW5lIGFuZCBw cm9qZWN0IGJ1aWxkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAppbmRleCBjZWY5MWVkOGUxZTQ4NDY5NWIw MTY4Y2ZkZjYyNTQwN2RhMGM5OTMzLi45NDM4YWYyNmE2ZTAxMzIyM2Q3OWEzOWQxZjM0OWVlYzVm NjdkYzlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaApAQCAtNjA1LDYgKzYwNSwxOCBAQCB0ZW1wbGF0 ZTx0eXBlbmFtZSBPcHRpb25hbFR5cGU+IGF1dG8gdmFsdWVPckRlZmF1bHQoT3B0aW9uYWxUeXBl JiYgb3B0aW9uYWxWYWx1ZQogCiAjZGVmaW5lIFdURk1vdmUodmFsdWUpIHN0ZDo6bW92ZTxXVEY6 OkNoZWNrTW92ZVBhcmFtZXRlcj4odmFsdWUpCiAKKyNpZiAhZGVmaW5lZChfX2NwcF9saWJfcmVt b3ZlX2N2cmVmKQordGVtcGxhdGUgPHR5cGVuYW1lIFQ+CitzdHJ1Y3QgcmVtb3ZlX2N2cmVmIHsK KyAgICB1c2luZyB0eXBlID0gdHlwZW5hbWUgc3RkOjpyZW1vdmVfY3Y8dHlwZW5hbWUgc3RkOjpy ZW1vdmVfcmVmZXJlbmNlPFQ+Ojp0eXBlPjo6dHlwZTsKK307CisKK25hbWVzcGFjZSBzdGQgewor dGVtcGxhdGUgPHR5cGVuYW1lIFQ+Cit1c2luZyByZW1vdmVfY3ZyZWZfdCA9IHR5cGVuYW1lIHJl bW92ZV9jdnJlZjxUPjo6dHlwZTsKK30KKyNlbmRpZgorCiB1c2luZyBXVEY6OkdCOwogdXNpbmcg V1RGOjpLQjsKIHVzaW5nIFdURjo6TUI7Cg== 457907 2022-04-19 09:14:43 -0700 2022-04-20 19:39:12 -0700 Patch bug-239482-20220420001440.patch text/plain 1588 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ1YjZkODU5OTk3NmQ4M2EwMjk2ZDkw YmYzNzc5MTAxZmE3NGVjMGIuLjExMDgyN2MyMjkwYTZiODNmNzk0NWNmZDBiYWQwNmJiNjBkYzhi YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDQtMTggIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyOTI4NjMpOiBzdGQ6OnJl bW92ZV9jdnJlZl90IG5vdCBkZWZpbmVkIGluIEdDQzk8CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk0ODIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdGQ6OnJlbW92ZV9jdnJlZl90IGlzIG9ubHkgYXZh aWxhYmxlIHNpbmNlIEdDQzkgb253YXJkczoKKyAgICAgICAgICBodHRwczovL2VuLmNwcHJlZmVy ZW5jZS5jb20vdy9jcHAvY29tcGlsZXJfc3VwcG9ydC8yMAorCisgICAgICAgICogd3RmL1N0ZExp YkV4dHJhcy5oOiBhZGQgcmVtb3ZlX2N2cmVmX3QgdG8gc3RkIG5hbWVzcGFjZSBpZiBub3QgZGVm aW5lZC4KKwogMjAyMi0wNC0xOCAgRWxsaW90dCBXaWxsaWFtcyAgPGVtd0BhcHBsZS5jb20+CiAK ICAgICAgICAgW1hDQnVpbGRdIFVzZSBYQ0J1aWxkIGZvciBhbGwgY29tbWFuZC1saW5lIGFuZCBw cm9qZWN0IGJ1aWxkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAppbmRleCBjZWY5MWVkOGUxZTQ4NDY5NWIw MTY4Y2ZkZjYyNTQwN2RhMGM5OTMzLi5iNjdmZjJmNWM3YTQ2ZGU1ZjI2ZWE3ZjA5ZmRlODA5MDg4 NWJiNTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaApAQCAtNjA1LDYgKzYwNSwxOCBAQCB0ZW1wbGF0 ZTx0eXBlbmFtZSBPcHRpb25hbFR5cGU+IGF1dG8gdmFsdWVPckRlZmF1bHQoT3B0aW9uYWxUeXBl JiYgb3B0aW9uYWxWYWx1ZQogCiAjZGVmaW5lIFdURk1vdmUodmFsdWUpIHN0ZDo6bW92ZTxXVEY6 OkNoZWNrTW92ZVBhcmFtZXRlcj4odmFsdWUpCiAKKyNpZiBkZWZpbmVkKF9fR0xJQkNYWF9fKSAm JiAhZGVmaW5lZChfX2NwcF9saWJfcmVtb3ZlX2N2cmVmKQordGVtcGxhdGUgPHR5cGVuYW1lIFQ+ CitzdHJ1Y3QgcmVtb3ZlX2N2cmVmIHsKKyAgICB1c2luZyB0eXBlID0gdHlwZW5hbWUgc3RkOjpy ZW1vdmVfY3Y8dHlwZW5hbWUgc3RkOjpyZW1vdmVfcmVmZXJlbmNlPFQ+Ojp0eXBlPjo6dHlwZTsK K307CisKK25hbWVzcGFjZSBzdGQgewordGVtcGxhdGUgPHR5cGVuYW1lIFQ+Cit1c2luZyByZW1v dmVfY3ZyZWZfdCA9IHR5cGVuYW1lIHJlbW92ZV9jdnJlZjxUPjo6dHlwZTsKK30KKyNlbmRpZgor CiB1c2luZyBXVEY6OkdCOwogdXNpbmcgV1RGOjpLQjsKIHVzaW5nIFdURjo6TUI7Cg== 458032 2022-04-20 19:39:32 -0700 2022-04-21 02:30:09 -0700 Patch bug-239482-20220421103924.patch text/plain 1591 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE2NGY4MzU4ZmEwZTU1NTNjYzc2ZWU5 YzlmZDkzNDdhZjIwOGJhY2MuLmI2Y2Q4OTEzYTE2M2IzNjMxMjMzOGZlOWJlOWU0ZDUzYTI5MDNl MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDQtMjAgIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyOTI4NjMpOiBzdGQ6OnJl bW92ZV9jdnJlZl90IG5vdCBkZWZpbmVkIGluIEdDQzk8CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk0ODIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdGQ6OnJlbW92ZV9jdnJlZl90IGlzIG9ubHkgYXZh aWxhYmxlIHNpbmNlIEdDQzkgb253YXJkczoKKyAgICAgICAgICBodHRwczovL2VuLmNwcHJlZmVy ZW5jZS5jb20vdy9jcHAvY29tcGlsZXJfc3VwcG9ydC8yMAorCisgICAgICAgICogd3RmL1N0ZExp YkV4dHJhcy5oOiBhZGQgcmVtb3ZlX2N2cmVmX3QgdG8gc3RkIG5hbWVzcGFjZSBpZiBub3QgZGVm aW5lZC4KKwogMjAyMi0wNC0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg ICAgICAgIE1vdmUgdHJ1ZSAvIGZhbHNlIEF0b21TdHJpbmdzIHRvIGEgY2VudHJhbCBsb2NhdGlv biBhbmQgcmV1c2UgdGhlbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFz LmggYi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAppbmRleCBjZWY5MWVkOGUxZTQ4NDY5 NWIwMTY4Y2ZkZjYyNTQwN2RhMGM5OTMzLi45MjEzZmY2NjNiNTg4ODIzMmI1ODYwOTdlMDUwZWIy Yjk3OWE5NmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAorKysg Yi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaApAQCAtNjA1LDYgKzYwNSwxOCBAQCB0ZW1w bGF0ZTx0eXBlbmFtZSBPcHRpb25hbFR5cGU+IGF1dG8gdmFsdWVPckRlZmF1bHQoT3B0aW9uYWxU eXBlJiYgb3B0aW9uYWxWYWx1ZQogCiAjZGVmaW5lIFdURk1vdmUodmFsdWUpIHN0ZDo6bW92ZTxX VEY6OkNoZWNrTW92ZVBhcmFtZXRlcj4odmFsdWUpCiAKKyNpZiBkZWZpbmVkKF9fR0xJQkNYWF9f KSAmJiAhZGVmaW5lZChfX2NwcF9saWJfcmVtb3ZlX2N2cmVmKQorbmFtZXNwYWNlIHN0ZCB7Cit0 ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KK3N0cnVjdCByZW1vdmVfY3ZyZWYgeworICAgIHVzaW5nIHR5 cGUgPSB0eXBlbmFtZSBzdGQ6OnJlbW92ZV9jdjx0eXBlbmFtZSBzdGQ6OnJlbW92ZV9yZWZlcmVu Y2U8VD46OnR5cGU+Ojp0eXBlOworfTsKKwordGVtcGxhdGUgPHR5cGVuYW1lIFQ+Cit1c2luZyBy ZW1vdmVfY3ZyZWZfdCA9IHR5cGVuYW1lIHJlbW92ZV9jdnJlZjxUPjo6dHlwZTsKK30KKyNlbmRp ZgorCiB1c2luZyBXVEY6OkdCOwogdXNpbmcgV1RGOjpLQjsKIHVzaW5nIFdURjo6TUI7Cg==