<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>239469</bug_id>
          
          <creation_ts>2022-04-18 15:17:51 -0700</creation_ts>
          <short_desc>Create WebKit review helper Safari extension</short_desc>
          <delta_ts>2022-04-26 08:47:49 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>239082</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aperez</cc>
    
    <cc>ap</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1862337</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2022-04-18 15:17:51 -0700</bug_when>
    <thetext>There are several good things to have in GitHub. Good thing is that GitHub is web app, so for UI related tweaks, we can introduce an &quot;improvement&quot; via Safari extensions.
It is nice if we can host such a thing in WebKit tree to ease development on GitHub.
Raised at https://webkit.slack.com/archives/CTV4FGWF4/p1650057108663419?thread_ts=1645753205.677369&amp;cid=CTV4FGWF4


Darin Adler  3 days ago
I learned that truly gigantic patches are a little harder to review in GitHub than bugs.webkit.org

yusukesuzuki  3 days ago
I wonder if we can have some good improvement :slightly_smiling_face: rdar://91790051

Darin Adler  3 days ago
WebKit performance is definitely one reason. Defaulting to not expanding the diff for files with a lot of changes is a related second frustration. Can’t just scroll through. I also find it harder to walk from comment to comment

yusukesuzuki  3 days ago
https://gist.github.com/juanca/5fd799c5b094e3e4f8b709cd101d7403
This bookmarklet would help :slightly_smiling_face:

yusukesuzuki  3 days ago
I wonder if we can have Safari extension for github.com/WebKit/WebKit in the tree with all of these kind of hacks.

Darin Adler  1 day ago
Seems like we need to change those bookmarklets into an extension we’ll all want

yusukesuzuki  1 day ago
Good thing is that GitHub is a web app. So with extension, we can apply UI related changes by ourselves.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1864252</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-04-25 15:18:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/92297393&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>