239411 2022-04-15 16:49:59 -0700 GitHub EWS is confused with prior PR's merge-blocked label 2022-04-25 17:22:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 239082 239613 1 ysuzuki jbedard aakash_jain cdumez jbedard mcatanzaro webkit-bug-importer oldest_to_newest 1861975 0 ysuzuki 2022-04-15 16:49:59 -0700 If we update PRs multiple times in a short period, 1. The former EWS run is still running while new PR is uploaded 2. The former EWS puts `merge-blocked` label if it failed, even though a new change is uploaded to this PR 3. If the former EWS puts `merge-blocked` accidentally, it prevents us from running EWS tests in a new PR So, EWS should put `merge-blocked` label only when PR's latest change matches to the patch of EWS. 1862239 1 aakash_jain 2022-04-18 09:28:08 -0700 Also, it might make sense to automatically remove 'merge-blocked' label while uploading new version of the PR, using 'git-webkit pr' command. 1862547 2 mcatanzaro 2022-04-19 07:56:21 -0700 (In reply to Yusuke Suzuki from comment #0) > 1. The former EWS run is still running while new PR is uploaded :/ Ideally a force push would immediately cancel any previous EWS runs. 1863346 3 ysuzuki 2022-04-21 10:46:12 -0700 Right now, it is hard to run EWS tests on GitHub because of this issue. Previous EWS runs slowly and puts merge-blocked label at random time, and which blocks newly scheduled EWS tests. 1863363 4 jbedard 2022-04-21 12:04:11 -0700 (In reply to Aakash Jain from comment #1) > Also, it might make sense to automatically remove 'merge-blocked' label > while uploading new version of the PR, using 'git-webkit pr' command. We already do that. 1863443 5 ysuzuki 2022-04-21 15:54:59 -0700 In https://bugs.webkit.org/show_bug.cgi?id=239613, it seems that we failed to run EWS on GitHub because of this and it was labeled with check-mark. 1863819 6 webkit-bug-importer 2022-04-22 16:50:14 -0700 <rdar://problem/92196846> 1864167 7 jbedard 2022-04-25 11:42:08 -0700 *** Bug 239731 has been marked as a duplicate of this bug. *** 1864203 8 jbedard 2022-04-25 13:27:37 -0700 Pull request: https://github.com/WebKit/WebKit/pull/380 1864307 9 ews-feeder 2022-04-25 17:22:26 -0700 Committed r293381 (249971@main): <https://commits.webkit.org/249971@main> Reviewed commits have been landed. Closing PR #380 and removing active labels.