239385 2022-04-15 07:47:54 -0700 [git-webkit] Make the default rebase behavior for `git-webkit pr` configurable 2023-01-20 00:17:41 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=250888 InRadar P2 Normal --- 239082 1 graouts jbedard jbedard rego webkit-bug-importer oldest_to_newest 1861803 0 graouts 2022-04-15 07:47:54 -0700 I had the – to me – unpleasant experience with my first successful run of `git-webkit pr` that it defaults to rebasing. This is an extremely costly default for WebKit since build time can be long. Should we consider defaulting to --no-rebase to match what webkit-patch upload would do? Regardless of what the default is, Jonathan suggested in https://webkit.slack.com/archives/C01C94S4C6M/p1650033807494789?thread_ts=1650026926.714759&cid=C01C94S4C6M to "gate the default on a .git/config setting and prompt folks when running git-webkit setup". 1861827 1 webkit-bug-importer 2022-04-15 09:26:15 -0700 <rdar://problem/91811534> 1861829 2 jbedard 2022-04-15 09:35:17 -0700 Pull request: https://github.com/WebKit/WebKit/pull/295 1868674 3 rego 2022-05-13 01:02:26 -0700 I agree, rebases are very time consuming, and I believe by default it shouldn't do a rebase. That's what webkit-patch has been doing for years. Can we change the default in addition to making it configurable? 1875355 4 ews-feeder 2022-06-10 18:33:57 -0700 Committed r295470 (251475@main): <https://commits.webkit.org/251475@main> Reviewed commits have been landed. Closing PR #295 and removing active labels. 1875535 5 jbedard 2022-06-13 09:38:52 -0700 (In reply to Manuel Rego Casasnovas from comment #3) > I agree, rebases are very time consuming, and I believe by default it > shouldn't do a rebase. That's what webkit-patch has been doing for years. > > Can we change the default in addition to making it configurable? This change means contributors will be prompted in `git-webkit setup` for their personal default. Rebases were already configurable on a command-by-command basis (with --no-rebase and --rebase). 1926828 6 graouts 2023-01-20 00:17:41 -0800 Making this default to "No" during `git webkit setup` in bug 250888.