<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>23924</bug_id>
          
          <creation_ts>2009-02-12 09:23:47 -0800</creation_ts>
          <short_desc>getComputedStyle() on transform property should return function list</short_desc>
          <delta_ts>2022-10-23 03:18:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=245523</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>222096</blocked>
    
    <blocked>235139</blocked>
    
    <blocked>235807</blocked>
    
    <blocked>235808</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Marrin">cmarrin</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>ayg</cc>
    
    <cc>graouts</cc>
    
    <cc>jussi.kukkonen</cc>
    
    <cc>mrobinson</cc>
    
    <cc>nmouchtaris</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zoltan.nyul</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>109485</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Marrin">cmarrin</who>
    <bug_when>2009-02-12 09:23:47 -0800</bug_when>
    <thetext>Currently getComputedStyle for -webkit-transform returns matrix(...) or matrix3d(...). It should return the original function list with pixels where percents used to be, etc.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1827885</commentid>
    <comment_count>1</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2022-01-04 02:22:30 -0800</bug_when>
    <thetext>I believe this issue can be closed and the comment in CSSComputedStyleDeclaration.cpp can be removed because the CSS Transforms Module Level 2 specification says:

&quot;A &lt;transform-list&gt; for the computed value is serialized to either one &lt;matrix()&gt; or one &lt;matrix3d()&gt; function by the following algorithm:&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874588</commentid>
    <comment_count>2</comment_count>
    <who name="Nikos Mouchtaris">nmouchtaris</who>
    <bug_when>2022-06-07 15:33:24 -0700</bug_when>
    <thetext>I think the spec you were looking at was out of date Martin. According to https://drafts.csswg.org/css-transforms/#serialization-of-transform-functions, we should be serializing the individual functions. This is related to our test failures in css/css-transforms/animation/transform-interpolation-inline-value.html.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1882997</commentid>
    <comment_count>3</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2022-07-13 07:53:21 -0700</bug_when>
    <thetext>I&apos;ve been investigating this a bit more and I confirmed that getComputedStyle(...).transform always returns `matrix()` or `matrix3d()` whereas div.style after running `commitStyles()` is returning the individual transform functions. In WebKit, `div.style` is returning `matrix()` and `matrix3d()` always after `commitStyles()`. I think the failure in css/css-transforms/animation/transform-interpolation-inline-value.html are probably an issue with `commitStyles()`.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1882999</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2022-07-13 07:53:59 -0700</bug_when>
    <thetext>(In reply to Martin Robinson from comment #3)
&gt; I&apos;ve been investigating this a bit more and I confirmed that
&gt; getComputedStyle(...).transform always returns `matrix()` or `matrix3d()`
&gt; whereas div.style after running `commitStyles()` is returning the individual
&gt; transform functions. In WebKit, `div.style` is returning `matrix()` and
&gt; `matrix3d()` always after `commitStyles()`. I think the failure in
&gt; css/css-transforms/animation/transform-interpolation-inline-value.html are
&gt; probably an issue with `commitStyles()`.

To clarify, div.style after running `commitStyles()` is returning the individual transform functions in Firefox and Chrome.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898502</commentid>
    <comment_count>5</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-09-14 11:29:59 -0700</bug_when>
    <thetext>This is also an issue with getKeyframes() always returning the matrix form.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898503</commentid>
    <comment_count>6</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-09-14 11:36:03 -0700</bug_when>
    <thetext>I think I&apos;ll take a crack at it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898720</commentid>
    <comment_count>7</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-09-15 09:28:52 -0700</bug_when>
    <thetext>I&apos;ve made good progress here, still something to polish off before I can file a patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900333</commentid>
    <comment_count>8</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-09-22 02:55:38 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/4591</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900371</commentid>
    <comment_count>9</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-09-22 07:26:20 -0700</bug_when>
    <thetext>The fix for this will cause a slight WPT regression tracked by bug 245523.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900397</commentid>
    <comment_count>10</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-22 10:47:26 -0700</bug_when>
    <thetext>Committed 254760@main (ae44d0ca68fa): &lt;https://commits.webkit.org/254760@main&gt;

Reviewed commits have been landed. Closing PR #4591 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900398</commentid>
    <comment_count>11</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-09-22 10:48:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/100283235&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>