<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>239132</bug_id>
          
          <creation_ts>2022-04-12 10:40:32 -0700</creation_ts>
          <short_desc>[GTK] Remove WebKitInstallMissingMediaPluginsPermissionRequest</short_desc>
          <delta_ts>2023-01-10 03:11:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=147822</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=250376</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>210100</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Philippe Normand">philn</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>philn</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1860719</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-04-12 10:40:32 -0700</bug_when>
    <thetext>The WebKitInstallMissingMediaPluginsPermissionRequest API has been broken for six years, ever since we fixed bug #135972. Let&apos;s remove this from our GTK 4 API.

We might eventually create a new API to handle codec installation, see bug #147822, but I don&apos;t think it&apos;s terribly urgent or important. Normally you can either offer codecs and install them by default (e.g. Debian), or you can&apos;t offer them at all (e.g. Fedora). Having a codec installer that&apos;s either not needed or cannot work is not super useful either way.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1897025</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-09-08 07:57:57 -0700</bug_when>
    <thetext>Note there are D-Bus permissions for this in XDGDBusProxy.cpp that should be removed.

Also we should deprecate the APIs in the old API version, as they haven&apos;t been deprecated yet.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1897026</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-09-08 07:58:28 -0700</bug_when>
    <thetext>Also should remove /webkit2/WebKitWebView/install-missing-plugins-permission-request and any failure expectations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1923109</commentid>
    <comment_count>3</comment_count>
    <who name="Philippe Normand">philn</who>
    <bug_when>2023-01-05 01:18:01 -0800</bug_when>
    <thetext>I agree, I&apos;ll prepare a patch for this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1923119</commentid>
    <comment_count>4</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2023-01-05 03:01:03 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/8232</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1924011</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-09 01:53:57 -0800</bug_when>
    <thetext>Committed 258653@main (209971efaec5): &lt;https://commits.webkit.org/258653@main&gt;

Reviewed commits have been landed. Closing PR #8232 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>