238496 2022-03-29 02:23:13 -0700 IPC::Connection::Connection() is not usable from non-main threads 2022-04-05 02:24:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 238515 1 kkinnunen kkinnunen cdumez kkinnunen webkit-bug-importer oldest_to_newest 1855956 0 kkinnunen 2022-03-29 02:23:13 -0700 IPC::Connection::Connection() is not usable from non-main threads 1856115 1 456047 kkinnunen 2022-03-29 11:33:28 -0700 Created attachment 456047 Patch 1856846 2 456047 cdumez 2022-03-31 10:14:59 -0700 Comment on attachment 456047 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456047&action=review > Source/WebKit/ChangeLog:8 > + Make it possible to instantiate Connection from non-main threads. Is it OK that even we can now construct an IPC::Connection off the main thread, it will still always get destroyed on the main thread (meaning that the destruction thread differs from the construction thread)? 1857784 3 456047 kkinnunen 2022-04-04 01:53:35 -0700 Comment on attachment 456047 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456047&action=review >> Source/WebKit/ChangeLog:8 >> + Make it possible to instantiate Connection from non-main threads. > > Is it OK that even we can now construct an IPC::Connection off the main thread, it will still always get destroyed on the main thread (meaning that the destruction thread differs from the construction thread)? Yes, I think it is sound. This also preserves the assertions in the destructor. However, currently the feature of constructing in arbitrary thread is not that useful. Also, the feature in practice cannot be used until more of the features (all?) are made thread agnostic. This means the work in this patch is mostly useful only at the point when ~Connection runs in arbitrary thread. 1858308 4 webkit-bug-importer 2022-04-05 02:24:13 -0700 <rdar://problem/91284136> 456047 2022-03-29 11:33:28 -0700 2022-03-29 21:01:54 -0700 Patch bug-238496-20220329213327.patch text/plain 2303 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNiZDg5NThhMDlkZjY3ZTJj MWEzNGI3Njk3NmY3YjE3MTE3NGY4OTQuLmViMDBkZWM4MTMyNDkzZDkxZTcwOTg1ODhiZjQ0Zjc0 MjFmNTMxODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDMtMjkgIEtpbW1vIEtp bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KKworICAgICAgICBJUEM6OkNvbm5lY3Rpb246 OkNvbm5lY3Rpb24oKSBpcyBub3QgdXNhYmxlIGZyb20gbm9uLW1haW4gdGhyZWFkcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4NDk2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBpdCBwb3NzaWJs ZSB0byBpbnN0YW50aWF0ZSBDb25uZWN0aW9uIGZyb20gbm9uLW1haW4gdGhyZWFkcy4KKyAgICAg ICAgVGhpcyBpcyBhIHdvcmsgdG93YXJkcyBiZWluZyBub24tbWFpbiB0aHJlYWQgQ29ubmVjdGlv bi4KKworICAgICAgICAqIFBsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcDoKKyAgICAgICAgKElQ Qzo6Q29ubmVjdGlvbjo6Q29ubmVjdGlvbik6CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OmNv bm5lY3Rpb24pOgorCiAyMDIyLTAzLTI4ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29t PgogCiAgICAgICAgIERpc2FibGUgY3VzdG9tIHN0b3JhZ2UgcGF0aHMgZm9yIEluZGV4ZWREQiBh bmQgTG9jYWxTdG9yYWdlIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29u bmVjdGlvbi5jcHAKaW5kZXggYjc0OWQ2ZjZjMjM4NWNmZTVlMDBhZTgxMWIyOTU1YmRmZjgzZjIx Yy4uYzdkODhiNzA4MzVjYzk2OWE3ODJlNjQ2ZmUyNjYzNGNkYzJkMmFiNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHAKQEAgLTI4OCwxMiArMjg4LDEwIEBAIHN0 YXRpYyB2b2lkIGNsZWFyQXN5bmNSZXBseUhhbmRsZXJzKGNvbnN0IENvbm5lY3Rpb24mKTsKIAog Q29ubmVjdGlvbjo6Q29ubmVjdGlvbihJZGVudGlmaWVyIGlkZW50aWZpZXIsIGJvb2wgaXNTZXJ2 ZXIsIENsaWVudCYgY2xpZW50KQogICAgIDogbV9jbGllbnQoY2xpZW50KQotICAgICwgbV91bmlx dWVJRChVbmlxdWVJRDo6Z2VuZXJhdGUoKSkKKyAgICAsIG1fdW5pcXVlSUQoVW5pcXVlSUQ6Omdl bmVyYXRlVGhyZWFkU2FmZSgpKQogICAgICwgbV9pc1NlcnZlcihpc1NlcnZlcikKICAgICAsIG1f Y29ubmVjdGlvblF1ZXVlKFdvcmtRdWV1ZTo6Y3JlYXRlKCJjb20uYXBwbGUuSVBDLlJlY2VpdmVR dWV1ZSIpKQogewotICAgIEFTU0VSVChSdW5Mb29wOjppc01haW4oKSk7Ci0KICAgICB7CiAgICAg ICAgIExvY2tlciBsb2NrZXIgeyBzX2Nvbm5lY3Rpb25NYXBMb2NrIH07CiAgICAgICAgIGNvbm5l Y3Rpb25NYXAoKS5hZGQobV91bmlxdWVJRCwgdGhpcyk7CkBAIC0zMTUsMTIgKzMxMywxMCBAQCBD b25uZWN0aW9uOjp+Q29ubmVjdGlvbigpCiAgICAgY2xlYXJBc3luY1JlcGx5SGFuZGxlcnMoKnRo aXMpOwogfQogCi0vLyBXVEZfSUdOT1JFU19USFJFQURfU0FGRVRZX0FOQUxZU0lTIGJlY2F1c2Ug dGhpcyBmdW5jdGlvbiBhY2Nlc3NlcyBjb25uZWN0aW9uTWFwKCkgd2l0aG91dCBsb2NraW5nLgot Ly8gSXQgaXMgc2FmZSBiZWNhdXNlIHRoaXMgZnVuY3Rpb24gaXMgb25seSBjYWxsZWQgb24gdGhl IG1haW4gdGhyZWFkIGFuZCBDb25uZWN0aW9uIG9iamVjdHMgYXJlIG9ubHkKLS8vIGNvbnN0cnVj dGVkIC8gZGVzdHJveWVkIG9uIHRoZSBtYWluIHRocmVhZC4KLUNvbm5lY3Rpb24qIENvbm5lY3Rp b246OmNvbm5lY3Rpb24oVW5pcXVlSUQgdW5pcXVlSUQpIFdURl9JR05PUkVTX1RIUkVBRF9TQUZF VFlfQU5BTFlTSVMKK0Nvbm5lY3Rpb24qIENvbm5lY3Rpb246OmNvbm5lY3Rpb24oVW5pcXVlSUQg dW5pcXVlSUQpCiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICBMb2NrZXIg bG9ja2VyIHsgc19jb25uZWN0aW9uTWFwTG9jayB9OwogICAgIHJldHVybiBjb25uZWN0aW9uTWFw KCkuZ2V0KHVuaXF1ZUlEKTsKIH0KIAo=