238403 2022-03-25 19:22:53 -0700 [GTK] Create bwrapinfo.json file for xdg-desktop-portal 2025-10-20 08:51:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=301098 P2 Normal --- 206533 1 pgriffis pgriffis bugs-noreply emilio marmel6942 mcatanzaro oldest_to_newest 1855307 0 pgriffis 2022-03-25 19:22:53 -0700 [GTK] Create bwrapinfo.json file for xdg-desktop-portal 1855308 1 455814 pgriffis 2022-03-25 19:23:56 -0700 Created attachment 455814 Patch 1855309 2 pgriffis 2022-03-25 19:25:41 -0700 This works around a crash in xdg-desktop-portal 1.12.1 and 1.14.0: https://github.com/flatpak/xdg-desktop-portal/issues/709 I have fixed this in future xdg-desktop-portal releases: https://github.com/flatpak/xdg-desktop-portal/pull/746 However the feature is not fully functioning: https://github.com/flatpak/xdg-desktop-portal/issues/747 1855395 3 mcatanzaro 2022-03-26 08:45:45 -0700 You intentionally did not set r? here, right? 1855396 4 pgriffis 2022-03-26 08:50:59 -0700 (In reply to Michael Catanzaro from comment #3) > You intentionally did not set r? here, right? Yeah, as-is it doesn't really work, so I guess it was more just to track the issue and document the progress towards getting it working. 2006580 5 pgriffis 2024-01-22 10:23:19 -0800 Pull request: https://github.com/WebKit/WebKit/pull/23052 2006584 6 mcatanzaro 2024-01-22 10:26:02 -0800 *** Bug 267497 has been marked as a duplicate of this bug. *** 2006619 7 marmel6942 2024-01-22 12:29:35 -0800 I built webkit2gtk-4.1 2.42.4 + https://github.com/WebKit/WebKit/pull/23052, and can confirm it resolved my original issue reported in bug 267497. Thanks! 2006751 8 ews-feeder 2024-01-22 17:26:56 -0800 Committed 273334@main (b9361c774194): <https://commits.webkit.org/273334@main> Reviewed commits have been landed. Closing PR #23052 and removing active labels. 455814 2022-03-25 19:23:56 -0700 2022-03-26 02:59:09 -0700 Patch bug-238403-20220325212355.patch text/plain 5399 pgriffis U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQxZjUyNTAzZWMwMjZmZTNm NDFjYjYyNjdmOTQ5Y2Y3OThkOTA2MzkuLmI2ZWY3NTczZDM1NDg5MDQxNmI2NDBlYzRjMGU4Yjhm NmVjYmMyZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjItMDMtMjUgIFBhdHJpY2sg R3JpZmZpcyAgPHBncmlmZmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQ3JlYXRlIGJ3 cmFwaW5mby5qc29uIGZpbGUgZm9yIHhkZy1kZXNrdG9wLXBvcnRhbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4NDAzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgeGRnLWRlc2t0b3AtcG9ydGFsIHJlYWRz IHRoZSBpbnN0YW5jZS1pZCBmcm9tIC8uZmxhdHBhay1pbmZvIGFuZAorICAgICAgICBtYXBzIHRo YXQgdG8gYSBid3JhcGluZm8uanNvbiBmaWxlIG9uIHRoZSBmaWxlc3lzdGVtIGluIG9yZGVyIHRv CisgICAgICAgIGRvIHBpZC1tYXBwaW5nIGZvciB0aGUgcmVhbHRpbWUgcG9ydGFsLgorCisgICAg ICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6Y3JlYXRlQndyYXBJbmZvRmQpOgorICAgICAgICAoV2ViS2l0OjpjcmVh dGVGbGF0cGFrSW5mbyk6CisgICAgICAgIChXZWJLaXQ6OmJ1YmJsZXdyYXBTcGF3bik6CisKIDIw MjItMDMtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdW1dQRV0gUmVtb3ZlIHRoZSBBVEsgaW1wbGVtZW50YXRpb24KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5j aGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3Jh cExhdW5jaGVyLmNwcAppbmRleCA5ZDNmOThhMzQ5NDA0MDlmOWNhOGE0MmFjOTQ0ZWE3NmViYjRm NjdiLi4wNzlhNTFkYjFiNzZlY2NhZjcwOTRkZDhjZjc3YjVkOWRmZTYxMDhiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hl ci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3 cmFwTGF1bmNoZXIuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSA8c3lzL2lvY3RsLmg+ CiAjaW5jbHVkZSA8c3lzL21tYW4uaD4KICNpbmNsdWRlIDx3dGYvRmlsZVN5c3RlbS5oPgorI2lu Y2x1ZGUgPHd0Zi9VVUlELmg+CiAjaW5jbHVkZSA8d3RmL1VuaVN0ZEV4dHJhcy5oPgogI2luY2x1 ZGUgPHd0Zi9nbGliL0dSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvZ2xpYi9HVW5pcXVlUHRyLmg+ CkBAIC0xMzcsMjUgKzEzOCwzNSBAQCBzdGF0aWMgY29uc3QgY2hhciogYXBwbGljYXRpb25JZChH RXJyb3IqKiBlcnJvcikKICAgICByZXR1cm4gYXBwSUQ7CiB9CiAKLXN0YXRpYyBpbnQgY3JlYXRl RmxhdHBha0luZm8oKQorc3RhdGljIGludCBjcmVhdGVCd3JhcEluZm9GZChjb25zdCBjaGFyKiBp bnN0YW5jZVBhdGgpCiB7Ci0gICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEdVbmlxdWVQdHI8Y2hh cj4+IGRhdGE7Ci0gICAgc3RhdGljIHNpemVfdCBzaXplOwotCi0gICAgaWYgKCFkYXRhLmdldCgp KSB7Ci0gICAgICAgIC8vIHhkZy1kZXNrdG9wLXBvcnRhbCByZWxhdGVzIHlvdXIgbmFtZSB0byBj ZXJ0YWluIHBlcm1pc3Npb25zIHNvIHdlIHdhbnQKLSAgICAgICAgLy8gdGhlbSB0byBiZSBhcHBs aWNhdGlvbiB1bmlxdWUgd2hpY2ggaXMgYmVzdCBkb25lIHZpYSBHQXBwbGljYXRpb24uCi0gICAg ICAgIEdVbmlxdWVPdXRQdHI8R0Vycm9yPiBlcnJvcjsKLSAgICAgICAgY29uc3QgY2hhciogYXBw SUQgPSBhcHBsaWNhdGlvbklkKCZlcnJvci5vdXRQdHIoKSk7Ci0gICAgICAgIGlmICghYXBwSUQp Ci0gICAgICAgICAgICBnX2Vycm9yKCJVbmFibGUgdG8gY29uZmlndXJlIHhkZy1kZXNrdG9wLXBv cnRhbCBhY2Nlc3MgaW4gdGhlIFdlYktpdCBzYW5kYm94OiAlcyIsIGVycm9yLT5tZXNzYWdlKTsK LQotICAgICAgICBHVW5pcXVlUHRyPEdLZXlGaWxlPiBrZXlGaWxlKGdfa2V5X2ZpbGVfbmV3KCkp OwotICAgICAgICBnX2tleV9maWxlX3NldF9zdHJpbmcoa2V5RmlsZS5nZXQoKSwgIkFwcGxpY2F0 aW9uIiwgIm5hbWUiLCBhcHBJRCk7Ci0gICAgICAgIGRhdGEtPnJlc2V0KGdfa2V5X2ZpbGVfdG9f ZGF0YShrZXlGaWxlLmdldCgpLCAmc2l6ZSwgbnVsbHB0cikpOwotICAgIH0KKyAgICBpZiAoZ19t a2Rpcl93aXRoX3BhcmVudHMoaW5zdGFuY2VQYXRoLCAwNzU1KSkKKyAgICAgICAgZ193YXJuaW5n KCJDcmVhdGluZyBcIiVzXCIgZmFpbGVkOiAlcyIsIGluc3RhbmNlUGF0aCwgZ19zdHJlcnJvcihl cnJubykpOworCisgICAgR1VuaXF1ZVB0cjxjaGFyPiBid3JhcEluZm9QYXRoKGdfYnVpbGRfZmls ZW5hbWUoaW5zdGFuY2VQYXRoLCAiYndyYXBpbmZvLmpzb24iLCBudWxscHRyKSk7CisgICAgaW50 IGZkID0gb3Blbihid3JhcEluZm9QYXRoLmdldCgpLCBPX1JEV1IgfCBPX0NSRUFULCAwNjQ0KTsK KyAgICBpZiAoZmQgPT0gLTEpCisgICAgICAgIGdfd2FybmluZygiT3BlbmluZyBcIiVzXCIgZmFp bGVkOiAlcyIsIGJ3cmFwSW5mb1BhdGguZ2V0KCksIGdfc3RyZXJyb3IoZXJybm8pKTsKIAotICAg IHJldHVybiBjcmVhdGVTZWFsZWRNZW1GZFdpdGhEYXRhKCJmbGF0cGFrLWluZm8iLCBkYXRhLT5n ZXQoKSwgc2l6ZSk7CisgICAgcmV0dXJuIGZkOworfQorCitzdGF0aWMgaW50IGNyZWF0ZUZsYXRw YWtJbmZvKGNvbnN0IGNoYXIqIGluc3RhbmNlSUQpCit7CisgICAgLy8geGRnLWRlc2t0b3AtcG9y dGFsIHJlbGF0ZXMgeW91ciBuYW1lIHRvIGNlcnRhaW4gcGVybWlzc2lvbnMgc28gd2Ugd2FudAor ICAgIC8vIHRoZW0gdG8gYmUgYXBwbGljYXRpb24gdW5pcXVlIHdoaWNoIGlzIGJlc3QgZG9uZSB2 aWEgR0FwcGxpY2F0aW9uLgorICAgIEdVbmlxdWVPdXRQdHI8R0Vycm9yPiBlcnJvcjsKKyAgICBj b25zdCBjaGFyKiBhcHBJRCA9IGFwcGxpY2F0aW9uSWQoJmVycm9yLm91dFB0cigpKTsKKyAgICBp ZiAoIWFwcElEKQorICAgICAgICBnX2Vycm9yKCJVbmFibGUgdG8gY29uZmlndXJlIHhkZy1kZXNr dG9wLXBvcnRhbCBhY2Nlc3MgaW4gdGhlIFdlYktpdCBzYW5kYm94OiAlcyIsIGVycm9yLT5tZXNz YWdlKTsKKworICAgIEdVbmlxdWVQdHI8R0tleUZpbGU+IGtleUZpbGUoZ19rZXlfZmlsZV9uZXco KSk7CisgICAgZ19rZXlfZmlsZV9zZXRfc3RyaW5nKGtleUZpbGUuZ2V0KCksICJBcHBsaWNhdGlv biIsICJuYW1lIiwgYXBwSUQpOworICAgIGdfa2V5X2ZpbGVfc2V0X3N0cmluZyhrZXlGaWxlLmdl dCgpLCAiSW5zdGFuY2UiLCAiaW5zdGFuY2UtaWQiLCBpbnN0YW5jZUlEKTsKKworICAgIHNpemVf dCBzaXplOworICAgIEdVbmlxdWVQdHI8Y2hhcj4gZGF0YShnX2tleV9maWxlX3RvX2RhdGEoa2V5 RmlsZS5nZXQoKSwgJnNpemUsIG51bGxwdHIpKTsKKyAgICByZXR1cm4gY3JlYXRlU2VhbGVkTWVt RmRXaXRoRGF0YSgiZmxhdHBhay1pbmZvIiwgZGF0YS5nZXQoKSwgc2l6ZSk7CiB9CiAKIGVudW0g Y2xhc3MgQmluZEZsYWdzIHsKQEAgLTcyMiw3ICs3MzMsOCBAQCBHUmVmUHRyPEdTdWJwcm9jZXNz PiBidWJibGV3cmFwU3Bhd24oR1N1YnByb2Nlc3NMYXVuY2hlciogbGF1bmNoZXIsIGNvbnN0IFBy b2NlcwogICAgIC8vIGZ1bGwgcGVybWlzc2lvbnMgdW5sZXNzIGl0IGNhbiBpZGVudGlmeSB5b3Ug YXMgYSBzbmFwIG9yIGZsYXRwYWsuCiAgICAgLy8gVGhlIGVhc2llc3QgbWV0aG9kIGlzIGZvciB1 cyB0byBwcmV0ZW5kIHRvIGJlIGEgZmxhdHBhayBhbmQgaWYgdGhhdAogICAgIC8vIGZhaWxzIGp1 c3QgYmxvY2tpbmcgcG9ydGFscyBlbnRpcmVseSBhcyBpdCBqdXN0IGJlY29tZXMgYSBzYW5kYm94 IGVzY2FwZS4KLSAgICBpbnQgZmxhdHBha0luZm9GZCA9IGNyZWF0ZUZsYXRwYWtJbmZvKCk7Cisg ICAgR1VuaXF1ZVB0cjxjaGFyPiBpbnN0YW5jZUlEKGdfc3RyZHVwX3ByaW50Zigid2Via2l0LSVz IiwgVVVJRDo6Y3JlYXRlVmVyc2lvbjQoKS50b1N0cmluZygpLnV0ZjgoKS5kYXRhKCkpKTsKKyAg ICBpbnQgZmxhdHBha0luZm9GZCA9IGNyZWF0ZUZsYXRwYWtJbmZvKGluc3RhbmNlSUQuZ2V0KCkp OwogICAgIGlmIChmbGF0cGFrSW5mb0ZkICE9IC0xKSB7CiAgICAgICAgIGdfc3VicHJvY2Vzc19s YXVuY2hlcl90YWtlX2ZkKGxhdW5jaGVyLCBmbGF0cGFrSW5mb0ZkLCBmbGF0cGFrSW5mb0ZkKTsK ICAgICAgICAgR1VuaXF1ZVB0cjxjaGFyPiBmbGF0cGFrSW5mb0ZkU3RyKGdfc3RyZHVwX3ByaW50 ZigiJWQiLCBmbGF0cGFrSW5mb0ZkKSk7CkBAIC03MzIsNiArNzQ0LDE1IEBAIEdSZWZQdHI8R1N1 YnByb2Nlc3M+IGJ1YmJsZXdyYXBTcGF3bihHU3VicHJvY2Vzc0xhdW5jaGVyKiBsYXVuY2hlciwg Y29uc3QgUHJvY2VzCiAgICAgICAgIH0pKTsKICAgICB9CiAKKyAgICAvLyB4ZGctZGVza3RvcC1w b3J0YWwgaGFyZGNvZGVzIHRoaXMgcGF0aCBhbmQgcmUtY29uc3RydWN0cyBpdCBmcm9tIHRoZSBp bnN0YW5jZS1pZCBpbiBgLy5mbGF0cGFrLWluZm9gIGFsb25lLgorICAgIEdVbmlxdWVQdHI8Y2hh cj4gaW5zdGFuY2VQYXRoKGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfdXNlcl9ydW50aW1lX2Rpcigp LCAiLmZsYXRwYWsiLCBpbnN0YW5jZUlELmdldCgpLCBudWxscHRyKSk7CisgICAgaW50IGJ3cmFw SW5mb0ZkID0gY3JlYXRlQndyYXBJbmZvRmQoaW5zdGFuY2VQYXRoLmdldCgpKTsKKyAgICBnX3N1 YnByb2Nlc3NfbGF1bmNoZXJfdGFrZV9mZChsYXVuY2hlciwgYndyYXBJbmZvRmQsIGJ3cmFwSW5m b0ZkKTsKKyAgICBHVW5pcXVlUHRyPGNoYXI+IGJ3cmFwSW5mb0ZkU3RyKGdfc3RyZHVwX3ByaW50 ZigiJWQiLCBid3JhcEluZm9GZCkpOworICAgIHNhbmRib3hBcmdzLmFwcGVuZFZlY3RvcihWZWN0 b3I8Q1N0cmluZz4oeworICAgICAgICAiLS1pbmZvLWZkIiwgYndyYXBJbmZvRmRTdHIuZ2V0KCkK KyAgICB9KSk7CisKICAgICBpZiAobGF1bmNoT3B0aW9ucy5wcm9jZXNzVHlwZSA9PSBQcm9jZXNz TGF1bmNoZXI6OlByb2Nlc3NUeXBlOjpXZWIpIHsKICNpZiBQTEFURk9STShXQVlMQU5EKSAmJiBV U0UoRUdMKQogICAgICAgICBpZiAoUGxhdGZvcm1EaXNwbGF5OjpzaGFyZWREaXNwbGF5KCkudHlw ZSgpID09IFBsYXRmb3JtRGlzcGxheTo6VHlwZTo6V2F5bGFuZCkgewo=